search

sagemath / sage-patchbot

Sage Patchbot
https://www.sagemath.org
Other
8 stars 17 forks source link

ignore invalid/dupe/wontfix tickets #48

Closed rwst closed 9 years ago

rwst commented 10 years ago

patchbot tries to test such tickets at the moment, see http://patchbot.sagemath.org/ticket/16591/

there isn't even code in there!

jakobkroeker commented 9 years ago

-close ticket?

-what if ['milestone'] string 'sage-duplicate/invalid/wontfix' will be changed in future? Is it possible to catch that issue (e.g. by having a checklist for changing template milestone descriptions with an entry 'please update patchbot, too') ?

fchapoton commented 9 years ago

Currently:

if not(ticket['status'] in ('needs_review', 'positive_review',
                                'needs_info', 'needs_work')):
        if verbose:
            print('only test needs_* or positive_review tickets')
        return

So I think this can be closed.