sagemath / sage-patchbot

Sage Patchbot
https://www.sagemath.org
Other
8 stars 17 forks source link

handling HTTP errors while asking for json data #59

Closed videlec closed 9 years ago

fchapoton commented 9 years ago

Line:

print("Getting ticket list...")

is duplicated

videlec commented 9 years ago

Right. And I noticed that one of the message in the RuntimeError is wrong. I will propose another commit.

fchapoton commented 9 years ago

The ValueError should be a RuntimeError, no ?

videlec commented 9 years ago

Yes. sorry.

videlec commented 9 years ago

Actually the way I did is not so clean. We might want to pass to the idle state when we fail to connect to the server... to be corrected.