Closed videlec closed 9 years ago
Well, sometimes bretelles + ceinture is a good thing.. But I see your point.
I would feel better if functions do not overlap. The code becomes much more readable.
This was avoiding to rate tickets for untrusted authors..
Tickets with untrusted authors are not rated: there is a "return" very early in the function. So either we get rid of this "filter_on_authors" or we get rid or the other "filter". We are currently filtering twice!
Ok, you are right. This will be much cleaner if all filtering job is done in rate_ticket
I hope so!
The check about trusted authors and trusted participants is done in the method rate_ticket. Hence it is not necessary to do it also in get_ticket.