sagemath / sage-patchbot

Sage Patchbot
https://www.sagemath.org
Other
8 stars 17 forks source link

remove filter on trusted authors since it is done in rate_ticket #60

Closed videlec closed 9 years ago

videlec commented 9 years ago

The check about trusted authors and trusted participants is done in the method rate_ticket. Hence it is not necessary to do it also in get_ticket.

fchapoton commented 9 years ago

Well, sometimes bretelles + ceinture is a good thing.. But I see your point.

videlec commented 9 years ago

I would feel better if functions do not overlap. The code becomes much more readable.

fchapoton commented 9 years ago

This was avoiding to rate tickets for untrusted authors..

videlec commented 9 years ago

Tickets with untrusted authors are not rated: there is a "return" very early in the function. So either we get rid of this "filter_on_authors" or we get rid or the other "filter". We are currently filtering twice!

fchapoton commented 9 years ago

Ok, you are right. This will be much cleaner if all filtering job is done in rate_ticket

videlec commented 9 years ago

I hope so!