Closed johanrosenkilde closed 7 years ago
Thanks! This is very helpful. Your English is much better than mine. Here are a few remarks.
sage-shell-mode
if you installed it by package.el
. Most packages use autoload
. I will fix it after merging.ipython5.0
branch is getting old. Could you send a pull request to fix-branch
next time? devel
branch also exits but I have not used it for long time.Anyway, thank you very much.
Cool, thanks for merging. Sure - I'll use fix-branch
next time.
I thought that require
was necessary when you want to e.g. add a hook (as in the eldoc example). That's not the case?
Sure - I'll use fix-branch next time.
Thanks.
I thought that require was necessary when you want to e.g. add a hook (as in the eldoc example). That's not the case?
add-hook
defines a global variable if the hook is not defined. So add-hook
works well with autoload
.
Ah, OK. Surely there'll be other cases where the require
is necessary, but as long as none of the commands suggested in the help file need it, I guess it can just be removed :-)
I went through the README and tried to make it more gentle and giving a better exemplification of what
sage-shell-mode
is good for. Some of it is similar to the landing page ofsage-mode
(which I wrote), butsage-shell-mode
had much more complete technical documentation thansage-mode
. I think the combination retains its informativeness while making it nicer for novice Emacs users.