Fix latex rendering in sage-shell-view

sagemath / sage-shell-mode

Emacs front end for SageMath

GNU General Public License v3.0

102 stars 16 forks source link

Fix latex rendering in sage-shell-view #71

Closed apresta closed 1 year ago

apresta commented 1 year ago

This fixes issue #61. Adapted from PR #70 with @aikrahguzar's help.

EmmanuelCharpentier commented 1 year ago

That's a better alternative than #72. However, it requires some documentation, and a default (initial) value.

I retracted (closed) #72.

Thanks !

apresta commented 1 year ago

@EmmanuelCharpentier sounds good, thanks. Can you please clarify what needs documenting and an initial value?

EmmanuelCharpentier commented 1 year ago

Can you please clarify what needs documenting and an initial value?

Document why this variable may be useful and what is its default value
Possibly give an example of customization (I have trouble thinking one...).

HTH,

apresta commented 1 year ago

This PR doesn't introduce any new variable, it actually deletes sage-shell-view-latex-math-environment which is no longer needed.

EmmanuelCharpentier commented 1 year ago

This PR doesn't introduce any new variable, it actually deletes sage-shell-view-latex-math-environment which is no longer needed.

Wups ! I reverse-read your patch....

Deepest apologies !

apresta commented 1 year ago

No problem!

hivert commented 1 year ago

Thanks a lot for this work ! Any show stopper merging this one ? Having to type "view(...)" each time and switching to my browser seriously disrupt my workflow.

dimpase commented 1 year ago

@EmmanuelCharpentier - I've promoted you to a maintainer of this repo, you can merge things now.

dimpase commented 1 year ago

@hivert - I can promote you to maintainer of this repo too - would you like to be one?

hivert commented 1 year ago

@hivert - I can promote you to maintainer of this repo too - would you like to be one?

First of all, thank for the proposition !

If I'd definitely like to help, I'm still at the script-kiddie level concerning emacs internals and lisp programming. I don't think I'm knowledgeable enough for the task. Sorry...

dimpase commented 1 year ago

@hivert - well, I suppose you can test things, and that's good enough. Of course I can merge this without looking (I haven't been using emacs for 20 years), but that's not as good.

EmmanuelCharpentier commented 1 year ago

@EmmanuelCharpentier - I've promoted you to a maintainer of this repo, you can merge things now.

Thanks ! I'll do that (I've reviewed this patch already, and I'm using it currently).

EmmanuelCharpentier commented 1 year ago

I just accepted the merge. It should appear on Melpa in a not too long time. Bug me if that doesn't happen.

EmmanuelCharpentier commented 1 year ago

Well...

This PR did reach MELPA.
The resulting package :
- does plot in the Sage buffer, but
- dos not typeset LaTeX.

whereas my local branch does. I'll investigate.

EmmanuelCharpentier commented 1 year ago

Could you please review this pull request which reintegrates @apresta 's fix, which somehow disappeared from the previous pull request I merged (after successfully reviewing its branch) ?

Thanks again...