search

sagemath / sage-windows

Build tools for the Sagemath Windows installer
350 stars 47 forks source link

Make `%colors Linux` the default for the Sage REPL #39

Closed slel closed 4 years ago

slel commented 4 years ago

Up to Sage 8.9, the Sage-Windows installer seems set to %colors LightBG (adapted to light background) by default, while it starts the Sage REPL on a dark background.

I don't know where that is set, and this file seems to set %colors Linux rather than %colors LightBG:

https://github.com/sagemath/sage-windows/blob/e74dd8c39826853f59c60162dcb0cbcf646d897b/dot_sage/ipython-5.0.0/profile_default/ipython_config.py

As a workaround, users can of course create an init.sage file with that setting, for example by opening the Sage shell and typing

echo "%colors Linux" >> ~/.sage/init.sage

but it would be nice to have that as the default if possible.

embray commented 4 years ago

I'm not really sure what you're asking here. For it to set LightBG or Linux? In any case this was fixed in v0.5.1 of the installer. If you installed an older build that had this bug it might not copy over your existing .sage. But for new installs it should already use Linux.

slel commented 4 years ago

Oh, sorry, I had missed that. I see now that this was fixed by

https://github.com/sagemath/sage-windows/commit/0d0e5032e35b2f6375167512c9298607702cb3f7

Thanks!!

embray commented 4 years ago

Feel free to reopen if the problem can still be reproduced, since I'm not sure if there was an issue for it before.