Change OEIS database internet address to its new adrress

[edd8e884-f507-429a-b577-5d554626c0fe]

The On-Line Encyclopedia of Integer Sequences (OEIS) moved to http://oeis.org/.

Replacing any occurrence of http://www.research.att.com/~njas/sequences/ by http://oeis.org/classic/ should do the job.

The following files should be modified accordingly:

sage/coding/sd_codes.py
sage/combinat/sloane_functions.py
sage/databases/sloane.py
sage/graphs/digraph_generators.py
sage/graphs/graph_generators.py
sage/rings/rational_field.py
sage/symbolic/constants.py

CC: @sagetrac-sage-combinat @sagetrac-ssivek @seblabbe @sagetrac-abmasse

Component: combinatorics

Author: Thierry Monteil

Reviewer: Mike Hansen

Merged: sage-4.6.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/10056

[edd8e884-f507-429a-b577-5d554626c0fe]

Description changed:

--- 
+++ 
@@ -2,30 +2,17 @@

 Replacing any occurrence of `http://www.research.att.com/~njas/sequences/` by `http://oeis.org/classic/` should do the job.

-For information,
+The following files should be modified accordingly:

-grep -R njas/sequences * +coding/sd_codes.py +combinat/sloane_functions.py +databases/sloane.py +graphs/digraph_generators.py +graphs/graph_generators.py +rings/rational_field.py +symbolic/constants.py

-returns:
- 
+Note that, before applying the patch, `rings/rational_field.py` produces an error when being tested. This error is not fixed by this patch.

-```
-coding/sd_codes.py:    According to http://www.research.att.com/~njas/sequences/A003179,
-combinat/sloane_functions.py:    link = "http://www.research.att.com/~njas/sequences/A000027"
-combinat/sloane_functions.py:    link = "http://www.research.att.com/~njas/sequences/A001110"
-databases/sloane.py:Note that the OEIS (http://www.research.att.com/ njas/sequences/)
-databases/sloane.py:    def install(self, oeis_url="http://www.research.att.com/~njas/sequences/stripped.gz", 
-                        names_url="http://www.research.att.com/~njas/sequences/names.gz", overwrite=False):
-databases/sloane.py:        url = "http://www.research.att.com/~njas/sequences/"
-graphs/digraph_generators.py:    http://www.research.att.com/~njas/sequences/A000273)
-graphs/graph_generators.py:    http://www.research.att.com/~njas/sequences/A033995)
-graphs/graph_generators.py:    http://www.research.att.com/~njas/sequences/A000088)
-graphs/graph_generators.py:    http://www.research.att.com/~njas/sequences/A000666)
-graphs/graph_generators.py:    http://www.research.att.com/~njas/sequences/A002851)::
-rings/rational_field.py:        #    http://www.research.att.com/~njas/sequences/A002487
-symbolic/constants.py:        # digits come from Sloane's tables at 
-                              http://www.research.att.com/~njas/sequences/table?a=65421&fmt=0
-```
-

[edd8e884-f507-429a-b577-5d554626c0fe]

Description changed:

--- 
+++ 
@@ -5,14 +5,14 @@
 The following files should be modified accordingly:

-coding/sd_codes.py -combinat/sloane_functions.py -databases/sloane.py -graphs/digraph_generators.py -graphs/graph_generators.py -rings/rational_field.py -symbolic/constants.py +sage/coding/sd_codes.py +sage/combinat/sloane_functions.py +sage/databases/sloane.py +sage/graphs/digraph_generators.py +sage/graphs/graph_generators.py +sage/rings/rational_field.py +sage/symbolic/constants.py

-Note that, before applying the patch, `rings/rational_field.py` produces an error when being tested. This error is not fixed by this patch.
+Note that, before applying the patch, `sage/rings/rational_field.py` produces an error when being tested. This error is not fixed by this patch.

[edd8e884-f507-429a-b577-5d554626c0fe]

Tested on 4.5.3

[edd8e884-f507-429a-b577-5d554626c0fe]

Author: Thierry Monteil

[edd8e884-f507-429a-b577-5d554626c0fe]

comment:3

Attachment: trac_10056-new_oeis_address-tm.patch.gz

[edd8e884-f507-429a-b577-5d554626c0fe]

Description changed:

--- 
+++ 
@@ -14,5 +14,4 @@
 sage/symbolic/constants.py

-Note that, before applying the patch, sage/rings/rational_field.py produces an error when being tested. This error is not fixed by this patch.

[a0e7ac7d-d8f3-4e97-aca8-5ab47a193e00]

comment:4

This shows why global constants are useful.

[edd8e884-f507-429a-b577-5d554626c0fe]

comment:5

Hi Alexandre,

i agree with your remark, though this was not a hard job to make a grep and 14 replacements by hand (and we can hope that the url won't change every year). I just wanted to be sure that when Sloane will remove the encyclopedia from his personal webpage, sage will not be affected.

Note that only 5 replacements come inside the code as variables, whereas 9 replacements arise in the documentation or comments. Is there a way to put variables in the documentation too?

Another remark that may help for the future: note that there was a trick: the urls beginning with http://www.research.att.com/~njas/hadamard should not be replaced by the new OEIS url (there are about 3 of them in sage), since they come from another work of Sloane, which is not the encyclopedia of integer sequences. In particular, if there was a global variable named sloane_web_page then it would have made more work to separate both kind of links.

[mwhansen]

comment:6

Looks good to me.

[mwhansen]

Reviewer: Mike Hansen

[jdemeyer]

Merged: sage-4.6.1.alpha0

[williamstein]

comment:9

Hi,

I know this ticket is closed, but I showed it to the current maintainer of OEIS, and he had several issues with it, which could be addressed in followup ticket(s):

"That ticket describes an update but not one that would have been needed to fix broken links. We've kept all the old www.research.att.com links running throughout the transition, including now. I haven't looked at the sage code to see what it is doing, but the ticket refers to http://oeis.org/classic, which was a transitional URL and is now gone (but like the others still forward properly). For what it's worth, the URL base should be http://oeis.org/ not http://oeis.org/classic and searches should be of the form http://oeis.org/search?q=query"