mwhansen
commented
13 years ago comment:40
Ping.
Closed mwhansen closed 12 years ago
mwhansen
commented
13 years ago Ping.
mwhansen
commented
13 years ago jdemeyer:
What's the best way to test a fix on that machine? Do I have to log into mark2 and do a full build or is there a way to access that build?
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago Attachment: trac_10335-solaris_issue.patch.gz
apply over previous patches
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago I don't have access to a Solaris machine to test this on; but, looking at the code, it's clear that (a) this Sage function just wraps the corresponding one in Gap, (b) the answer returned on Solaris is just as much a valid answer as that returned on other systems, and (c) there is already a perfectly good doctest for that function.
I strongly suggest that we change this doctest to something less sensitive, given that there is a huge pile of other code waiting on this. I have just uploaded a patch which does this.
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago Description changed:
---
+++
@@ -12,3 +12,4 @@
1. [attachment: trac_10335-permgroup_domain-mh.patch](https://github.com/sagemath/sage-prod/files/10651495/trac_10335-permgroup_domain-mh.patch.gz)
2. [attachment: trac_10335-permgroup_domain-import_loop_fix-nt.patch](https://github.com/sagemath/sage-prod/files/10651497/trac_10335-permgroup_domain-import_loop_fix-nt.patch.gz)
3. [attachment: trac_10335-tutorial-languages-fixes.patch](https://github.com/sagemath/sage-prod/files/10651498/trac_10335-tutorial-languages-fixes.patch.gz)
+4. [attachment: trac_10335-solaris_issue.patch](https://github.com/sagemath/sage-prod/files/10651499/trac_10335-solaris_issue.patch.gz)apply over previous patches
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago Attachment: trac_10335-updates.patch.gz
This has now bitrotted: several doctests fail in trivial ways on sage 4.7.2.alpha2. I've just uploaded a patch that fixes these.
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago Description changed:
---
+++
@@ -13,3 +13,4 @@
2. [attachment: trac_10335-permgroup_domain-import_loop_fix-nt.patch](https://github.com/sagemath/sage-prod/files/10651497/trac_10335-permgroup_domain-import_loop_fix-nt.patch.gz)
3. [attachment: trac_10335-tutorial-languages-fixes.patch](https://github.com/sagemath/sage-prod/files/10651498/trac_10335-tutorial-languages-fixes.patch.gz)
4. [attachment: trac_10335-solaris_issue.patch](https://github.com/sagemath/sage-prod/files/10651499/trac_10335-solaris_issue.patch.gz)
+5. [attachment: trac_10335-updates.patch](https://github.com/sagemath/sage-prod/files/10651500/trac_10335-updates.patch.gz)Changed work issues from Solaris doctest error to none
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago I've tested this on the Sun machine "mark" on skynet, and all doctests pass (except for a pre-existing error in matrix_double_dense which has nothing to do with this patch. Can someone please visually check that the two most recent patches attachment: trac_10335-solaris_issue.patch and attachment: trac_10335-updates.patch are morally sound? I'd be really disappointed if this bitrotted yet again.
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago FWIW, the "pre-existing error in matrix_double_dense" is a known issue coming from #10795, which has apparently been de-merged from the next release for this reason.
1d7ec08f-60ae-4512-91a6-8324c06eab9f
commented
13 years ago David's two recent patches look good to me, and update from a point where this had a positive review.
Applies, builds, passes long tests on 4.7.2.alpha2 and 64-bit Ubuntu 11.04. So, back to positive review with a hope it merges it OK, finally.
1d7ec08f-60ae-4512-91a6-8324c06eab9f
commented
13 years ago Changed author from Mike Hansen to Mike Hansen, David Loeffler
83660e46-0051-498b-a8c1-f7a7bd232b5a
commented
13 years ago I'm not sure whether removing a doctest is the proper way to fix a doctest error... ;-)
1d7ec08f-60ae-4512-91a6-8324c06eab9f
commented
13 years ago Replying to @nexttime:
I'm not sure whether removing a doctest is the proper way to fix a doctest error... ;-)
I agree. But in this case, I agree with David's argument. This patch implements a highly desirable feature with many doctests. And if I understand right, GAP uses some probabilistic algorithms, so we could tie ourselves in knots trying to rewrite this doctest.
My understanding (and some grep'ing appears to confirm) is that this is a new test. Would the patch have gone in without it if it had never appeared? I think so. If an existing test were failing, I'd be a lot less cavalier about dropping it.
Anyway, my $0.02 worth.
mwhansen
commented
13 years ago I think the correct fix would to be to add one of the current_randstate().set_seed_gap() lines to the beginning of that function.
83660e46-0051-498b-a8c1-f7a7bd232b5a
commented
13 years ago Replying to @mwhansen:
I think the correct fix would to be to add one of the
current_randstate().set_seed_gap()lines to the beginning of that function.
Or otherwise at least tag the doctest with # random, # not tested, # platform-specific(?) or whatever, since doing so documents the different behaviour.
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago I agree that in an ideal world it would be better to have another doctest for this function, but as Rob points out, there was no such doctest before this ticket anyway. So it seems absurd to hold up all of the other new functionality added by this ticket, and the two other positively-reviewed tickets depending on it, for such a reason.
If it matters that much, perhaps we should have a new ticket "improve doctests for wrapper of Gap function xxx".
jdemeyer
commented
13 years ago I agree with leif that adding a simple "# random" is an easy solution which at least documents the problem.
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago Aaargh! Do what you like, just MERGE IT SOMEHOW! If we miss the boat with this one again, and consequently #11422, #11598, #5048, #11601 and #10546 end up still trapped in purgatory, I will have to think very seriously about whether working on Sage in future is a productive use of my time.
83660e46-0051-498b-a8c1-f7a7bd232b5a
commented
13 years ago Replying to @loefflerd:
Aaargh! Do what you like, just MERGE IT SOMEHOW! If we miss the boat with this one again, and consequently #11422, #11598, #5048, #11601 and #10546 end up still trapped in purgatory, I will have to think very seriously about whether working on Sage in future is a productive use of my time.
Well, to be honest, it's not my problem that this ticket bit-rottened. I started merging tickets "officially" into alpha3 about two weeks ago IIRC (including some you participated in); this ticket got positive review 20 hours ago.
I agree that it's a pity, not just because other already positively reviewed tickets -- three of the other ones you mentioned still need review -- depend on this one, but as I told Rob yesterday, it would have to get rebased anyway, because of (at least) #11749, and I'm not going to back the latter out (or try to reapply it on top of tickets that haven't had positive review recently, again having to manually resolve conflicts and errors, some showing up only later during testing).
We haven't yet talked about the release plans for the final Sage 4.7.2, but I think there'll still be an alpha4 before we go into feature freeze, as there are other important things that still have to get fixed and should be solved in a final.
So IMHO it would be best to wait for the alpha3, hopefully released within the next days, and then rebase this ticket (and if necessary the others) on that.
[I didn't touch the tickets having milestone "sage-pending" (including #11422 and #11598) at all, since I don't know why Jeroen put them there, although I have to admit I also didn't try to find out, mainly because of lack of time. I early did ping the authors and reviewers of all other tickets that were holding up other positively reviewed ones though, with some success.]
W.r.t. the doctest with varying output:
It would IMHO be best to give the alternative, also correct result as an example, too, marking both # not tested, with an appropriate comment.
(And perhaps add a real doctest which tests a property common to both.)
jdemeyer
commented
13 years ago Replying to @nexttime:
I didn't touch the tickets having milestone "sage-pending" (including #11422 and #11598) at all, since I don't know why Jeroen put them there
I put them there because of the dependency on this ticket, no other reason.
1d7ec08f-60ae-4512-91a6-8324c06eab9f
commented
13 years ago Replying to @loefflerd:
Aaargh! Do what you like, just MERGE IT SOMEHOW!
Leif - thanks for the help with this one. With classes starting, I really wasn't in a position to be chasing the evolving alpha, so I had to pass on that offer, but appreciate the willingness.
David - How about the following?
Wait for alpha3 (which sounds big already).
I mark the disputed test # random.
I rebase on alpha3 in preparation for alpha4.
You review (2) and (3).
We quickly identify if the tickets in Permutation Group Purgatory needing changes/rebasing.
Lemme know and I'll carve out time to make it happen.
Rob
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago That sounds like a good solution -- thanks for volunteering to do (2) and (3). I can take care of (5).
My apologies, particularly to Leif, for my outburst earlier.
1d7ec08f-60ae-4512-91a6-8324c06eab9f
commented
13 years ago Replying to @loefflerd:
That sounds like a good solution -- thanks for volunteering to do (2) and (3). I can take care of (5).
Great! We have a plan. Thanks for taking (5).
Leif and/or Jeroen - feel free to ping us if we need to move quickly on something.
At the ready, Rob
83660e46-0051-498b-a8c1-f7a7bd232b5a
commented
13 years ago Replying to @rbeezer:
- Wait for alpha3 (which sounds big already).
[...]
- I rebase on alpha3 in preparation for alpha4.
[...]
- We quickly identify if the tickets in Permutation Group Purgatory needing changes / rebasing.
For the impatient, an updated tarball and source tree for upgrading can be found in
http://sage.math.washington.edu/home/leif/Sage/release/sage-4.7.2.alpha3-prerelease/.
I don't expect further changes to the alpha3 release, except for a few only fixing some doctest errors due to numerical noise below
sage/rings/polynomial/ andsage/matrix/,
and perhaps some clean-up like adding ticket numbers to commit messages lacking them, so it should be safe to (re)base patches on this version.1d7ec08f-60ae-4512-91a6-8324c06eab9f
commented
13 years ago Replying to @nexttime:
For the impatient
Perfect - thanks! Building now, will tinker tonight.
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago Attachment: trac_10335-permgroup_domain-rebase.patch.gz
patch against 4.7.2.alpha3 prerelease
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago I had a few minutes free this afternoon, so I've done a rebased patch myself. This is just the existing patches rebased and folded, but with the doctest in permgroup.py marked as random rather than deleted, and with examples of the output I got on a Linux and a Solaris machine.
Rob: any chance you could review this? Apologies if you'd already started rebasing this yourself as per our earlier agreement -- in that case feel free to ignore my patch and I'll review yours.
Leif: you might be interested to hear that this prerelease builds and passes long doctests without problems on my 64-bit Linux machine -- no numerical noise or anything like that.
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago Description changed:
---
+++
@@ -9,8 +9,4 @@Apply: -1. attachment: trac_10335-permgroup_domain-mh.patch -2. attachment: trac_10335-permgroup_domain-import_loop_fix-nt.patch -3. attachment: trac_10335-tutorial-languages-fixes.patch -4. attachment: trac_10335-solaris_issue.patch -5. attachment: trac_10335-updates.patch +1. attachment: trac_10335-permgroup_domain-rebase.patch
David - no problem, I'll do a review. I have no free minutes today. So tonight. ;-)
Probably about 8-10 hours from now. Thanks for hopping on this one.
83660e46-0051-498b-a8c1-f7a7bd232b5a
commented
13 years ago Replying to @loefflerd:
Leif: you might be interested to hear that this prerelease builds and passes long doctests without problems on my 64-bit Linux machine -- no numerical noise or anything like that.
If you also tell me what CPU you built on... (e.g. top of /proc/cpuinfo, i.e., only for the first core...)
Might be interesting.
1d7ec08f-60ae-4512-91a6-8324c06eab9f
commented
13 years ago Replying to @rbeezer:
Probably about 8-10 hours from now.
My build was interrupted (long story) and now two files are giving segfaults when I doctest, with or without the patch. Don't panic - likely entirely all my fault. So anyway, I'm starting over and building overnight. Stay tuned.
Rob
1d7ec08f-60ae-4512-91a6-8324c06eab9f
commented
13 years ago alpha3-prerelease segfaults during testing, without patch. Errors, followed by system info. I can follow up with more testing, if requested.
The following tests failed:
sage -t -long -force_lib devel/sage/sage/modular/modsym/ambient.py # 0 doctests failed
sage -t -long -force_lib devel/sage/sage/modular/hecke/ambient_module.py # 0 doctests failed
sage -t -long -force_lib devel/sage/sage/modular/hecke/hecke_operator.py # 0 doctests failed
----------------------------------------------------------------------
Total time for all tests: 2701.6 seconds
make: *** [ptestlong] Error 128rob@lava:/sage/sage-4.7.2.alpha3-prerelease$ ./sage -t -long -force_lib devel/sage/sage/modular/modsym/ambient.py
sage -t -long -force_lib "devel/sage/sage/modular/modsym/ambient.py"
/sage/sage-4.7.2.alpha3-prerelease/local/lib/libcsage.so(print_backtrace+0x31)[0x7fd8e335834f]
/sage/sage-4.7.2.alpha3-prerelease/local/lib/libcsage.so(sigdie+0x14)[0x7fd8e3358381]
/sage/sage-4.7.2.alpha3-prerelease/local/lib/libcsage.so(sage_signal_handler+0x20e)[0x7fd8e3357fb4]
/lib/x86_64-linux-gnu/libpthread.so.0(+0xfc60)[0x7fd8e484fc60]
/sage/sage-4.7.2.alpha3-prerelease/local/lib/libatlas.so(ATL_dJIK44x44x44TN44x44x0_a1_b0+0x9d)[0x7fd8da12c3ed]
------------------------------------------------------------------------
Unhandled SIGSEGV: A segmentation fault occurred in Sage.
This probably occurred because a *compiled* component of Sage has a bug
in it and is not properly wrapped with sig_on(), sig_off(). You might
want to run Sage under gdb with 'sage -gdb' to debug this.
Sage will now terminate.
------------------------------------------------------------------------
Segmentation fault
[5.9 s]
----------------------------------------------------------------------
The following tests failed:
sage -t -long -force_lib "devel/sage/sage/modular/modsym/ambient.py"
Total time for all tests: 5.9 secondsrob@lava:/sage/sage-4.7.2.alpha3-prerelease$ uname -a
Linux lava 2.6.38-10-generic #46-Ubuntu SMP Tue Jun 28 15:07:17 UTC 2011 x86_64 x86_64 x86_64 GNU/Linuxrob@lava:/sage/sage-4.7.2.alpha3-prerelease$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/x86_64-linux-gnu/gcc/x86_64-linux-gnu/4.5.2/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro 4.5.2-8ubuntu4' --with-bugurl=file:///usr/share/doc/gcc-4.5/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.5 --enable-shared --enable-multiarch --with-multiarch-defaults=x86_64-linux-gnu --enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib/x86_64-linux-gnu --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.5 --libdir=/usr/lib/x86_64-linux-gnu --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-plugin --enable-gold --enable-ld=default --with-plugin-ld=ld.gold --enable-objc-gc --disable-werror --with-arch-32=i686 --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 4.5.2 (Ubuntu/Linaro 4.5.2-8ubuntu4) rob@lava:/sage/sage-4.7.2.alpha3-prerelease$ cat /proc/cpuinfo
processor : 0
vendor_id : GenuineIntel
cpu family : 6
model : 42
model name : Intel(R) Core(TM) i7-2600 CPU @ 3.40GHz
stepping : 7
cpu MHz : 1600.000
cache size : 8192 KB
physical id : 0
siblings : 8
core id : 0
cpu cores : 4
apicid : 0
initial apicid : 0
fpu : yes
fpu_exception : yes
cpuid level : 13
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 cx16 xtpr pdcm sse4_1 sse4_2 x2apic popcnt aes xsave avx lahf_lm ida arat epb xsaveopt pln pts dts tpr_shadow vnmi flexpriority ept vpid
bogomips : 6822.05
clflush size : 64
cache_alignment : 64
address sizes : 36 bits physical, 48 bits virtual
power management:Replying to @rbeezer:
alpha3-prerelease segfaults during testing, without patch. Errors, followed by system info. I can follow up with more testing, if requested.
That's either due to Linaro, or, more likely, an ATLAS problem, since our version afaik doesn't yet support Sandy Bridge (second generation "Core i").
You could try using your system's ATLAS (may have to install it with your package manager first), by doing:
$ export SAGE_ATLAS_LIB=/usr/lib64/atlas # the directory; usual place on 64-bit Linux
$ rm $SAGE_ROOT/spkg/installed/atlas-*
$ cd $SAGE_ROOT
$ env SAGE_UPGRADING=yes make # or "... make build"The SAGE_UPGRADING=yes is important to (really) rebuild all dependent packages as well.
83660e46-0051-498b-a8c1-f7a7bd232b5a
commented
13 years ago Replying to @nexttime:
$ export SAGE_ATLAS_LIB=/usr/lib64/atlas # the directory; usual place on 64-bit Linux
...Might be /usr/lib/x86_64-linux-gnu/atlas/ on your system; you should check this before attempting to build... ;-)
1d7ec08f-60ae-4512-91a6-8324c06eab9f
commented
13 years ago Thanks, Leif. Ubuntu installs ATLAS into /usr/lib64/atlas-base. Then setting up everything as you describe, suitably adjusted yields:
Unable to find one of liblapack, libcblas, libatlas or libf77blas
in the directory /usr/lib64/atlas-base
Set SAGE_ATLAS_LIB to the directory containing liblapack, libcblas,
libatlas and libf77blas (either .a or .so extensions) if you wish to
use existing ATLAS libraries. For more details, seeI've installed the packages liblapack3gf, libblas3gf but cannot see anything to provide libf77blas and do not know if I am getting libcblas. Furthermore, these all go to different directories.
Any advice? My Sandy Bridge motherboard is about 8 months old. Will anybody with a newer chip have to go through a drill like this? Would Volker's ATLAS ticket be a better/workable approach?
83660e46-0051-498b-a8c1-f7a7bd232b5a
commented
13 years ago Replying to @rbeezer:
I've installed the packages
liblapack3gf, libblas3gfbut cannot see anything to provide libf77blas and do not know if I am getting libcblas. Furthermore, these all go to different directories.
I've asked Volker on the IRC for help. (Perhaps drop in if you can.)
If some libraries are simply in different directories, you could just create symbolic links to them in the .../atlas-base/ directory. (Although there IMHO shouldTM be a directory containing all; are there some more self-contained ATLAS packages you could install?)
My Sandy Bridge motherboard is about 8 months old.
That shouldn't matter; Intel's bug just causes a SATA part of the chipset to die earlier.
Whether AVX is available depends on your board (and chipset); if you have on-board graphics, AVX isn't usable.
Will anybody with a newer chip have to go through a drill like this?
Simon King did successfully build the prerelease on a (Sandy Bridge) Core i3 with Debian x86_64; there only five doctests (in three files) failed due to numerical noise (the same doctests that failed on some other "rare" and older platforms).
vbraun
commented
13 years ago The following bug in Ubuntu launchpad says that the symlinks for the standard libraries are not created: https://bugs.launchpad.net/ubuntu/+source/atlas/+bug/769180 So you either create them manually (in a directory of your choice), or you compile ATLAS again. For the latter, you should probably try to set
export SAGE_ATLAS_ARCH=Corei7,SSE3,SSE2,SSE1This works only with the new atlas spkg (4.7.2.alpha3+)
vbraun
commented
13 years ago AVX is just the CPU instruction set extension du jour. The version of ATLAS that we are shipping knows nothing about AVX. All 2011 sandy bridge cpus have it, irrespective of on-board graphics.
83660e46-0051-498b-a8c1-f7a7bd232b5a
commented
13 years ago Replying to @vbraun:
AVX is just the CPU instruction set extension du jour. The version of ATLAS that we are shipping knows nothing about AVX.
Aha. Wasn't sure about that. But does 3.8.4 "know" Sandy Brigde already?
All 2011 sandy bridge cpus have it, irrespective of on-board graphics.
They have it, but you can only use it when the CPU doesn't also act as a GPU. And afaik that's hard-wired, i.e., you even cannot use it if your motherboard has on-board graphics you don't actually use.
83660e46-0051-498b-a8c1-f7a7bd232b5a
commented
13 years ago Replying to @vbraun:
This works only with the new atlas spkg (4.7.2.alpha3+)
I guess you meant alpha2+.
Apparently alpha2 in contrast did not segfault for Rob (on that machine), despite having the same ATLAS spkg. At least that's my understanding.
vbraun
commented
13 years ago Oh yes, it was merged in alpha2.
This is now completely OT, but my (Sandy Bridge) Thinkpad W520 uses the on-board GPU and has AVX:
[vbraun@volker-laptop-two ~]$ cat /proc/cpuinfo | head -24
processor : 0
vendor_id : GenuineIntel
cpu family : 6
model : 42
model name : Intel(R) Core(TM) i7-2720QM CPU @ 2.20GHz
stepping : 7
cpu MHz : 2201.000
cache size : 6144 KB
physical id : 0
siblings : 8
core id : 0
cpu cores : 4
apicid : 0
initial apicid : 0
fpu : yes
fpu_exception : yes
cpuid level : 13
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx rdtscp lm constant_tsc arch_perfmon pebs bts nopl xtopology nonstop_tsc aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 cx16 xtpr pdcm sse4_1 sse4_2 x2apic popcnt aes xsave avx lahf_lm ida arat epb xsaveopt pln pts dts tpr_shadow vnmi flexpriority ept vpid
bogomips : 4385.92
clflush size : 64
cache_alignment : 64
address sizes : 36 bits physical, 48 bits virtual
power management:Leif and Volker,
Thanks for the quick help, and I apologize to the group theorists for diverting this ticket. I've got to attend to some other things the rest of today, but I'll see if I can get the symlinks in place with guidance from that bug report.
I have Sandy Bridge with no on-board graphics. I have built and tested alpha2 - this is my first problem like this.
Rob
83660e46-0051-498b-a8c1-f7a7bd232b5a
commented
13 years ago Replying to @rbeezer:
Leif and Volker,
Thanks for the quick help, and I apologize to the group theorists for diverting this ticket.
Yep, we can continue the discussion on e.g. this sage-release thread, or -- preferably -- a new one there.
1d7ec08f-60ae-4512-91a6-8324c06eab9f
commented
13 years ago alpha3 prerelease build is fixed and passes long tests, with and without this rebased patch. To quote William "merge that sucker"! In other words, positive review.
Second line of patch summary message credits Jason Hill - I'll add him to the authors, and Mike's name is still on the main patch.
David - feel free to cc me on any of the follow-on tickets that might need review, especially if they are cosmetic changes. I have not yet looked at them at all.
Leif - thanks for your attention to this one and help with my build challenges.
Everybody else - my apologies again for getting this ticket off the tracks. I need to post a summary on sage-release.
Rob
1d7ec08f-60ae-4512-91a6-8324c06eab9f
commented
13 years ago Changed author from Mike Hansen, David Loeffler to Mike Hansen, Jason Hill, David Loeffler
11d1fc49-71a1-44e1-869f-76be013245a0
commented
13 years ago Hi Rob,
Thanks for the review! I have tested the two tickets that follow on directly from this (#11422 and #11598) and they apply fine and pass doctests, so no futher reviewing is needed; I'm going to move them back to the 4.7.2 milestone (from "sage-pending").
Regards, David
83660e46-0051-498b-a8c1-f7a7bd232b5a
commented
12 years ago Merged: sage-4.7.2.alpha3
0f5ae6f6-e03a-45d9-b571-4ce01615e676
commented
12 years ago Hello and sorry to add a comment on a closed ticket. I have a patch which depend on it and the patchbot try to apply 2 patches instead one here.
apply trac_10335-permgroup_domain-rebase.patch
Often, one wants to define a permutation group on a set other than
{1,2,...,n}such as say{'a', 'b', 'c', 'd'}.For example,
Apply:
Depends on #10334
CC: @sagetrac-sage-combinat @sagetrac-jasonbhill @rbeezer @jdemeyer
Component: group theory
Keywords: sd31
Author: Mike Hansen, Jason Hill, David Loeffler
Reviewer: Robert Miller, Rob Beezer, Nicolas Borie, Nicolas M. Thiéry
Merged: sage-4.7.2.alpha3
Issue created by migration from https://trac.sagemath.org/ticket/10335