Update PARI to version 2.5.0

jdemeyer commented 13 years ago

We need to add bugfixes for

http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147 (related to #9334)
http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153 (#10195)
http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1154 (#11604)
http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184 (related to #9937)
http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185 (PARI bug discovered by a Sage doctest)
http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186 (PARI performance regression discovered by a Sage doctest)
http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187 (PARI bug discovered by a Sage doctest)
http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188 (PARI bug discovered by a Sage doctest)
http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192 (#10767)

We will do this by updating to PARI version 2.5.0, which is equal to svn revision 13228.

See also:

9343, #10430 (previous PARI upgrades)
10247 (Sage 4.6 has PARI problems on Cygwin)
10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin), included in the 2.4.3.alpha.p7 spkg at #11605
11605 (Typos in PARI's spkg-install (2.4.3.alpha.p5)), included in the 2.4.3.alpha.p7 spkg at #11605

Apply:

spkg http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p2.spkg (jdemeyer)
spkg http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p9.spkg (from #11321)
attachment: 11130_sagelib.patch (jdemeyer, cremona)
attachment: 11130-sagelib-simon-v2.patch (cremona, jdemeyer)
attachment: 11130_reviewer32.patch (jdemeyer)
attachment: 11130-4.7.2.alpha3.patch (jdemeyer)
attachment: 11130-4.8.alpha1.patch (jdemeyer)
extcode patch attachment: 11130-extcode-v2.patch (cremona, jdemeyer)

Depends on #11321

Dependencies: #11321 (install this '''after''' building PARI)

CC: @mstreng @dimpase @jpflori

Component: packages: standard

Keywords: pari spkg sd32

Author: Jeroen Demeyer, John Cremona

Reviewer: John Cremona, Jeroen Demeyer, William Stein

Merged: sage-4.8.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/11130

jdemeyer commented 13 years ago

Changed dependencies from #11230, #11234 to #11230, #11234, #11321

jdemeyer commented 13 years ago

comment:46

See #11321 for lcalc.

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -13,6 +13,7 @@

 See also #9343, #10430 (previous PARI upgrades).
 See also #10247 (Sage 4.6 has PARI problems on Cygwin).
+We need to fix also lcalc: #11321.

 All doctest failures related to *simon_two_descent* will be fixed in #11005 and should be *ignored* for this ticket.

jdemeyer commented 13 years ago

Changed dependencies from #11230, #11234, #11321 to #11230, #11234, #11321 (install this '''after''' building PARI)

jdemeyer commented 13 years ago

comment:48

I built Sage completely from scratch with the new PARI and lcalc packages, everything works. All tests pass except for the ones related to simon_two_descent.

jdemeyer commented 13 years ago

Work Issues: Fix simon_two_descent doctests

JohnCremona commented 13 years ago

comment:49

Replying to @jdemeyer:

I built Sage completely from scratch with the new PARI and lcalc packages, everything works. All tests pass except for the ones related to simon_two_descent.

So is the "Needs work" just because this ticket is dependent on #11005? I am planning to look now at the doctest failures relating to the Simon scripts and fix them, so that this ticket can then be closed, and the additional work needed on #11005 can depend on this.

jdemeyer commented 13 years ago

comment:50

Replying to @JohnCremona:

I am planning to look now at the doctest failures relating to the Simon scripts and fix them, so that this ticket can then be closed, and the additional work needed on #11005 can depend on this.

That's precisely what I proposed.

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -15,8 +15,6 @@
 See also #10247 (Sage 4.6 has PARI problems on Cygwin).
 We need to fix also lcalc: #11321.

-All doctest failures related to *simon_two_descent* will be fixed in #11005 and should be *ignored* for this ticket.
-
 Spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg)

 Apply [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) and [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) and [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz).

JohnCremona commented 13 years ago

comment:51

Replying to @jdemeyer:

Replying to @JohnCremona:

I am planning to look now at the doctest failures relating to the Simon scripts and fix them, so that this ticket can then be closed, and the additional work needed on #11005 can depend on this.

That's precisely what I proposed.

OK, so that's what I am working on doing. Patch up shortly. However, I ran into something awkward: the script ellQ.gp in data/extcode/pari/simon crashed randomly in the function ellredgen (using this new pari version). I saw that the offending lines had been changed in the newer ellQ.gp as found in #11005, so I made the same changes. This sorts the problem, but it means that for this ticket to be finished we need to also make a small patch to extcode. Any problems with that?

JohnCremona commented 13 years ago

Apply to sage library after previous

JohnCremona commented 13 years ago

Attachment: 11130-sagelib-simon.patch.gz

Attachment: 11130-extcode-simon.patch.gz

Apply to extcode repository

JohnCremona commented 13 years ago

Description changed:

--- 
+++ 
@@ -17,4 +17,4 @@

 Spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg)

-Apply [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) and [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) and [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz).
+Apply [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) and [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) and [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz) and [attachment: 11130-sagelib-simon.patch](https://github.com/sagemath/sage-prod/files/10652572/11130-sagelib-simon.patch.gz) and [attachment: 11130-extcode-simon.patch](https://github.com/sagemath/sage-prod/files/10652573/11130-extcode-simon.patch.gz).

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -13,8 +13,13 @@

 See also #9343, #10430 (previous PARI upgrades).
 See also #10247 (Sage 4.6 has PARI problems on Cygwin).
-We need to fix also lcalc: #11321.

-Spkg: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg)
-
-Apply [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) and [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) and [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz) and [attachment: 11130-sagelib-simon.patch](https://github.com/sagemath/sage-prod/files/10652572/11130-sagelib-simon.patch.gz) and [attachment: 11130-extcode-simon.patch](https://github.com/sagemath/sage-prod/files/10652573/11130-extcode-simon.patch.gz).
+**Apply:**
+1. dependencies #11230 and #11234
+2. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg)
+3. spkg #11321 [http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p7.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p7.spkg)
+4. [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz)
+5. [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz)
+6. [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz)
+7. [attachment: 11130-sagelib-simon.patch](https://github.com/sagemath/sage-prod/files/10652572/11130-sagelib-simon.patch.gz)
+8. extcode patch [attachment: 11130-extcode-simon.patch](https://github.com/sagemath/sage-prod/files/10652573/11130-extcode-simon.patch.gz).

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -18,8 +18,9 @@
 1. dependencies #11230 and #11234
 2. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg)
 3. spkg #11321 [http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p7.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p7.spkg)
-4. [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz)
-5. [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz)
-6. [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz)
-7. [attachment: 11130-sagelib-simon.patch](https://github.com/sagemath/sage-prod/files/10652572/11130-sagelib-simon.patch.gz)
-8. extcode patch [attachment: 11130-extcode-simon.patch](https://github.com/sagemath/sage-prod/files/10652573/11130-extcode-simon.patch.gz).
+4. [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) (jdemeyer)
+5. [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) (cremona)
+6. [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz) (cremona)
+7. [attachment: 11130-sagelib-simon.patch](https://github.com/sagemath/sage-prod/files/10652572/11130-sagelib-simon.patch.gz) (cremona)
+8. [attachment: 11130_reviewer32.patch](https://github.com/sagemath/sage-prod/files/10652577/11130_reviewer32.patch.gz) (jdemeyer)
+9. extcode patch [attachment: 11130-extcode-simon.patch](https://github.com/sagemath/sage-prod/files/10652573/11130-extcode-simon.patch.gz) (cremona)

jdemeyer commented 13 years ago

Changed work issues from Fix simon_two_descent doctests to none

JohnCremona commented 13 years ago

comment:55

Is the only thing stopping this going forward the latest reviewer patch?

jdemeyer commented 13 years ago

comment:56

As far as I know, all patches and spkgs still need review. I can review your patches (but give me some time).

JohnCremona commented 13 years ago

comment:57

Replying to @jdemeyer:

As far as I know, all patches and spkgs still need review. I can review your patches (but give me some time).

Well I considered that I had reviewed (positively) everything except my last patch fixing the Simon doctests so that's the only thing left needing a review (from you perhaps, especially as you made some extra fixes for 32/64 bit issues).

jdemeyer commented 13 years ago

comment:58

Also lcalc (#11321) needs review.

kcrisman commented 13 years ago

comment:59

The part of the ticket that fixes #10240 is okay, I think.

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -9,18 +9,17 @@
 8. #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin).  We simply use the spkg patch from that ticket.
 9. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192) (#10767)

-We will do this by updating to PARI version 2.4.4.BETA, which is equal to **svn revision 13169**.
+We will do this by updating to PARI version 2.5.0), which is equal to **svn revision 13228**.

 See also #9343, #10430 (previous PARI upgrades).
 See also #10247 (Sage 4.6 has PARI problems on Cygwin).

 **Apply:**
-1. dependencies #11230 and #11234
-2. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.4.4.p0.spkg)
-3. spkg #11321 [http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p7.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p7.spkg)
-4. [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) (jdemeyer)
-5. [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) (cremona)
-6. [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz) (cremona)
-7. [attachment: 11130-sagelib-simon.patch](https://github.com/sagemath/sage-prod/files/10652572/11130-sagelib-simon.patch.gz) (cremona)
-8. [attachment: 11130_reviewer32.patch](https://github.com/sagemath/sage-prod/files/10652577/11130_reviewer32.patch.gz) (jdemeyer)
-9. extcode patch [attachment: 11130-extcode-simon.patch](https://github.com/sagemath/sage-prod/files/10652573/11130-extcode-simon.patch.gz) (cremona)
+1. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p0.spkg)
+2. spkg #11321 [http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p7.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p7.spkg)
+3. [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) (jdemeyer)
+4. [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) (cremona)
+5. [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz) (cremona)
+6. [attachment: 11130-sagelib-simon.patch](https://github.com/sagemath/sage-prod/files/10652572/11130-sagelib-simon.patch.gz) (cremona)
+7. [attachment: 11130_reviewer32.patch](https://github.com/sagemath/sage-prod/files/10652577/11130_reviewer32.patch.gz) (jdemeyer)
+8. extcode patch [attachment: 11130-extcode-simon.patch](https://github.com/sagemath/sage-prod/files/10652573/11130-extcode-simon.patch.gz) (cremona)

kcrisman commented 13 years ago

comment:61

See #10240 for a request to merge that in 4.7.2 (or whatever the next version is) if this isn't getting merged quickly.

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 13 years ago

comment:62

See #11605 for a PARI 2.4.3.alpha.p7 spkg with minor but important fixes to spkg-install (and some corrections in SPKG.txt). I've meanwhile based this on Dima's p6 (which just adds a small, harmless change for Cygwin) from #10240.

(Haven't yet looked at this ticket / spkg here at all.)

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 13 years ago

Description changed:

--- 
+++ 
@@ -1,18 +1,27 @@
 We need to add bugfixes for
 1. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147) (#9334)
 2. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153) (#10195)
-3. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184) (related to #9937)
-4. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185) (PARI bug discovered by a Sage doctest)
-5. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186) (PARI performance regression discovered by a Sage doctest)
-6. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187) (PARI bug discovered by a Sage doctest)
-7. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188) (PARI bug discovered by a Sage doctest)
-8. #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin).  We simply use the spkg patch from that ticket.
-9. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192) (#10767)
+3. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1154](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1154) (#11604)
+4. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184) (related to #9937)
+5. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185) (PARI bug discovered by a Sage doctest)
+6. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186) (PARI performance regression discovered by a Sage doctest)
+7. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187) (PARI bug discovered by a Sage doctest)
+8. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188) (PARI bug discovered by a Sage doctest)
+9. #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin).  We simply use the spkg patch from that ticket.
+10. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192) (#10767)

-We will do this by updating to PARI version 2.5.0), which is equal to **svn revision 13228**.
+We will do this by updating to PARI version 2.5.0, which is equal to **svn revision 13228**.

-See also #9343, #10430 (previous PARI upgrades).
-See also #10247 (Sage 4.6 has PARI problems on Cygwin).
+---
+
+See also:
+* #9343, #10430 (previous PARI upgrades)
+* #10247 (Sage 4.6 has PARI problems on Cygwin)
+* #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin), included in the 2.4.3.alpha.p7 spkg at #11605
+* #11604 (PARI qfminim bug on 32-bit systems (Sage 4.7 and 4.6.2)), providing a 2.4.3.alpha.p8 spkg which fixes PARI bug 1154 (see above)
+* #11605 ([Severe] Typos in PARI's spkg-install (2.4.3.alpha.p5)), included in the 2.4.3.alpha.p8 spkg at #11604
+
+---

 **Apply:**
 1. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p0.spkg)

jdemeyer commented 13 years ago

comment:64

Needs to be rebased to sage-2.4.3.alpha7.spkg (#11605).

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -18,8 +18,7 @@
 * #9343, #10430 (previous PARI upgrades)
 * #10247 (Sage 4.6 has PARI problems on Cygwin)
 * #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin), included in the 2.4.3.alpha.p7 spkg at #11605
-* #11604 (PARI qfminim bug on 32-bit systems (Sage 4.7 and 4.6.2)), providing a 2.4.3.alpha.p8 spkg which fixes PARI bug 1154 (see above)
-* #11605 ([Severe] Typos in PARI's spkg-install (2.4.3.alpha.p5)), included in the 2.4.3.alpha.p8 spkg at #11604
+* #11605 (Typos in PARI's spkg-install (2.4.3.alpha.p5)), included in the 2.4.3.alpha.p7 spkg at #11605

 ---

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 13 years ago

Work Issues: Rebase on PARI(!) 2.4.3.alpha.p7 spkg from #11605

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -23,7 +23,7 @@
 ---

 **Apply:**
-1. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p0.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p0.spkg)
+1. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p1.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p1.spkg)
 2. spkg #11321 [http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p7.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p7.spkg)
 3. [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) (jdemeyer)
 4. [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) (cremona)

jdemeyer commented 13 years ago

Changed work issues from Rebase on PARI(!) 2.4.3.alpha.p7 spkg from #11605 to none

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -7,8 +7,7 @@
 6. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186) (PARI performance regression discovered by a Sage doctest)
 7. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187) (PARI bug discovered by a Sage doctest)
 8. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188) (PARI bug discovered by a Sage doctest)
-9. #10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin).  We simply use the spkg patch from that ticket.
-10. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192) (#10767)
+9. [http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192](http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192) (#10767)

 We will do this by updating to PARI version 2.5.0, which is equal to **svn revision 13228**.

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -22,8 +22,8 @@
 ---

 **Apply:**
-1. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p1.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p1.spkg)
-2. spkg #11321 [http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p7.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p7.spkg)
+1. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p1.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p1.spkg) (jdemeyer)
+2. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p8.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p8.spkg) (from #11321)
 3. [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) (jdemeyer)
 4. [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) (cremona)
 5. [attachment: 11130_sagelib32.patch](https://github.com/sagemath/sage-prod/files/10652571/11130_sagelib32.patch.gz) (cremona)

jdemeyer commented 13 years ago

comment:69

The spkg does not build on Mac OS X because of an upstream bug. There is a fix in PARI svn revision 13318 which I should add to this spkg.

jdemeyer commented 13 years ago

comment:70

My comment refered to a Mac OS X 10.4 PPC machine, other machines might still work.

jdemeyer commented 13 years ago

comment:71

New spkg fixing the OS X issue: http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p2.spkg

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -22,7 +22,7 @@
 ---

 **Apply:**
-1. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p1.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p1.spkg) (jdemeyer)
+1. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p2.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p2.spkg) (jdemeyer)
 2. spkg [http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p8.spkg](http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p8.spkg) (from #11321)
 3. [attachment: 11130_sagelib.patch](https://github.com/sagemath/sage-prod/files/10652575/11130_sagelib.patch.gz) (jdemeyer)
 4. [attachment: trac_11130-doctest-poly.patch](https://github.com/sagemath/sage-prod/files/10652570/trac_11130-doctest-poly.patch.gz) (cremona)

jdemeyer commented 13 years ago

comment:72

Never mind, still doesn't work. Need to also add revision 13330.

jdemeyer commented 13 years ago

comment:73

New version which does build on OS X 10.4, same location: http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p2.spkg

jdemeyer commented 13 years ago

Attachment: 11130_spkg.diff.gz

Diff for the pari spkg, for reviewing only

jdemeyer commented 13 years ago

comment:74

I did a small rebase of attachment: 11130_sagelib.patch regarding sage/matrix/matrix2.pyx

JohnCremona commented 13 years ago

comment:75

Before I set about applying everything and testing, which I will do, can you tell me which Sage version I should be patching against? I have 4.7.1.rc1, is that the best? Or plain 4.7?

jdemeyer commented 13 years ago

comment:76

Replying to @JohnCremona:

Before I set about applying everything and testing, which I will do, can you tell me which Sage version I should be patching against? I have 4.7.1.rc1, is that the best? Or plain 4.7?

sage-4.7.1.rc1 for sure.

I am also preparing a Sage tarball with all spkgs and patches already applied, it should appear in http://boxen.math.washington.edu/home/jdemeyer/release/sage-4.7.1.rc1-pari-2.5.0/

jdemeyer commented 13 years ago

Changed reviewer from John Cremona to John Cremona, Jeroen Demeyer

JohnCremona commented 13 years ago

comment:77

Replying to @jdemeyer:

Replying to @JohnCremona:

Before I set about applying everything and testing, which I will do, can you tell me which Sage version I should be patching against? I have 4.7.1.rc1, is that the best? Or plain 4.7?

sage-4.7.1.rc1 for sure.

OK, I am testing against that right now... John

I am also preparing a Sage tarball with all spkgs and patches already applied, it should appear in http://boxen.math.washington.edu/home/jdemeyer/release/sage-4.7.1.rc1-pari-2.5.0/

JohnCremona commented 13 years ago

comment:78

Starting with a clean 4.7.1.rc1 (I think) I successfully applied both spkgs (using SAGE_CHECK=yes) and 5 patches to sagelib and 1 to data/extcode, and did sage -ba.

Sage now starts up OK but I'm having a lot of problems with any more testing. For example, moving into devel/sage and doing "../../sage -tp 20 ./sage" results in very many errors, looks like in every file, like this:

Traceback (most recent call last):
  File "/home/jec/.sage//tmp/facade_sets.py", line 2, in <module>
    from sage.all_cmdline import *; 
  File "/home/jec/sage-4.7.1.rc1/local/lib/python/site-packages/sage/all_cmdline.py", line 24, in <module>
    raise ValueError, msg
ValueError: Attempted relative import in non-package

I checked (using bash's history) that I had remembered to hg qpush each patch.

Does this make any sense? I suppose I could rebuild 4.7.1.rc1 from scratch.

kcrisman commented 13 years ago

comment:79

hen trying to install this on Cygwin, I get a lot of errors while trying to create the binary gp-2.5.exe along the lines of the following three types.

.../libpari.a(default.o): In function `sd_prompt':
.../default.c:962: multiple definition of `_sd_prompt'
gp.o:.../gp/gp.c:2359: first defined here

and

gp.o:gp.c:(.text+0x9e2): undefined reference to `_err_printf'

(lots of this kind of thing, for many functions), and

.../libpari.a(mp.o): In function `umodiu':
.../kernel/gmp/mp.c::567: undefined reference to `__imp____gmpn_mod_1'

The latter type I've already seen while trying to ./sage -f the previous Pari (2.4.3.alpha.px), but I haven't seen the first kind or second kind before. Something similar to the third one I've seen in some build notes of William's as being a problem with gmp being -I'ed before some other include directories, and the first one looks like one of these "double inclusion" problems.

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 13 years ago

comment:80

Replying to @kcrisman:

When trying to install this on Cygwin, I get a lot of errors while trying to create the binary gp-2.5.exe along the lines of the following three types.

.../libpari.a(default.o): In function `sd_prompt':
.../default.c:962: multiple definition of `_sd_prompt'
gp.o:.../gp/gp.c:2359: first defined here

Looks as if you're somehow^TM mixing the old PARI (at least the static library libpari.a) with the new one; PARI 2.5.0 doesn't have an sd_prompt() function in default.c at all.

and

gp.o:gp.c:(.text+0x9e2): undefined reference to `_err_printf'

... while this function doesn't exist in the older PARI.

(lots of this kind of thing, for many functions), and

.../libpari.a(mp.o): In function `umodiu':
.../kernel/gmp/mp.c::567: undefined reference to `__imp____gmpn_mod_1'

The latter type I've already seen while trying to ./sage -f the previous Pari (2.4.3.alpha.px), but I haven't seen the first kind or second kind before. Something similar to the third one I've seen in some build notes of William's as being a problem with gmp being -I'ed before some other include directories, and the first one looks like one of these "double inclusion" problems.

jdemeyer commented 13 years ago

comment:81

Replying to @JohnCremona:

ValueError: Attempted relative import in non-package

I have no idea why this happens. Can you try to build http://boxen.math.washington.edu/home/jdemeyer/release/sage-4.7.1.rc1-pari-2.5.0/sage-4.7.1.rc1-pari-2.5.0.tar from scratch and test that? If this works, probably you did something wrong in merging the spkgs/patches.

kcrisman commented 13 years ago

comment:82

Looks as if you're somehow^TM mixing the old PARI (at least the static library libpari.a) with the new one; PARI 2.5.0 doesn't have an sd_prompt() function in default.c at all.

Interestingly, it works fine from scratch (building)! Sorry for the noise, if noise it was.

Is there something about Pari that you shouldn't build it twice in the same location? I notice that it removes and replaces various things in $SAGE_LOCAL before it's all done, so maybe that could happen. In principle, one should be able to ./sage -f a new version, have something break, and then be able to ./sage -f the original version and have everything fine. Or not even HAVE to ./sage -f the original version. The fact that this doesn't work is not good - shouldn't we only copy things over/delete things after the build has successfully completed?

kiwifb commented 13 years ago

comment:83

Replying to @kcrisman:

Looks as if you're somehow^TM mixing the old PARI (at least the static library libpari.a) with the new one; PARI 2.5.0 doesn't have an sd_prompt() function in default.c at all.

Interestingly, it works fine from scratch (building)! Sorry for the noise, if noise it was.

Is there something about Pari that you shouldn't build it twice in the same location? I notice that it removes and replaces various things in $SAGE_LOCAL before it's all done, so maybe that could happen. In principle, one should be able to ./sage -f a new version, have something break, and then be able to ./sage -f the original version and have everything fine. Or not even HAVE to ./sage -f the original version. The fact that this doesn't work is not good - shouldn't we only copy things over/delete things after the build has successfully completed?

Well the gp executable is linked against libpari and there is a danger that the old one will be used when linking if you are not careful enough. It should be ok in principle but the precaution of removing previous libpari is a good one.

sagemath / sage

Update PARI to version 2.5.0 #11130

9343, #10430 (previous PARI upgrades)

10247 (Sage 4.6 has PARI problems on Cygwin)

10240 (pari-2.4.3.svn-12577.p9 incorrectly checks for the shared library on Cygwin), included in the 2.4.3.alpha.p7 spkg at #11605

11605 (Typos in PARI's spkg-install (2.4.3.alpha.p5)), included in the 2.4.3.alpha.p7 spkg at #11605