sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 480 forks source link

Mapping torus #11140

Closed 16f2fe85-2f43-42c8-9822-3fece4b041d2 closed 11 years ago

16f2fe85-2f43-42c8-9822-3fece4b041d2 commented 13 years ago

This is a patch to form the mapping torus of a simplicial complex given a vertex map.

Apply:

Component: algebraic topology

Keywords: simplicial

Author: Robert Goss, Frédéric Chapoton

Reviewer: John Palmieri

Merged: sage-5.10.beta1

Issue created by migration from https://trac.sagemath.org/ticket/11140

16f2fe85-2f43-42c8-9822-3fece4b041d2 commented 13 years ago

Attachment: trac_11140_mapping_torus.patch.gz

fchapoton commented 11 years ago
comment:1

Here is a patch rebased on 5.8, all tests pass.

for the patchbot:

apply trac_11140_mapping_torus-v2.patch

fchapoton commented 11 years ago

Description changed:

--- 
+++ 
@@ -1 +1,4 @@
 This is a patch to form the mapping torus of a simplicial complex given a vertex map.
+
+Apply:
+* [attachment: trac_11140_mapping_torus-v2.patch](https://github.com/sagemath/sage-prod/files/10652593/trac_11140_mapping_torus-v2.patch.gz)
fchapoton commented 11 years ago

Changed keywords from none to simplicial

fchapoton commented 11 years ago

Attachment: trac_11140_mapping_torus-v2.patch.gz

jhpalmieri commented 11 years ago
comment:2

I think this would be better as a method attached to a morphism (that is, in simplicial_complex_morphism.py): check that the domain and codomain are the same, and then return the mapping torus.

fchapoton commented 11 years ago

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
 This is a patch to form the mapping torus of a simplicial complex given a vertex map.

 Apply:
-* [attachment: trac_11140_mapping_torus-v2.patch](https://github.com/sagemath/sage-prod/files/10652593/trac_11140_mapping_torus-v2.patch.gz)
+* [attachment: trac_11140_mapping_torus-v3.patch](https://github.com/sagemath/sage-prod/files/10652594/trac_11140_mapping_torus-v3.patch.gz)
fchapoton commented 11 years ago
comment:3

Attachment: trac_11140_mapping_torus-v3.patch.gz

Here is new patch, where mapping_torus is a method of morphisms, as suggested.

jhpalmieri commented 11 years ago

Reviewer: John Palmieri

jhpalmieri commented 11 years ago
comment:4

Looks good.

jhpalmieri commented 11 years ago

Changed author from Robert Goss to Robert Goss, Frédéric Chapoton

fchapoton commented 11 years ago
comment:5

Thanks for the review !

jhpalmieri commented 11 years ago
comment:7

Replying to @fchapoton:

Thanks for the review !

Thanks for reviving this ticket.

jdemeyer commented 11 years ago

Merged: sage-5.10.beta1