rubiks: apply gcc 4.6.x workaround only for gcc 4.6.0 and 4.6.1

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.39k stars 473 forks source link

rubiks: apply gcc 4.6.x workaround only for gcc 4.6.0 and 4.6.1 #11437

Closed jdemeyer closed 13 years ago

jdemeyer commented 13 years ago

Since bug #11168 (rubiks fails doctest with gcc 4.6.0 and -O2 optimisation) is fixed upstream by the gcc developers, we should apply the workaround only for gcc versions 4.6.0 and 4.6.1 (the latter to allow for pre-release versions of gcc 4.6.1), exactly like we did for Cliquer (#11227).

spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/rubiks-20070912.p17.spkg

Component: packages: standard

Keywords: rubiks spkg gcc

Author: Jeroen Demeyer

Reviewer: Mariah Lenox

Merged: sage-4.7.1.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/11437

jdemeyer commented 13 years ago

Author: Jeroen Demeyer

jdemeyer commented 13 years ago

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
 Since bug #11168 (rubiks fails doctest with gcc 4.6.0 and -O2 optimisation) is fixed upstream by the gcc developers, we should apply the workaround only for gcc versions 4.6.0 and 4.6.1 (the latter to allow for pre-release versions of gcc 4.6.1), exactly like we did for Cliquer (#11227).
+
+**spkg:** http://boxen.math.washington.edu/home/jdemeyer/spkg/rubiks-20070912.p17.spkg

jdemeyer commented 13 years ago

Attachment: rubiks-20070912.p16-p17.diff.gz

Diff for the rubiks spkg, for reviewing only

a9bc4e33-7b98-4180-affc-8dfcef89e22b commented 13 years ago

Reviewer: Mariah Lenox

a9bc4e33-7b98-4180-affc-8dfcef89e22b commented 13 years ago

comment:2

Put the proposed spkg in source of sage-4.7.1.alpha1, built using gcc-4.6.0 with 'make testlong'. All tests passed. Positive review!

jdemeyer commented 13 years ago

Merged: sage-4.7.1.alpha3