search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.38k stars 469 forks source link

Fix more noise on MacOS X 10.4 PPC #11901

Closed 83660e46-0051-498b-a8c1-f7a7bd232b5a closed 13 years ago

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 13 years ago

This is a follow-up to #7852 (and #11897).

As reported on sage-release, some doctests in Sage 4.7.2.alpha3 still failed on a PowerPC running MacOS X 10.4 due to numerical noise (or slightly different behaviour, giving correct but varying results).

The patch here further increases the threshold for noisy zero terms of polynomials slightly.

Apply

  1. attachment: trac_11901-adjust_threshold_for_noisy_zero_terms_in_polynomial_element.patch to the Sage library.

CC: @kcrisman @rbeezer

Component: linear algebra

Keywords: noisy zero epsilon threshold polynomial term

Author: Leif Leonhardy

Reviewer: Karl-Dieter Crisman, Rob Beezer

Merged: sage-4.7.2.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/11901

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 13 years ago

Sage library patch. Based on Sage 4.7.2.alpha3 / #7852.

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 13 years ago
comment:1

Attachment: trac_11901-adjust_threshold_for_noisy_zero_terms_in_polynomial_element.patch.gz

A single-character patch to be tested (by "student") and reviewed...

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 13 years ago

Author: Leif Leonhardy

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 13 years ago

Description changed:

--- 
+++ 
@@ -4,3 +4,9 @@

 The patch here further increases the threshold for noisy zero terms of polynomials slightly.

+---
+
+Apply
+1. [attachment: trac_11901-adjust_threshold_for_noisy_zero_terms_in_polynomial_element.patch](https://github.com/sagemath/sage-prod/files/10653840/trac_11901-adjust_threshold_for_noisy_zero_terms_in_polynomial_element.patch.gz)
+to the Sage library.
+
1d7ec08f-60ae-4512-91a6-8324c06eab9f commented 13 years ago
comment:2

This looks good to me, but I think we need to see if it does the job on Mac PowerPC?

kcrisman commented 13 years ago
comment:3

I know this is sort of silly, but it is nice to have all tests pass :)

Works fine.

sage -t -long "devel/sage/sage/rings/polynomial/polynomial_element.pyx"
         [156.8 s]

----------------------------------------------------------------------
All tests passed!
Total time for all tests: 157.4 seconds
kcrisman commented 13 years ago

Reviewer: Karl-Dieter Crisman, Rob Beezer

jdemeyer commented 13 years ago

Merged: sage-4.7.2.alpha4

jdemeyer commented 13 years ago
comment:4

Thanks!

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 13 years ago
comment:5

Replying to @jdemeyer:

Thanks!

So Moufang is still alive?

jdemeyer commented 13 years ago
comment:6

Replying to @nexttime:

So Moufang is still alive?

Of course. Did I ever say it wasn't? I don't actually use this machine, only to test Sage.