sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 480 forks source link

Interface to GINV #12344

Closed malb closed 12 years ago

malb commented 12 years ago

We do have an optional GINV SPKG which comes with its own Python interface but no interface to it from Sage.

With the attached patch, this now works.

sage: P.<x,y,z> = PolynomialRing(GF(127),order='degrevlex')
sage: I = sage.rings.ideal.Katsura(P)
sage: I.groebner_basis(algorithm='ginv')            ...
[z^3 + 22*z^2 - 55*y + 49*z, y^2 - 26*z^2 - 51*y + 51*z, y*z + 52*z^2 + 38*y + 25*z, x + 2*y + 2*z - 1]

Please use the last patch, the 1st one has non-ASCII chars in it.

CC: @williamstein

Component: packages: optional

Keywords: ginv

Author: Martin Albrecht

Reviewer: Dmitrii Pasechnik

Merged: sage-5.0.beta4

Issue created by migration from https://trac.sagemath.org/ticket/12344

malb commented 12 years ago

Description changed:

--- 
+++ 
@@ -1 +1,10 @@
 We do have an optional GINV SPKG which comes with its own Python interface but no interface to it from Sage.
+
+With the attached patch, this now works.
+
+```
+sage: P.<x,y,z> = PolynomialRing(GF(127),order='degrevlex')
+sage: I = sage.rings.ideal.Katsura(P)
+sage: I.groebner_basis(algorithm='ginv')            ...
+[z^3 + 22*z^2 - 55*y + 49*z, y^2 - 26*z^2 - 51*y + 51*z, y*z + 52*z^2 + 38*y + 25*z, x + 2*y + 2*z - 1]
+```
dimpase commented 12 years ago
comment:2

there are non-ASCII chars in the diff: "Criterion C1 is Buchberger�s"

malb commented 12 years ago

Attachment: trac12344_ginv.patch.gz

malb commented 12 years ago
comment:3

fixed

dimpase commented 12 years ago
comment:4

Replying to @malb:

fixed


$ iconv -f ascii -t ascii <trac12344_ginv.patch >/dev/null

iconv: (stdin):48:29: cannot convert

There is a weird back quote there... Must be French :-)

dimpase commented 12 years ago

Attachment: trac12344_ginv_ascii.patch.gz

cleaned up patch

dimpase commented 12 years ago

Description changed:

--- 
+++ 
@@ -8,3 +8,6 @@
 sage: I.groebner_basis(algorithm='ginv')            ...
 [z^3 + 22*z^2 - 55*y + 49*z, y^2 - 26*z^2 - 51*y + 51*z, y*z + 52*z^2 + 38*y + 25*z, x + 2*y + 2*z - 1]

+ +Please use the last patch, the 1st one has non-ASCII chars in it. +

dimpase commented 12 years ago
comment:5

Tested on Sage 5.0 beta2, Linux x86_64 Debian. It works.

malb commented 12 years ago
comment:6

Thanks, the patch looks good. :)

jdemeyer commented 12 years ago

Reviewer: Dmitrii Pasechnik

jdemeyer commented 12 years ago

Merged: sage-5.0.beta4