search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.39k stars 473 forks source link

Update GLPK to 4.55 #12703

Closed 83660e46-0051-498b-a8c1-f7a7bd232b5a closed 9 years ago

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 12 years ago

Old versions (at least till 4.47) fail to build when link-time optimization (LTO, gcc -flto ...) is enabled.

While configure shows an error message, it continues normally and doesn't exit with an error. Only later during the build, a shell syntax error caused by libtool makes the build finally fail.

New versions have been re-autotoolized with more recent autotools.

New versions also unconditionally use their own zlib, this is circumvented by patching in the spirit of what Red Hat does.

Finally we let GLPK build shared lib on Cygwin.

Upstream tarball:

Upstream: Reported upstream. Developers acknowledge bug.

CC: @nathanncohen @simon-king-jena @tscrim

Component: packages: standard

Keywords: link time optimization nm glpsol spkg upgrade update

Author: Leif Leonhardy, Jean-Pierre Flori

Branch: 827eaa3

Reviewer: Nathann Cohen, Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/12703

vbraun commented 9 years ago
comment:91

Apart from that one the buildbot didn't find any other failures.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 9ecce27 to 827eaa3

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

827eaa3Further numerical noise after GLPK updated.
vbraun commented 9 years ago

Changed branch from u/jpflori/ticket/12703 to 827eaa3

jdemeyer commented 8 years ago

Replying to @nexttime:

New versions also unconditionally use their own zlib

Is this really a problem? I'm asking because this is a non-trivial patch which no longer applies against a newer GLPK (version 4.57, just released). If we don't strictly need it, I would rather remove that patch.

jdemeyer commented 8 years ago

Changed commit from 827eaa3 to none

kiwifb commented 8 years ago
comment:96

Replying to @jdemeyer:

Replying to @nexttime:

New versions also unconditionally use their own zlib

Is this really a problem? I'm asking because this is a non-trivial patch which no longer applies against a newer GLPK (version 4.57, just released). If we don't strictly need it, I would rather remove that patch.

It is most unfortunate. In the context of sage I guess I would just remove the patch. The only way to eliminate it, is to work with upstream to make it configurable. Most distro will unbundle it in any case.

jdemeyer commented 8 years ago
comment:97

I just don't feel motivated to maintained a patch which isn't actually needed.