search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.26k stars 434 forks source link

Make PyQt an optional spkg #13022

Open vbraun opened 12 years ago

vbraun commented 12 years ago

If you want to use the new IPython QT console you need PyQt (and its dependency sip). This ticket adds the relevant spkgs. Together with zeromq/pyzmq (#12843), I can now run the IPython qtconsole. You need to have qt development libraries already installed in your base system, this only makes Qt available from Sage.

CC: @jasongrout @mwhansen

Component: packages: optional

Keywords: sd40.5

Author: Volker Braun

Reviewer: Mike Hansen

Issue created by migration from https://trac.sagemath.org/ticket/13022

mwhansen commented 12 years ago

Reviewer: Mike Hansen

mwhansen commented 12 years ago
comment:3

Looks good to me.

williamstein commented 12 years ago
comment:4

Perhaps spkg-install could point out that this doesn't work on OS X:

Extracting package /Users/wstein/sage/build/sage-5.0/spkg/optional/sip-4.13.2.p0.spkg
-rw-r--r--  1 wstein  staff  576767 May 27 18:50 /Users/wstein/sage/build/sage-5.0/spkg/optional/sip-4.13.2.p0.spkg
Finished extraction
****************************************************
Host system:
Darwin blastoff.westell.com 11.4.0 Darwin Kernel Version 11.4.0: Mon Apr  9 19:32:15 PDT 2012; root:xnu-1699.26.8~1/RELEASE_X86_64 x86_64
****************************************************
C compiler: gcc
C compiler version:
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/Users/wstein/sage/build/sage-5.0/local/libexec/gcc/x86_64-apple-darwin11.4.0/4.6.3/lto-wrapper
Target: x86_64-apple-darwin11.4.0
Configured with: ../src/configure --prefix=/Users/wstein/sage/build/sage-5.0/local --with-local-prefix=/Users/wstein/sage/build/sage-5.0/local --with-gmp=/Users/wstein/sage/build/sage-5.0/local --with-mpfr=/Users/wstein/sage/build/sage-5.0/local --with-mpc=/Users/wstein/sage/build/sage-5.0/local --with-system-zlib --disable-multilib  
Thread model: posix
gcc version 4.6.3 (GCC) 
****************************************************
WARNING: spkg-install is not executable, making it executable
Error: SIP requires Python to be built as a framework
This is SIP 4.13.2 for Python 2.7.2 on darwin.
The SIP code generator will be installed in
/Users/wstein/sage/build/sage-5.0/local/bin.
The sip module will be installed in
/Users/wstein/sage/build/sage-5.0/local/lib/python2.7/site-packages.
The sip.h header file will be installed in
/Users/wstein/sage/build/sage-5.0/local/include/python2.7.
The default directory to install .sip files in is
/Users/wstein/sage/build/sage-5.0/local/share/sip.
The platform/compiler configuration is macx-g++.
Creating siplib/sip.h...
Creating siplib/siplib.c...
Creating siplib/siplib.sbf...
Creating sipconfig.py...
Creating top level Makefile...
Creating sip code generator Makefile...
Creating sip module Makefile...
Error configuring sip.

real    0m0.152s
user    0m0.100s
sys 0m0.043s
************************************************************************
Error installing package sip-4.13.2.p0
************************************************************************
jasongrout commented 12 years ago
comment:5

Perhaps we can make a pySide package as well or instead? I believe pyside doesn't use sip, and is developed directly by nokia.

vbraun commented 12 years ago
comment:6

Followups for problems building on OSX at #13047

williamstein commented 12 years ago
comment:7

There is a sip package at #13047 that actually builds. W00t. But then the PyQT package at http://www.stp.dias.ie/~vbraun/Sage/spkg/PyQt_x11-4.9.1.p0.spkg still fails instantly:

gcc version 4.6.3 (GCC) 
****************************************************
Cannot find qmake (the Qt make tool)

If you have a private installation somewhere, put a symlink to
qmake into /Users/wstein/sage/build/sage-5.0/local/bin and rerun the PyQt installation.

real    0m0.012s
user    0m0.004s
sys 0m0.006s
williamstein commented 12 years ago
comment:8

Replying to @williamstein:

There is a sip package at #13047 that actually builds. W00t. But then the PyQT package at http://www.stp.dias.ie/~vbraun/Sage/spkg/PyQt_x11-4.9.1.p0.spkg still fails instantly:

... because I didn't have Qt itself (an 800MB download!) installed. Now, with Qt installed... it still fails since I don't know how to tell PyQt where Qt is. But I'll work on that.

williamstein commented 12 years ago
comment:9

OK, I strongly object to this getting a positive review without the spkg-install starting with a test if you are using OS X, and if so, gives a huge warning about there being no chance it is going to work (and that it has never, ever been tested on OS X).

b03034c9-f2cf-4d37-9a1e-419dd712df02 commented 12 years ago
comment:11

The PyQt spkg installs fine for me on OSX 10.6.8 with the sip package from #13047

vbraun commented 12 years ago
comment:12

Thats a positive review, then?

b03034c9-f2cf-4d37-9a1e-419dd712df02 commented 12 years ago
comment:13

From my side, it is a positive review, but perhaps somebody should test in OSX 10.7 where William found some trouble. Also, is there an easy way of adding test suites to both packages?

vbraun commented 12 years ago
comment:14

To the best of my knowledge they don't come with a testsuite.

mkoeppe commented 4 years ago
comment:19

Setting spkg proposals that have not seen recent activity to "sage-wishlist".