search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.37k stars 465 forks source link

Upgrade Maxima to 5.29.1 #13364

Closed kcrisman closed 11 years ago

kcrisman commented 12 years ago 
Message: 5
Date: Sun, 12 Aug 2012 23:18:05 +0000 (UTC)
From: Robert Dodier <robert.dodier@gmail.com>
To: maxima@math.utexas.edu
Subject: [Maxima] Maxima 5.28.0 release
Message-ID: <k09djd$dvj$2@dough.gmane.org>

Hi, I've created branch-5_28 in Git and tagged branch-5_28-base and
5.28.0. I've created tar.gz, srpm, and rpm's and uploaded them to the
SourceForge file manager. (http://sourceforge.net/projects/maxima/files)

The new spkg is for ECL 11 as well as for ECL 12, i.e. ASDF-agnostic, along the lines of maxima 5.26.0 at #13860. Moreover it has an upstream patch preventing segfaults. This fixes few tickets.

Install http://boxen.math.washington.edu/home/jdemeyer/spkg/maxima-5.29.1.p1.spkg

Apply

Upstream: Reported upstream. Developers acknowledge bug.

CC: @jpflori @dimpase @nbruin @zimmermann6

Component: packages: standard

Keywords: maxima spkg

Author: Jean-Pierre Flori, Dmitrii Pasechnik

Reviewer: Karl-Dieter Crisman, François Bissey, Leif Leonhardy, Paul Zimmermann

Merged: sage-5.7.beta0

Issue created by migration from https://trac.sagemath.org/ticket/13364

dimpase commented 11 years ago
comment:93

After some more git bisect, finally, it is here: https://sourceforge.net/p/maxima/code/ci/f5e9b0f7eb122c4e48ea9df144dd57221e5ea0ca

to blame for ?integer?

It was meant to fix this, but Sage has it fixed already. I will post a patched spkg with this patch undone.

dimpase commented 11 years ago
comment:94

the update tested on Sage 5.5, and passes all the longtests (provided the doctests.patch is installed, of course). Needs review!

dimpase commented 11 years ago

Description changed:

--- 
+++ 
@@ -12,14 +12,13 @@
 SourceForge file manager. (http://sourceforge.net/projects/maxima/files)

-This should fix at least a few tickets. The following spkg is for ECL 12.12 (new ASDF)

+New spkg:

-New spkg: http://boxen.math.washington.edu/home/jpflori/maxima-5.29.1.p0.spkg +The updated spkg, based on a version here, is for ECL 11 as well as for ECL 12, i.e. ASDF-agnostic, along the lines of maxima 5.26.0 at #13860. Moreover it has +an upstream patch preventing segfaults. This fixes few tickets.

-The following spkg is for ECL 11 as well as for ECL 12, i.e. ASDF-agnostic, along the lines of maxima 5.26.0 at #13860. Moreover it has -an upstream patch preventing segfaults: http://boxen.math.washington.edu/home/dima/packages/maxima-5.29.1.p1.spkg +Install http://boxen.math.washington.edu/home/dima/packages/maxima-5.29.1.p1.spkg and

-apply +Apply

dimpase commented 11 years ago

Changed author from Jean-Pierre Flori to Jean-Pierre Flori, Dmitrii Pasechnik

kcrisman commented 11 years ago
comment:95

I like this! Only issue is that now #13860 has been merged in the meantime, so possibly this should be based on that? Clearly some of the changes are identical (like the image removal, asdf compatibility), since Dima made both of them! Unsure also on how JP's changes should be handled... But I'm very reluctant to put "needs work" for such things either.

kcrisman commented 11 years ago

Changed work issues from fix doctests to none

kcrisman commented 11 years ago
comment:96

This does work! Nicely done. "Needs info" for the whole spkg rebasing issue.

dimpase commented 11 years ago
comment:97

Replying to @kcrisman:

I like this! Only issue is that now #13860 has been merged in the meantime, so possibly this should be based on that? Clearly some of the changes are identical (like the image removal, asdf compatibility), since Dima made both of them! Unsure also on how JP's changes should be handled... But I'm very reluctant to put "needs work" for such things either.

13860 and this ticket are independent of each other. Indeed there is small parallelism in changes, but that's all.

kcrisman commented 11 years ago
comment:98

13860 and this ticket are independent of each other. Indeed there is small parallelism in changes, but that's all.

I just meant in terms of the HG repository for this spkg, which would seem to indicate that one should base the p0 and p1 here on the p1 there.

dimpase commented 11 years ago
comment:99

Replying to @kcrisman:

13860 and this ticket are independent of each other. Indeed there is small parallelism in changes, but that's all.

I just meant in terms of the HG repository for this spkg, which would seem to indicate that one should base the p0 and p1 here on the p1 there.

I don't understand. Indeed, 5.26.0.p1 and 5.29.1.p1 are separate branches. So what?

kiwifb commented 11 years ago
comment:100

Well I and other have chastised before for not staying on a single branch for a spkg. I would assume you will be told off too. Unless we just skip one of them.

dimpase commented 11 years ago
comment:101

Replying to @kiwifb:

Well I and other have chastised before for not staying on a single branch for a spkg. I would assume you will be told off too. Unless we just skip one of them.

I think this is pure bullshit in this case, about single branch. Let's deal with bullshit when/if it comes to it. If we are quick enough 5.26.0.p1 won't even get merged in any (stable) release.

kcrisman commented 11 years ago
comment:102

Well I and other have chastised before for not staying on a single branch for a spkg. I would assume you will be told off too. Unless we just skip one of them.

been chastised - just for those reading

I think this is pure bullshit in this case, about single branch. Let's deal with bullshit when/if it comes to it. If we are quick enough 5.26.0.p1 won't even get merged in any (stable) release.

Fair enough, in which case I'll remove that dependency, which leif introduced. Anyway, I can't review some of the more technical changes in JP's package, but the Sage side seems okay.

kcrisman commented 11 years ago

Changed dependencies from #13860 to none

kcrisman commented 11 years ago
comment:103

I think this is pure bullshit in this case, about single branch. Let's deal with bullshit when/if it comes to it. If we are quick enough 5.26.0.p1 won't even get merged in any (stable) release.

Fair enough, in which case I'll remove that dependency, which leif introduced. Anyway, I can't review some of the more technical changes in JP's package, but the Sage side seems okay.

Actually, he had fewer changes than I thought. The change in Dima's package to deal with various names for the library was already positively reviewed at #13860. So... lookin' good. Shall we say positive review? It's certainly been tested quite a bit.

zimmermann6 commented 11 years ago
comment:105

a minor point: for the test in functional.py that (now) takes a long time, without the -long option, the variable t is not defined, and the test on t.simplify_exp() fails with:

NameError: name 't' is not defined

Probably the t.simplify_exp() line should be commented with # long time too.

Otherwise all doctests pass on top of Sage 5.5, thus I would give a positive review, but since this ticket is quite long, I'm not sure...

Paul

kcrisman commented 11 years ago

Use this patch

kcrisman commented 11 years ago

Description changed:

--- 
+++ 
@@ -21,4 +21,4 @@
 Install [http://boxen.math.washington.edu/home/dima/packages/maxima-5.29.1.p1.spkg](http://boxen.math.washington.edu/home/dima/packages/maxima-5.29.1.p1.spkg) and

 Apply 
-* [attachment: doctests.patch](https://github.com/sagemath/sage/files/ticket13364/doctests.patch.gz)
+* [attachment: doctests.2.patch](https://github.com/sagemath/sage-prod/files/10656171/doctests.2.patch.gz)
kcrisman commented 11 years ago
comment:106

Attachment: doctests.2.patch.gz

Probably the t.simplify_exp() line should be commented with # long time too.

Great point, I've updated the patch.

Otherwise all doctests pass on top of Sage 5.5, thus I would give a positive review, but since this ticket is quite long, I'm not sure...

Let's do it and see what happens. At some point we have to try it, and it looks like it's been tested on Mac and several Linuces.

kcrisman commented 11 years ago

Changed reviewer from Karl-Dieter Crisman, François Bissey, Leif Leonhardy to Karl-Dieter Crisman, François Bissey, Leif Leonhardy, Paul Zimmermann

kiwifb commented 11 years ago
comment:107

Well it works but I am not sure we should patch exp_integral.py this way. The old result was to demonstrate that something was broken. We should change the comment to reflect that is fixed or find another broken example. By comment I mean this bit:

    Note that due to some problems with the way Maxima handles these
    expressions, definite integrals can sometimes give unexpected
    results (typically when using inexact endpoints) due to
    inconsistent branching::

That may be a bit pedantic however.

jdemeyer commented 11 years ago

Dependencies: #13324

kcrisman commented 11 years ago
comment:109

Replying to @kiwifb:

Well it works but I am not sure we should patch exp_integral.py this way. The old result was to demonstrate that something was broken. We should change the comment to reflect that is fixed or find another broken example. By comment I mean this bit:

    Note that due to some problems with the way Maxima handles these
    expressions, definite integrals can sometimes give unexpected
    results (typically when using inexact endpoints) due to
    inconsistent branching::

That may be a bit pedantic however.

No, that's a good point actually. Thanks for volunteering to ask the Maxima list for such an example :-)

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 11 years ago
comment:110

Replying to @jdemeyer:

This ticket doesn't depend on #13324, as now both Maxima versions (5.26.0.p1 from #13860, and the 5.29.1.p1 from here) can cope with the new as well as the old ASDF naming scheme.

But the dependency is probably some artificial one for the release process, some I'm leaving it as is...

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 11 years ago
comment:111

Replying to @nexttime:

Replying to @jdemeyer:

This ticket doesn't depend on #13324, as now both Maxima versions (5.26.0.p1 from #13860, and the 5.29.1.p1 from here) can cope with the new as well as the old ASDF naming scheme.

P.S.: ... as stated in the ticket's description btw. :-)

jdemeyer commented 11 years ago

Changed dependencies from #13324 to none

jdemeyer commented 11 years ago
comment:112

Replying to @nexttime:

Replying to @jdemeyer:

This ticket doesn't depend on #13324, as now both Maxima versions (5.26.0.p1 from #13860, and the 5.29.1.p1 from here) can cope with the new as well as the old ASDF naming scheme.

Then I was confused by a comment on #13324.

kiwifb commented 11 years ago
comment:113

Replying to @kcrisman:

Replying to @kiwifb:

Well it works but I am not sure we should patch exp_integral.py this way. The old result was to demonstrate that something was broken. We should change the comment to reflect that is fixed or find another broken example. By comment I mean this bit:

    Note that due to some problems with the way Maxima handles these
    expressions, definite integrals can sometimes give unexpected
    results (typically when using inexact endpoints) due to
    inconsistent branching::

That may be a bit pedantic however.

No, that's a good point actually. Thanks for volunteering to ask the Maxima list for such an example :-)

You are welcome, I guess :P

jdemeyer commented 11 years ago
comment:114

This spkg should be rebased to maxima-5.26.0.p1, it is currently based on maxima-5.26.0.p0.

dimpase commented 11 years ago
comment:115

Replying to @jdemeyer:

This spkg should be rebased to maxima-5.26.0.p1, it is currently based on maxima-5.26.0.p0.

as far as I am concerned, maxima-5.26.0.p1 may just as well die. It would cost me half an hour of fooling around with hg, with 0 benefit for anything.

jdemeyer commented 11 years ago
comment:116

Replying to @dimpase:

0 benefit for anything.

So all the changes in #13860 were completely pointless then?

dimpase commented 11 years ago
comment:117

Replying to @jdemeyer:

Replying to @dimpase:

0 benefit for anything.

So all the changes in #13860 were completely pointless then?

When I worked on #13860 it was not clear that the current ticket can be done so fast.

The changes on #13860 are all basically repeated, in a slightly different way, on this ticket. Due to our scheme of working on packages it wasn't trivial to properly merge the changes, so I just copy/pasted from source.

jdemeyer commented 11 years ago
comment:118

OK, I rebased. diff attached.

I also renamed spkg-dist to spkg-src since the former name should be reserved for scripts which create a spkg.

jdemeyer commented 11 years ago

Description changed:

--- 
+++ 
@@ -13,12 +13,10 @@

-New spkg:

-The updated spkg, based on a version here, is for ECL 11 as well as for ECL 12, i.e. ASDF-agnostic, along the lines of maxima 5.26.0 at #13860. Moreover it has +The new spkg is for ECL 11 as well as for ECL 12, i.e. ASDF-agnostic, along the lines of maxima 5.26.0 at #13860. Moreover it has an upstream patch preventing segfaults. This fixes few tickets.

-Install http://boxen.math.washington.edu/home/dima/packages/maxima-5.29.1.p1.spkg and +Install http://boxen.math.washington.edu/home/jdemeyer/spkg/maxima-5.29.1.p1.spkg

Apply

jdemeyer commented 11 years ago

spkg diff, for review only

jpflori commented 11 years ago
comment:120

Attachment: maxima-5.29.1.p1.diff.gz

dimpase commented 11 years ago
comment:121

Replying to @jdemeyer:

OK, I rebased. diff attached.

I also renamed spkg-dist to spkg-src since the former name should be reserved for scripts which create a spkg.

dank u wel!

kcrisman commented 11 years ago
comment:122

I also renamed spkg-dist to spkg-src since the former name should be reserved for scripts which create a spkg.

dank u wel!

Agreed!

dimpase commented 11 years ago
comment:123

I've opened #13973 to deal with including the latest upstream patches.

kcrisman commented 11 years ago
comment:124

Here are some tickets the current ticket should fix (i.e., they just need a patch to doctest it). Not that I've tried them, just that in theory they are in 5.29.1. Unfortunately, so far I only found these two...

jdemeyer commented 11 years ago

Merged: sage-5.7.beta0

kcrisman commented 2 years ago
comment:126

Note that this commit in Maxima apparently fixes one of the problems in question.