search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.49k stars 491 forks source link

eval_line in giac interface #13429

Closed frederichan-IMJPRG closed 11 years ago

frederichan-IMJPRG commented 12 years ago

eval_line in the giac interface might miss the argument restart_if_needed.

The error can be seen when converting with big matrices to giac.

So I add also a doc test to see it.

NB: The other interfaces like gp,gap,axiom,maple,mathematica got the corresponding change between 4.8 and 5.0

Component: interfaces

Keywords: giac, interface

Author: Frederic Han

Reviewer: Volker Braun

Merged: sage-5.13.beta3

Issue created by migration from https://trac.sagemath.org/ticket/13429

2edf2d52-6c17-4f2a-88a6-e860db4dcddf commented 12 years ago
comment:1

Attachment: giaceval_line.patch.gz

The small change indeed fixes the conversion error.

vbraun commented 11 years ago

Reviewer: Volker Braun

vbraun commented 11 years ago
comment:4

lgtm

frederichan-IMJPRG commented 11 years ago
comment:5

thanks

jdemeyer commented 11 years ago

Merged: sage-5.13.beta3

fchapoton commented 7 years ago

Changed author from Han Frederic to Frederic Han

fchapoton commented 7 years ago
comment:7

correct name