search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 480 forks source link

Barnette Sphere #13888

Closed fchapoton closed 11 years ago

fchapoton commented 11 years ago

The Barnette Sphere is a triangulation of the 3-sphere. This patch provides this as a simplicial complex

apply trac-13888-barnette-sphere-fc.patch

Depends on #13943

Component: combinatorics

Keywords: simplicial sphere

Author: Frédéric Chapoton

Reviewer: Nathann Cohen

Merged: sage-5.7.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13888

fchapoton commented 11 years ago

Changed keywords from simplicial to simplicial sphere

fchapoton commented 11 years ago

Author: Frédéric Chapoton

tscrim commented 11 years ago
comment:2

Hey Frederic,

Just to let you know, right now we are having a discussion over implementation of examples of simplicial complexes in #13566 that might have an impact on this patch.

Best,

Travis

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 11 years ago
comment:3

Hellooooooooooooo !!

Well, I was just able to check the definition of Barnette sphere as given in the third of your references, and those coordinates are not the ones you use... So I added a new doctest that cheks that your definition is equivalent to this one. This is a simplicial complex isomorphism test, so if you end up implemnting it somewhere you can 1) use this code 2) update the doctest.

As everything else is fine, you can set this ticket to positive_review if you agree with those changes.

Have fuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuunnn !!

Nathann

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 11 years ago
comment:4

(oops ^^;)

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 11 years ago

Dependencies: #13943

fchapoton commented 11 years ago
comment:7

Attachment: trac-13888-barnette-sphere-fc.patch.gz

apply trac-13888-barnette-sphere-fc.patch

fchapoton commented 11 years ago

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
 The Barnette Sphere is a triangulation of the 3-sphere. This patch provides this as a simplicial complex
+
+apply trac-13888-barnette-sphere-fc.patch
6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 11 years ago
comment:8

Muuuuuuuuuuuuch better than previously, thanks to is_isomorphic. And it passes all long (and veeeeery long doctests). Good to go !

Nathann

jdemeyer commented 11 years ago

Reviewer: Nathann Cohen

jdemeyer commented 11 years ago

Merged: sage-5.7.beta2