search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.33k stars 453 forks source link

quaternionic projective plane #13944

Closed fchapoton closed 11 years ago

fchapoton commented 11 years ago

There exists a conjectural triangulation of the projective plane over the ring of quaternions, with 15 vertices and 490 facets. This patch implements that as a simplicial complex.

Apply only attachment: trac-13944-quaternion-plane-fc.patch.

Depends on #13943 Depends on #13888 Depends on #13923

Component: algebraic topology

Keywords: simplicial complex

Author: Frédéric Chapoton

Reviewer: Nathann Cohen

Merged: sage-5.7.beta3

Issue created by migration from https://trac.sagemath.org/ticket/13944

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 11 years ago
comment:2

Hellooooooooo !! Well, this one's good to go, short of an example that can now be written thanks to #13943. Oh, and I also reformatted the list of simplices a bit, so that it matches its description in the paper. Only superfical stuff :-)

If you agree with this reviewer's patch, then you can set the ticket to positive_review.

Have fuuuuuuuuuuuuuuuun !

Nathann

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 11 years ago

Reviewer: Frédéric Chapoton, Nathann Cohen

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 11 years ago

Dependencies: #13943

fchapoton commented 11 years ago

Changed reviewer from Frédéric Chapoton, Nathann Cohen to Nathann Cohen

jhpalmieri commented 11 years ago
comment:6

I'm a little nervous about this method being called QuaternionicProjectivePlane when it is not known whether the space is actually the quaternionic projective plane: people might be misled. Can you think of another name for it?

fchapoton commented 11 years ago
comment:7

Well, there is a big warning in the doc. Do you really think any user will use that without reading the doc ? I would prefer to keep the current name. Otherwise, maybe

Would you have any better suggestions ?

jhpalmieri commented 11 years ago
comment:8

PseudoQuaternionicProjectivePlane? QuaternionicProjectivePlane_conjectured? I can certainly imagine someone finding the method using tab-completion and not reading the docstring for it, especially if they have in the past looked at documentation for RealProjectivePlane and ComplexProjectivePlane.

fchapoton commented 11 years ago

folded patch, apply only this one

fchapoton commented 11 years ago
comment:9

Attachment: trac-13944-quaternion-plane-fc.patch.gz

I have renamed the function to PseudoQuaternionicProjectivePlane

and folded the review patch

apply only trac-13944-quaternion-plane-fc.patch

fchapoton commented 11 years ago

Changed dependencies from #13943 to #13923

jhpalmieri commented 11 years ago

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
 There exists a conjectural triangulation of the projective plane over the ring of quaternions, with 15 vertices and 490 facets. This patch implements that as a simplicial complex.
+
+Apply only [attachment: trac-13944-quaternion-plane-fc.patch](https://github.com/sagemath/sage-prod/files/10656922/trac-13944-quaternion-plane-fc.patch.gz).
jhpalmieri commented 11 years ago
comment:10

The name is fine with me. This already had a positive review, so I'll restore that.

jdemeyer commented 11 years ago

Changed dependencies from #13923 to #13943, #13888, #13923

jdemeyer commented 11 years ago

Merged: sage-5.7.beta3