search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.32k stars 453 forks source link

More IPython 0.13 fixes #14024

Closed vbraun closed 11 years ago

vbraun commented 11 years ago

Apply trac_14024_branches.patch

Component: packages: standard

Author: Volker Braun

Reviewer: Keshav Kini

Merged: sage-5.7.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14024

jdemeyer commented 11 years ago
comment:2

Another problem happens with upgrading. On rosemary (RHEL 5.6 x86_64), the scripts in local/bin aren't properly installed. In particular local/bin/ipython isn't copied and the pre-upgrade local/bin/ipython doesn't work. Full log: http://build.sagemath.org/sage/builders/UGA%20rosemary%20%28RHEL%205.6%20x86_64%29%20up%26nbsp%3B4.5.2/builds/53/steps/shell_7/logs/ipython

But note this part:

running install_scripts
copying build/scripts-2.7/iplogger -> /home/buildbot/build/sage/rosemary-1/rosemary_upgrade_4.5.2/build/sage-5.7.beta1/local/bin

which normally looks like

running install_scripts
copying build/scripts-2.7/ipengine -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/ipcontroller -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/ipcluster -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/iplogger -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/ipython -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/pycolor -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/irunner -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/iptest -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin

EDIT: I initially though this was because of #14026 but thinking further, it was probably #14027.

vbraun commented 11 years ago

Attachment: trac_14024_branches.patch.gz

Initial patch

vbraun commented 11 years ago
comment:3

The "you are on branch X" message was implementing a third bannering system besides sage-banner and IPython banner, and I removed all of it. We can think about putting it back in after we switch to git.

Apply trac_14024_branches.patch

vbraun commented 11 years ago

Author: Volker Braun

vbraun commented 11 years ago

Description changed:

--- 
+++ 
@@ -1 +1,4 @@

+
+Apply trac_14024_branches.patch
+
kini commented 11 years ago

Reviewer: Keshav Kini

kini commented 11 years ago
comment:6

Ideally Sage itself should function even if all version control data is stripped from the installation. After we switch to git this might actually become feasible. "You are on branch X" is a nice thing to have, but it should fail gracefully. I like this patch though because the "branches" referred to by this message are not even used by anyone except the patchbot anymore.

Just testing that the patchbot succeeds in testing sage-0 on arando before I give this positive review.

kini commented 11 years ago
comment:7

Works fine.

jdemeyer commented 11 years ago

Merged: sage-5.7.beta2