sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.3k stars 447 forks source link

Nonsymmetric Macdonald Polynomials for all affine types #14102

Closed 6bbcde06-8197-41f1-b9a3-c998bb839000 closed 10 years ago

6bbcde06-8197-41f1-b9a3-c998bb839000 commented 11 years ago

This ticket implements nonsymmetric Macdonald polynomials for arbitrary affine Cartan type (including twisted and BC, but not Koornwinder) using the recursion formula in terms of Demazure-Lusztig and Cherednik operators. It complements the type-A implementation based on the HHL combinatorial formula of #2708.

This patch was written by Anne Schilling and Nicolas M. Thiéry during the ICERM Semester Program on "Automorphic Forms, Combinatorial Representation Theory and Multiple Dirichlet Series" (January 28, 2013 - May 3, 2013) with the help of Dan Bump, Ben Brubaker, Bogdan Ion, Dan Orr, Arun Ram, Siddhartha Sahi, and Mark Shimozono. Special thanks go to Bogdan Ion and Mark Shimozono for their patient explanations and hand computations to check the code.

In a follow-up ticket #14847 Whittaker functions and other features will become available.

Depends on #4327 Depends on #14143 Depends on #13589 Depends on #10963 Depends on #14673 Depends on #14610 Depends on #14775 Depends on #15931

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: Nonsymmetric Macdonald polynomials, days40, days45, days49, days54, ICERM2013

Work Issues: doc-pdf

Author: Nicolas M. Thiéry, Anne Schilling

Branch/Commit: a0ceb91

Reviewer: Anne Schilling, Nicolas M. Thiéry, Mark Shimozono, Bogdan Ion

Issue created by migration from https://trac.sagemath.org/ticket/14102

6bbcde06-8197-41f1-b9a3-c998bb839000 commented 11 years ago

Description changed:

--- 
+++ 
@@ -3,3 +3,5 @@
 Cartan types using Demazure-Lusztig operators. An initial patch was written at ICERM by
 Nicolas Thierry consulting with Daniel Orr. Others proposing to work on this project are Ben Brubaker,
 Daniel Bump, Anne Schilling and Mark Shimozono.
+
+The patch in the combinat queue is trac_14102-nonsymmetric-macdonald.patch
6bbcde06-8197-41f1-b9a3-c998bb839000 commented 11 years ago

Description changed:

--- 
+++ 
@@ -4,4 +4,6 @@
 Nicolas Thierry consulting with Daniel Orr. Others proposing to work on this project are Ben Brubaker,
 Daniel Bump, Anne Schilling and Mark Shimozono.

-The patch in the combinat queue is trac_14102-nonsymmetric-macdonald.patch
+The patch in the combinat queue is trac_14102-nonsymmetric-macdonald.patch.
+
+It clashes with trac_11187-finite_reflection_groups-cs.patch.
anneschilling commented 11 years ago

Changed keywords from Nonsymmetric Macdonald to Nonsymmetric Macdonald polynomials, days40, days45

anneschilling commented 11 years ago

Changed keywords from Nonsymmetric Macdonald polynomials, days40, days45 to Nonsymmetric Macdonald polynomials, days40, days45, days49

anneschilling commented 11 years ago

Author: Nicolas M. Thiery, Anne Schilling

anneschilling commented 11 years ago

Dependencies: #4327, #14143, #10963, #14673, #14610

anneschilling commented 11 years ago

Description changed:

--- 
+++ 
@@ -1,9 +1,8 @@
 Existing code for nonsymmetric Macdonald polynomials in Sage (#2708) is in ns_macdonald.py.
-It uses the HHL algorithm and is limited to Type A. The patch at hand will extend this to arbitrary
-Cartan types using Demazure-Lusztig operators. An initial patch was written at ICERM by
-Nicolas Thierry consulting with Daniel Orr. Others proposing to work on this project are Ben Brubaker,
-Daniel Bump, Anne Schilling and Mark Shimozono.
+It uses the HHL algorithm and is limited to Type A. The patch at hand extends this to arbitrary
+Cartan types using Demazure-Lusztig operators. 
+
+The patch was written with substantial input from Daniel Orr, Daniel Bump, Mark Shimozono, Bogdan Ion and Siddhartha Sahi.

 The patch in the combinat queue is trac_14102-nonsymmetric-macdonald.patch.

-It clashes with trac_11187-finite_reflection_groups-cs.patch.
anneschilling commented 11 years ago

Reviewer: Nicolas M. Thiery, Anne Schilling, Mark Shimozono, Bogdan Ion

anneschilling commented 11 years ago

Description changed:

--- 
+++ 
@@ -1,8 +1,8 @@
-Existing code for nonsymmetric Macdonald polynomials in Sage (#2708) is in ns_macdonald.py.
+Existing code for nonsymmetric Macdonald polynomials in Sage (#2708) is in sage.combinat.sf.ns_macdonald.py.
 It uses the HHL algorithm and is limited to Type A. The patch at hand extends this to arbitrary
-Cartan types using Demazure-Lusztig operators. 
+Cartan types using Demazure-Lusztig operators.

-The patch was written with substantial input from Daniel Orr, Daniel Bump, Mark Shimozono, Bogdan Ion and Siddhartha Sahi.
+This patch was written by Anne Schilling and Nicolas M. Thiery during the ICERM Semester Program on "Automorphic Forms, Combinatorial Representation Theory and Multiple Dirichlet Series" (January 28, 2013 - May 3, 2013) with the help of Dan Bump, Ben Brubaker, Bogdan Ion, Dan Orr, Arun Ram, Siddhartha Sahi, and Mark Shimozono. Special thanks go to Bogdan Ion and Mark Shimozono for their patient explanations and hand computations to check the code.

 The patch in the combinat queue is trac_14102-nonsymmetric-macdonald.patch.
nthiery commented 11 years ago

Description changed:

--- 
+++ 
@@ -1,8 +1,14 @@
-Existing code for nonsymmetric Macdonald polynomials in Sage (#2708) is in sage.combinat.sf.ns_macdonald.py.
-It uses the HHL algorithm and is limited to Type A. The patch at hand extends this to arbitrary
-Cartan types using Demazure-Lusztig operators.
+This ticket implements nonsymmetric Macdonald polynomials for
+arbitrary affine Cartan type (including twisted and BC, but not
+Koornwinder) using the recursion formula in terms of Demazure-Lusztig
+and Cherednik operators. It complements the type-A implementation
+based on the HHL combinatorial formula of #2708.

-This patch was written by Anne Schilling and Nicolas M. Thiery during the ICERM Semester Program on "Automorphic Forms, Combinatorial Representation Theory and Multiple Dirichlet Series" (January 28, 2013 - May 3, 2013) with the help of Dan Bump, Ben Brubaker, Bogdan Ion, Dan Orr, Arun Ram, Siddhartha Sahi, and Mark Shimozono. Special thanks go to Bogdan Ion and Mark Shimozono for their patient explanations and hand computations to check the code.
+This patch was written by Anne Schilling and Nicolas M. Thiéry during
+the ICERM Semester Program on "Automorphic Forms, Combinatorial
+Representation Theory and Multiple Dirichlet Series" (January 28,
+2013 - May 3, 2013) with the help of Dan Bump, Ben Brubaker, Bogdan
+Ion, Dan Orr, Arun Ram, Siddhartha Sahi, and Mark Shimozono. Special
+thanks go to Bogdan Ion and Mark Shimozono for their patient
+explanations and hand computations to check the code.

-The patch in the combinat queue is trac_14102-nonsymmetric-macdonald.patch.
-
nthiery commented 11 years ago

Changed reviewer from Nicolas M. Thiery, Anne Schilling, Mark Shimozono, Bogdan Ion to Anne Schilling, Nicolas M. Thiéry, Mark Shimozono, Bogdan Ion

nthiery commented 11 years ago

Changed author from Nicolas M. Thiery, Anne Schilling to Nicolas M. Thiéry, Anne Schilling

447315ef-7140-40e2-b8b8-b6a04e22cfa0 commented 11 years ago
comment:7

Anne and Nicolas,

The family returned by NonSymmetricMacdonaldPolynomials should possess a method that gives direct access to the affine Hecke representation of which it is a basis.

I would like to add symmetric Macdonald polynomials to this patch. It should be straightforward, especially if the AHA representation is at hand.

anneschilling commented 11 years ago
comment:8

Hi Mark,

The family returned by NonSymmetricMacdonaldPolynomials should possess a method that gives direct access to the affine Hecke representation of which it is a basis.

Do you mean that you want the operators

        T   = KL.twisted_demazure_lusztig_operators     (   q1, q2, convention="dominant")
        T_Y = KL.demazure_lusztig_operators_on_classical(q, q1, q2, convention="dominant")

directly available? Or in which format do you want the Hecke algebra representation? You can get

sage: E = NonSymmetricMacdonaldPolynomials(["A",2,1])
sage: E._KL
Group algebra of the Ambient space of the Root system of type ['A', 2, 1] over Fraction Field of Multivariate Polynomial Ring in q, q1, q2 over Rational Field

Best,

Anne

447315ef-7140-40e2-b8b8-b6a04e22cfa0 commented 11 years ago
comment:9

Anne,

The methods I wanted were hidden in the _T and _T_Y attributes.

Why does twisted_demazure_lusztig_operators use classical().dual().affine().dual()? I believe this is correct for untwisted root systems but why do we know this is correct for twisted root systems? If this is a bug it only affects the zero-th Hecke operator.

nthiery commented 11 years ago
comment:10

Replying to @sagetrac-mshimo:

The methods I wanted were hidden in the _T and _T_Y attributes.

Ok. Feel free to add whichever accessors you might think relevant.

Why does twisted_demazure_lusztig_operators use classical().dual().affine().dual()? I believe this is correct for untwisted root systems but why do we know this is correct for twisted root systems? If this is a bug it only affects the zero-th Hecke operator.

Well, it's not a bug, since we get the correct results :-)

More seriously: The cartan type as specified here is actually not really used, except for testing for the relations. It indeed looks dubious and should at some point be rewritten using the "other_affinization" method and the like. We must have been lucky to specify a type that gives the same Coxeter group.

So, if you have a short way to specify the cartan type which you believe is more correct, please go ahead. Otherwise I think this can wait until someone reimplements T0_check in a less ad-hock way.

Cheers, Nicolas

nthiery commented 11 years ago
comment:11

Replying to @sagetrac-mshimo:

I would like to add symmetric Macdonald polynomials to this patch. It should be straightforward, especially if the AHA representation is at hand.

Cool. Since this patch is quite big already, I guess that could go in a followup ticket like the whittaker function one.

447315ef-7140-40e2-b8b8-b6a04e22cfa0 commented 11 years ago
comment:12

Nicolas,

Well, it's not a bug, since we get the correct results :-)

Do you know of an independent way to compute the nonsymmetric Macdonald polynomial for twisted root systems, not just the t=0 specialization? How was this verified?

anneschilling commented 11 years ago
comment:13

Hi Mark,

Do you know of an independent way to compute the nonsymmetric Macdonald polynomial for twisted root systems, not just the t=0 specialization? How was this verified?

The code currently checks that the results (i.e. the nonsymmetric Macdonald polynomials) are indeed eigenvectors of the Y operators. These conditions are not easy to satisfy. For types A_n^{(1)}, B_n^{(1)}, BC_n^{(2)} and BC_n^{(2)}-dual the NSMs were carefully compared against Bogdan Ion's hand and maple computations. If you are worried, I can ask him to confirm type A_{2n-1}^{(2)} as well.

Best,

Anne

anneschilling commented 11 years ago

Description changed:

--- 
+++ 
@@ -12,3 +12,5 @@
 thanks go to Bogdan Ion and Mark Shimozono for their patient
 explanations and hand computations to check the code.

+In a follow-up ticket #14847 Whittaker functions and other features will become available.
+
447315ef-7140-40e2-b8b8-b6a04e22cfa0 commented 11 years ago
comment:15

Nicolas,

I added symmetric macdonald polynomials, fixed the parabolic root system stuff, and edited the docs for nonsymmetric macdonalds rather extensively. I already folded my review patch onto the given patch. Please have a look and if it is ok, replace the above exported patch (I don't have sufficient permissions to do so).

--Mark

anneschilling commented 11 years ago
comment:16

Hi Mark,

Thank you for adding the parabolic root stuff and the symmetric Macdonald polynomials. Usually it is much better not to fold your patch straight in, so that the other people can review your changes first.

Best,

Anne

nthiery commented 11 years ago
comment:17

Mark's review patch can be retrieved from the queue history: http://combinat.sagemath.org/patches/rev/f9a14d979bb9

I am reviewing it now.

nthiery commented 11 years ago
comment:18

Hi Mark!

Thanks a lot for yor work. The documentation reads much better now. Here are a couple questions about your changes:

 - sage: w = W.from_reduced_word([2,3])
 - sage: w.quantum_bruhat_successors([1,3])
 - Traceback (most recent call last):
 - ...
 - ValueError: s2*s3 is not of minimum length in its coset of the parabolic subgroup
 - generated by the reflections [1, 3] 

Was there a reason for removing this test?

- This implementation, based on the general recursion formula,
- covers all affine types including untwisted, twisted, `BC` and its
- dual.
+ This implementation covers all reduced affine root systems.

The phrasing certainly can be improved, but I think it is useful to briefly state the method used.

The extended affine Hecke algebra contains the Y's

Do we really need to mention the extended affine Hecke algebra? The Y's that are implemented are obtained by compositions of the T's and indexed by (co)roots.

629 + if len(index_set) == 0:
630 + return [] 

Was there a reason for this test in positive_roots? For now I removed it.

I removed the method for sums of parabolic positive roots. Do we still really need "is_parabolic_root"?

I did a couple changes in a review patch which I am about to push.

One remaining thing: I noticed that you changed "non-symmetric" to "nonsymmetric". If this is really what we want, then for consistency we should rename the class to NonsymmetricMacdonaldPolynomials (and its file accordingly). But that would not be consistent with the e.g. NonCommutativeSymmetricFunctions.

Cheers, Nicolas

nthiery commented 11 years ago
comment:19

A couple further comments:

About symmetric macdo:

Other than that, I would be in favor of extracting the changes about "positive roots" to a separate ticket, since they are mostly unrelated to macdonald polynomials (or are they not?).

nthiery commented 11 years ago
comment:20

Replying to @nthiery:

I did a couple changes in a review patch which I am about to push.

Pushed on the queue! Please review!

anneschilling commented 11 years ago
comment:21

Replying to @nthiery:

Replying to @nthiery:

I did a couple changes in a review patch which I am about to push.

Pushed on the queue! Please review!

I cannot see that you recently pushed.

Anne

447315ef-7140-40e2-b8b8-b6a04e22cfa0 commented 11 years ago
comment:22

Replying to @nthiery:

 - sage: w = W.from_reduced_word([2,3])
 - sage: w.quantum_bruhat_successors([1,3])
 - Traceback (most recent call last):
 - ...
 - ValueError: s2*s3 is not of minimum length in its coset of the parabolic subgroup
 - generated by the reflections [1, 3] 

Was there a reason for removing this test?

I got a doctest error I didn't understand (stupid reason): the tester was producing a blank line that wasn't matching the doctest string.

- This implementation, based on the general recursion formula,
- covers all affine types including untwisted, twisted, `BC` and its
- dual.
+ This implementation covers all reduced affine root systems.

The phrasing certainly can be improved, but I think it is useful to briefly state the method used.

I can add that (or rather put it back in).

The extended affine Hecke algebra contains the Y's

Do we really need to mention the extended affine Hecke algebra? The Y's that are implemented are obtained by compositions of the T's and indexed by (co)roots.

If only coroots are involved then no. I can take that out.

629 + if len(index_set) == 0:
630 + return [] 

Was there a reason for this test in positive_roots? For now I removed it.

It is not needed (I added it during debugging before finding that the initial set of simple roots needed to be changed before the search).

I removed the method for sums of parabolic positive roots. Do we still really need "is_parabolic_root"?

That sum method should be thought of as analogous to the computation of rho. This fixed quantity (depends only on the root system and subset of index set) gets used many times over in the computation of the parabolic quantum Bruhat graph (which we then use to make KR crystals). That is why I decided not to delete it. There is a method in root_systems/root_space.py called quantum_root that requires this sum as well.

is_parabolic_root is probably not really needed.

I did a couple changes in a review patch which I am about to push.

One remaining thing: I noticed that you changed "non-symmetric" to "nonsymmetric". If this is really what we want, then for consistency we should rename the class to NonsymmetricMacdonaldPolynomials (and its file accordingly). But that would not be consistent with the e.g. NonCommutativeSymmetricFunctions.

Not really. I'm generally against unnecessary hyphenation. (By the way I like NoncommutativeSymmetricFunctions better than the alternative.)

nthiery commented 11 years ago
comment:23

I cannot see that you recently pushed.

Argl, sorry. I had cloned from a local repository (to avoid messing with my local C3 changes), and did not notice I was thus pushing back there ...

Done!

Cheers, Nicolas

nthiery commented 11 years ago
comment:24

Replying to @sagetrac-mshimo:

I removed the method for sums of parabolic positive roots. Do we still really need "is_parabolic_root"?

That sum method should be thought of as analogous to the computation of rho. This fixed quantity (depends only on the root system and subset of index set) gets used many times over in the computation of the parabolic quantum Bruhat graph (which we then use to make KR crystals). That is why I decided not to delete it.

It's used many times there indeed, but if I remember well calculated only once at the beginning of the method.

Ok. If I recall correctly my review patch has taken it out.

May I let you implement the little things on which we agreed, and possibly reinstate sums_of_parabolic_positive_roots, with a cache and documentation, if you think it's really worthwhile?

I'm generally against unnecessary hyphenation.

I see your point.

Not totally consistent.

(By the way I like NoncommutativeSymmetricFunctions better than the alternative.)

On the other hand NCSF has been the traditional shorthand for a while ...

Hmm. Here is what we have in Sage currently:

NonCommutativeSymmetricFunctions    NonDecreasingParkingFunction
NonDecreasingParkingFunctions   NonNegativeIntegerSemiring
NonNegativeIntegers     NonSymmetricMacdonaldPolynomials
NonattackingFillings

There is a bias, but it's not perfectly consistent.

Do we need to make a poll on sage-devel?

Cheers, Nicolas

447315ef-7140-40e2-b8b8-b6a04e22cfa0 commented 11 years ago
comment:25

Nicolas,

Right now the quantum bruhat graph is twice broken; I will repair it.

The quantum_bruhat_successors method in categories/weyl_groups (element method) gets called repeatedly (once for each element of the parabolic quotient) to generate the quantum Bruhat graph. Each time this function is called, it needs to loop through the set of positive roots that are NOT in the parabolic subsystem; each such root could lead to a quantum arrow. For this reason I'm going to reinstate the function that constructs the non-parabolic positive roots. At this point I don't see a reason why one should also not remember the sum of these roots (rather than recompute it repeatedly).

Also the quantum_root method (in root_systems/root_space.py), which is called by quantum_bruhat_successors, requires the same sum.

I'll put the failing doctest back in. I couldn't match the exception message, which started with a rather than Traceback. Maybe you can match it.

--Mark

447315ef-7140-40e2-b8b8-b6a04e22cfa0 commented 11 years ago
comment:26

I pushed another review patch after Nicolas' review patch.

I figured out the doctest issue.

There is a direct formula (see Cherednik's 2009 book, formula (3.3.15)) for the symmetric macdonald as a linear combination of nonsymmetric Macdonalds (with complicated rational function coefficients), which someone else can program when they feel inspired. This is the same kind of chore as writing a function for the precise eigenvalues in the nonsymmetric Macdonald recurrence.

anneschilling commented 11 years ago
comment:27

Hi Mark and Nicolas,

Thank you both for your review patches. I looked them both over and in principle it is fine with me to fold them in (I made some minor fixes to Mark's review patch).

Regarding the naming, I agree with Mark that it is nicer to remove the hyphens. However, can we nonetheless leave the name of the class as NonSymmetricMacdonaldPolynomials in accordance with NCSF and most other classes? I do not mind this convention in sage since the real meaning is in (non)symmetric and not the non. But if you really want to change it, that is fine with me as well.

Best,

Anne

anneschilling commented 11 years ago
comment:28

Hi Mark and Nicolas,

Here is an update on the twisted types. I asked Bogdan Ion for data for type A_5^{(2)}. Everything seems to match:

sage: K = QQ['q,t'].fraction_field()
sage: q,t = K.gens()
sage: E = NonSymmetricMacdonaldPolynomials(["A",5,2], q, t**2,-1)
sage: omega = E.keys()
sage: vars = K['x1,x2,x3'].gens()
sage: x1,x2,x3 = K['x1,x2,x3'].gens()

sage: E[omega[1]].expand(vars) == x1
True
sage: E[-omega[1]].expand(vars) == (t-1)*(t+1)*(q*t^10-1)*x1/((t^2*q-1)*(q*t^5-1)*(q*t^5+1))+(t-1)*(t+1)*x2/(t^2*q-1)+(t-1)*(t+1)*x3/(t^2*q-1)+(t-1)*(t+1)/((t^2*q-1)*x2)+1/x1+(t-1)*(t+1)/((t^2*q-1)*x3)
True
sage: E[omega[2]].expand(vars) == (t-1)*(t+1)*x1/(q*t^8-1)+x2
True
sage: E[-omega[2]].expand(vars) == (q*t^6+1)*(t-1)*(t+1)*(q*t^6-1)*x1/((q*t^5-1)*(q*t^5+1)*(q*t^4-1))+(t+1)*(t-1)*(q*t^8-1)*x2/((q*t^5-1)*(q*t^5+1)*(q*t^4-1))+(t-1)*(t+1)*x3/(q*t^4-1)+1/x2+(t-1)*(t+1)/((q*t^4-1)*x3)
True
sage: E[-omega[1]-omega[2]].expand(vars) == (t-1)*(t+1)*(q^3*t^10+2*t^10*q^2-q^2*t^8-2*t^6*q^2+q*t^8-q*t^6-2*q*t^4+q+2-t^4)/((t^2*q-1)*(q*t^4-1)*(q*t^3-1)*(q*t^3+1))+(t+1)*(t-1)/((t^2*q-1)*x3*x2)+(t+1)*(t-1)*x3/((t^2*q-1)*x2)+(t+1)^2*(t-1)^2*(q*t^4+t^2+1)*x1*x3/((q*t^3-1)*(q*t^3+1)*(t^2*q-1))+(t+1)*(t-1)*(q*t^6-1)*x1/((q*t^3-1)*(q*t^3+1)*(t^2*q-1)*x2)+(t+1)^2*(t-1)^2*(q*t^4+t^2+1)*x1/((q*t^3-1)*(q*t^3+1)*(t^2*q-1)*x3)+(t+1)*(t-1)*(t^10*q^2-q*t^8+t^8-q*t^6-t^4+1)*x1*x2/((t^2*q-1)*(q*t^4-1)*(q*t^3-1)*(q*t^3+1))+(t+1)*(t-1)*(q*t^6-1)*x2/((q*t^3-1)*(q*t^3+1)*(t^2*q-1)*x1)+(t+1)^2*(t-1)^2*(q*t^4+t^2+1)*x3*x2/((q*t^3-1)*(q*t^3+1)*(t^2*q-1))+1/(x1*x2)+(t+1)*(t-1)*x3/((t^2*q-1)*x1)+(t+1)*(t-1)/((t^2*q-1)*x1*x3)+(t+1)^2*(t-1)^2*(q*t^4+t^2+1)*x2/((q*t^3-1)*(q*t^3+1)*(t^2*q-1)*x3)
True
sage: E[omega[1]-omega[2]].expand(vars) == (q*t^6+1)*(t-1)*(t+1)*(q*t^6-1)*q/((q*t^5-1)*(q*t^5+1)*(q*t^4-1))+(t-1)*(t+1)*x1*x3/(q*t^4-1)+x1/x2+(t-1)*(t+1)*x1/((q*t^4-1)*x3)+(t+1)*(t-1)*(q*t^8-1)*x1*x2/((q*t^5-1)*(q*t^5+1)*(q*t^4-1))Truesage: E[omega[3]].expand(vars) == (t-1)*(t+1)*x1/(q*t^6-1)+(t-1)*(t+1)*x2/(q*t^6-1)+x3True
sage: E[-omega[3]].expand(vars) == (q*t^6+1)*(t-1)*(t+1)*x1/((q*t^5-1)*(q*t^5+1))+(q*t^6+1)*(t-1)*(t+1)*x2/((q*t^5-1)*(q*t^5+1))+(t-1)*(t+1)*x3/((q*t^5-1)*(q*t^5+1))+1/x3
True

I put a review patch putting (similar) tests for twisted types as a review patch.

Nicolas, please review everything, fold and upload the updated patch!

Thanks,

Anne

anneschilling commented 11 years ago

Description changed:

--- 
+++ 
@@ -14,3 +14,7 @@

 In a follow-up ticket #14847 Whittaker functions and other features will become available.

+Apply:
+- [attachment: trac_14102-nonsymmetric-macdonald.2.patch](https://github.com/sagemath/sage-prod/files/10657114/trac_14102-nonsymmetric-macdonald.2.patch.gz)
+
+
anneschilling commented 11 years ago
comment:30

Hi Nicolas and Mark,

I made some mini changes, but other than that everything looks good now!

Anne

447315ef-7140-40e2-b8b8-b6a04e22cfa0 commented 11 years ago
comment:31

Why does the patchbot see red? Does it mean the patches don't apply?

anneschilling commented 11 years ago
comment:32

Replying to @sagetrac-mshimo:

Why does the patchbot see red? Does it mean the patches don't apply?

The patch depends on #10963 and Nicolas probably has not yet uploaded that patch yet on trac. Oops and #13589 is also a prerequiste. So I put this into the dependencies.

anneschilling commented 11 years ago

Changed dependencies from #4327, #14143, #10963, #14673, #14610 to #4327, #14143, #13589, #10963, #14673, #14610

nthiery commented 11 years ago

Description changed:

--- 
+++ 
@@ -14,7 +14,3 @@

 In a follow-up ticket #14847 Whittaker functions and other features will become available.

-Apply:
-- [attachment: trac_14102-nonsymmetric-macdonald.2.patch](https://github.com/sagemath/sage-prod/files/10657114/trac_14102-nonsymmetric-macdonald.2.patch.gz)
-
-
nthiery commented 11 years ago
comment:34

Hi!

I checked Anne's little review patch.

I replaced here my "old" patch by yours.

I just posted on trac the latest #10963 patch (it indeed needed some rebasing on top of the reviewer's patches for #13589)

Cheers, Nicolas

447315ef-7140-40e2-b8b8-b6a04e22cfa0 commented 11 years ago
comment:35

Nicolas, I updated the patch on the combinat queue since there was a subtle bug in the symmetric macdonald polynomials having to do with caching and the order of searching a Weyl orbit. Didn't export it to trac.

Again I forgot to make a separate review patch. There is a doctest change in symmetric_macdonald polynomials and a change in the orbit method of root_lattice_realizations, to calling TransitiveIdealGraded instead of TransitiveIdeal.

--Mark

anneschilling commented 11 years ago

Description changed:

--- 
+++ 
@@ -14,3 +14,6 @@

 In a follow-up ticket #14847 Whittaker functions and other features will become available.

+Apply:
+- [attachment: trac_14102-nonsymmetric-macdonald.2.patch](https://github.com/sagemath/sage-prod/files/10657114/trac_14102-nonsymmetric-macdonald.2.patch.gz)
+
anneschilling commented 11 years ago
comment:38

Ok, Mark, I updated the patch on the trac server!

Anne

nthiery commented 11 years ago
comment:39

Attachment: trac_14102-nonsymmetric-macdonald.patch.gz

The updated patch has been trivially rebased on top of 14755 which is about to get merged.

nthiery commented 11 years ago

Changed dependencies from #4327, #14143, #13589, #10963, #14673, #14610 to #4327, #14143, #13589, #10963, #14673, #14610, #14755

nthiery commented 11 years ago

Description changed:

--- 
+++ 
@@ -14,6 +14,4 @@

 In a follow-up ticket #14847 Whittaker functions and other features will become available.

-Apply:
-- [attachment: trac_14102-nonsymmetric-macdonald.2.patch](https://github.com/sagemath/sage-prod/files/10657114/trac_14102-nonsymmetric-macdonald.2.patch.gz)
anneschilling commented 11 years ago

Changed dependencies from #4327, #14143, #13589, #10963, #14673, #14610, #14755 to #4327, #14143, #13589, #10963, #14673, #14610, #14775

anneschilling commented 11 years ago
comment:41

I think you meant #14775 instead of #14755, so I changed that!

anneschilling commented 10 years ago

Attachment: trac_14102-nonsymmetric-macdonald.2.patch.gz