search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.38k stars 469 forks source link

More doctests from the book "Calcul mathématique avec Sage" Chapter "linsolve" #14321

Closed c9ad8769-79a9-4367-b666-c3e9b75ce4e3 closed 11 years ago

c9ad8769-79a9-4367-b666-c3e9b75ce4e3 commented 11 years ago

The attached file provides doctests for examples in the chapter on numerical linear algebra equations. Tests pass with 5.11.

Apply only attachment: trac_14321_doctests_from_french_book.patch​

Component: doctest coverage

Author: Thierry Dumont, Paul Zimmermann

Reviewer: Frédéric Chapoton

Merged: sage-5.12.beta5

Issue created by migration from https://trac.sagemath.org/ticket/14321

c9ad8769-79a9-4367-b666-c3e9b75ce4e3 commented 11 years ago

Changed upstream from Not yet reported upstream; Will do shortly. to none

c9ad8769-79a9-4367-b666-c3e9b75ce4e3 commented 11 years ago
comment:1

Attachment: linsolve_doctest.sage.gz

zimmermann6 commented 11 years ago

Author: Thierry Dumont, Paul Zimmermann

zimmermann6 commented 11 years ago

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
-The attached file provides doctests for examples in the chapter on numerical linear algebra equations. Tests pass with 5.8. 
+The attached file provides doctests for examples in the chapter on numerical linear algebra equations. Tests pass with 5.11.
+
+Apply only trac_14321_doctests_from_french_book.patch​.
zimmermann6 commented 11 years ago
comment:3

Attachment: trac_14321_doctests_from_french_book.patch.gz

I've modified the attachment to a proper patch. All tests pass with Sage 5.11. Ready for review.

Paul

fchapoton commented 11 years ago
comment:4

ok, looks good to me

Some of the tests are just the definition of a function or a class, and this function is not used in the remaining tests.

These tests are just a check of the python syntax..

fchapoton commented 11 years ago

Reviewer: Frédéric Chapoton

jdemeyer commented 11 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 The attached file provides doctests for examples in the chapter on numerical linear algebra equations. Tests pass with 5.11.

-Apply only trac_14321_doctests_from_french_book.patch​.
+Apply only [attachment: trac_14321_doctests_from_french_book.patch​](https://github.com/sagemath/sage/files/ticket14321/211cd932e9cb04b532560b050b385f19.gz)
jdemeyer commented 11 years ago

Merged: sage-5.12.beta5