Closed d4d9e38a-6e64-40d7-a7f7-bd828eb9e0db closed 11 years ago
Changed author from zabrocki, aschilling to Mike Zabrocki
Reviewer: Anne Schilling
Description changed:
---
+++
@@ -1 +1 @@
-the dual k-schur functions in the Symmetric Function package have a combinatorial expansion in terms of strong k-tableaux. This ticket will implement the classes as well as methods for manipulating these objects
+The dual k-schur functions in the Symmetric Function package have a combinatorial expansion in terms of strong k-tableaux. This ticket implements the classes of StrongTableau and StrongTableaux as well as methods for manipulating these objects
Description changed:
---
+++
@@ -1 +1 @@
-The dual k-schur functions in the Symmetric Function package have a combinatorial expansion in terms of strong k-tableaux. This ticket implements the classes of StrongTableau and StrongTableaux as well as methods for manipulating these objects
+The dual k-schur functions in the Symmetric Function package have a combinatorial expansion in terms of strong k-tableaux. This ticket implements the classes of `StrongTableau` and `StrongTableaux` as well as methods for manipulating these objects
Mike and I just met and reviewed and discussed the code together. All changes that I requested were incorporated, so I am happy with the code.
Positive review!
Anne
I realized that there was an inconsistency with the name of one of the methods and changed content_of_marked_ribbon to content_of_marked_head
Thanks for the positive review and for the visit in Montreal.
sage -t --long devel/sage/sage/combinat/core.py
**********************************************************************
File "devel/sage/sage/combinat/core.py", line 379, in sage.combinat.core.Core.weak_le
Failed example:
c.weak_le(x)
Expected:
Traceback (most recent call last):
...
AssertionError: The two cores do not have the same k
Got:
<BLANKLINE>
Traceback (most recent call last):
File "/scratch/release/merger/sage-5.12.rc0/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 479, in _run
self.execute(example, compiled, test.globs)
File "/scratch/release/merger/sage-5.12.rc0/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 838, in execute
exec compiled in globs
File "<doctest sage.combinat.core.Core.weak_le[7]>", line 1, in <module>
c.weak_le(x)
File "/scratch/release/merger/sage-5.12.rc0/local/lib/python2.7/site-packages/sage/combinat/core.py", line 386, in weak_le
raise ValueError("The two cores do not have the same k")
ValueError: The two cores do not have the same k
**********************************************************************
That was unexpected, but easily changed.
Hi Mike,
That was unexpected, but easily changed.
Did you fix the error? I still get the same error that Jeroen reported
combinat anne$ sage -t --long core.py
Running doctests with ID 2013-09-27-11-38-00-bec5fc69.
Doctesting 1 file.
sage -t --long core.py
**********************************************************************
File "core.py", line 379, in sage.combinat.core.Core.weak_le
Failed example:
c.weak_le(x)
Expected:
Traceback (most recent call last):
...
AssertionError: The two cores do not have the same k
Got:
<BLANKLINE>
Traceback (most recent call last):
File "/Applications/sage-5.12.beta5/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 479, in _run
self.execute(example, compiled, test.globs)
File "/Applications/sage-5.12.beta5/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 838, in execute
exec compiled in globs
File "<doctest sage.combinat.core.Core.weak_le[7]>", line 1, in <module>
c.weak_le(x)
File "/Applications/sage-5.12.beta5/local/lib/python2.7/site-packages/sage/combinat/core.py", line 386, in weak_le
raise ValueError("The two cores do not have the same k")
ValueError: The two cores do not have the same k
**********************************************************************
1 item had failures:
1 of 9 in sage.combinat.core.Core.weak_le
[119 tests, 1 failure, 9.02 s]
----------------------------------------------------------------------
sage -t --long core.py # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 9.2 seconds
cpu time: 4.9 seconds
cumulative wall time: 9.0 seconds
Also, doing a diff, I cannot see that you changed any content
hg diff
diff --git a/trac_14776-strong-ktableaux-mz.patch b/trac_14776-strong-ktableaux-mz.patch
--- a/trac_14776-strong-ktableaux-mz.patch
+++ b/trac_14776-strong-ktableaux-mz.patch
@@ -1,5 +1,8 @@
# HG changeset patch
-# Parent 58eed6940f88ab629a22eec9627878cdd23e6566
+# User Mike Zabrocki
+# Date 1376683423 14400
+# Node ID bb1ee08d656b6426a6fe76dd2aee284284343a2a
+# Parent 85cc8a56797b4f299b118bff6ba8cffcdb3e421f
#14776 : implements StrongTableau and StrongTableaux classes
diff --git a/sage/combinat/all.py b/sage/combinat/all.py
Best,
Anne
Attachment: trac_14776-strong-ktableaux-mz.patch.gz
Sorry. I failed to qrefresh before exporting.
Replying to @zabrocki:
Sorry. I failed to qrefresh before exporting.
Ok, looks good now.
Anne
Merged: sage-5.12.rc0
The dual k-schur functions in the Symmetric Function package have a combinatorial expansion in terms of strong k-tableaux. This ticket implements the classes of
StrongTableau
andStrongTableaux
as well as methods for manipulating these objectsDepends on #12250
CC: @anneschilling @sagetrac-npgallup
Component: combinatorics
Keywords: tableaux, days49
Author: Mike Zabrocki
Reviewer: Anne Schilling
Merged: sage-5.12.rc0
Issue created by migration from https://trac.sagemath.org/ticket/14776