sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.37k stars 462 forks source link

add first smc primitive to crypto #15147

Open b9b09e0d-8711-4f66-8f57-ad2386d45134 opened 11 years ago

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 11 years ago

Hi,this is my first submission. Just started with a first version of shamir secret sharing. The idea is to add more secure multiparty computation (SMC) primitives in crypto. If OK, there is more to come.

Cheers,TL

Component: cryptography

Keywords: smc

Author: Thomas Loruenser

Branch/Commit: u/chapoton/15147 @ 40411b4

Issue created by migration from https://trac.sagemath.org/ticket/15147

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 11 years ago
comment:1

Attachment: smc.patch.gz

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 11 years ago

Author: Thomas Loruenser

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 11 years ago
comment:3

Attachment: trac15147_smc.patch.gz

Updated the patch:

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 11 years ago
comment:4

Attachment: trac15147_smc_v1.0.patch.gz

Minor fix in latest verison of patch (trac15147_smc_v1.0.patch​). Just swapped vars in constructor to be consistent with literature.

fchapoton commented 11 years ago
comment:5

please use the new syntax for raising errors, namely

raise ValueError('this is the message here')

instead of

raise ValueError, 'the message was there'
b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 11 years ago
comment:6

fixed: raise exception format in trac15147_smc_v1.1.patch

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 11 years ago

Attachment: trac15147_smc_v1.1.patch.gz

fchapoton commented 11 years ago
comment:7

you should rather not change the name of the patch at every new version..

for the patchbot: apply only trac15147_smc_v1.1.patch

fchapoton commented 11 years ago
comment:8

could you please replace

612–613. doi:10.1145/359168.359176

by

612-613. :doi:`10.1145/359168.359176`

The long dash is not a standard character, and the doi can be a link to the article.

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 11 years ago

Attachment: trac15147_smc_v1.1.2.patch.gz

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 11 years ago
comment:9

just fixed trac15147_smc_v1.1.patch with your suggested changes

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 10 years ago

Attachment: trac15147_smc_v1.1.3.patch.gz

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 10 years ago
comment:10

fixed a minor TODO

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 10 years ago
comment:11

Attachment: trac15147_smc_v1.1.4.patch.gz

added support for arbitrary finite fields

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 10 years ago

Attachment: trac15147_smc_v1.1.5.patch.gz

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 10 years ago
comment:12

and a minor cleanup and bug fix. that's it.

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 10 years ago

Attachment: trac15147_smc_v1.1.6.patch.gz

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 10 years ago
comment:13

removed last todo and minor rearrangement

b9b09e0d-8711-4f66-8f57-ad2386d45134 commented 10 years ago
comment:14

Attachment: trac15147_smc_v1.1.7.patch.gz

trac15147_smc_v1.1.7.patch​ : added rabin ids to demonstrate similarity to shamirsecretsharing

fchapoton commented 10 years ago

Branch: u/chapoton/15147

fchapoton commented 10 years ago

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
-Hi,this is my first sumbmission. Just started with a first version of shamir secret sharing.
+Hi,this is my first submission. Just started with a first version of shamir secret sharing.
 The idea is to add more secure multiparty computation (SMC) primitives in crypto.
 If OK, there is more to come.
fchapoton commented 10 years ago

Commit: 5dea268

fchapoton commented 10 years ago
comment:17

I made a git branch, plus a few pep8 details changed


New commits:

0b2b7f0exporting patch:
5dea268trac #15147 made a git branch + pep8 checkup
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

38e770bMerge branch 'u/chapoton/15147' of ssh://trac.sagemath.org:22/sage into 15147
e5e6e6atrac #15147 remove unnecessary non-ascii characters
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 5dea268 to e5e6e6a

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

059ba01Merge branch 'u/chapoton/15147' into 6.6.b1
03f9851trac 15147 : replacing deprecated coeffs by coefficients
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from e5e6e6a to 03f9851

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

f78129cMerge branch 'u/chapoton/15147' in 8.2
40411b4fixing imports
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 03f9851 to 40411b4