Closed tscrim closed 9 years ago
Branch pushed to git repo; I updated commit sha1. New commits:
[e7a558d](https://github.com/sagemath/sagetrac-mirror/commit/e7a558d) | Merge branch 'master' into public/combinat/crystals/crystal_plots |
Branch pushed to git repo; I updated commit sha1. New commits:
[1b48a12](https://github.com/sagemath/sagetrac-mirror/commit/1b48a12) | Merge branch 'public/combinat/crystals/crystal_plots' of ssh://trac.sagemath.org:2222/sage into public/combinat/crystals/crystal_plots |
[667282c](https://github.com/sagemath/sagetrac-mirror/commit/667282c) | Merge branch 'master' into public/combinat/crystals/crystal_plots |
The ticket title could be more explicit :-) In fact the current description would be a rather good one.
Cheers,
Description changed:
---
+++
@@ -1 +1 @@
-Adds methods to plot crystals and LS paths.
+Improvements to the root systems plotting which will plot crystals automatically in a few different formats, as well as LS paths as paths in the root system.
Failing doctests, see patchbot report
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
c2e84e1 | remaining doctests for induced_graded_map |
03bd4cf | possibly controversial: graded_algebra and the three methods forming its interface are now cached_methods |
8a747c0 | further edits |
831c269 | Merge branch 'public/categories/filtered_algebras-17096' of git://trac.sagemath.org/sage into filt |
752df77 | Revert the cached_method decorators from commit "possibly controversial: graded_algebra and the three methods forming its interface are now cached_methods" |
dfaaaeb | associated-graded now also defined for filtered *modules*, although still named 'graded algebra' in this case |
43a976a | Merge branch 'public/categories/filtered_algebras-17096' of trac.sagemath.org:sage into public/categories/filtered_algebras-17096 |
d1d135f | Give Weyl/Clifford/Exterior super powers. |
ea66981 | Merge branch 'public/combinat/crystals/crystal_plots' of trac.sagemath.org:sage into public/combinat/crystals/crystal_plots |
349a935 | Fixing doctest. |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
bac38bf | Fixing doctest. |
Looks good to me. Thanks, Travis!
Reviewer: Ben Salisbury
Thanks for doing the review Ben!
Changed branch from public/combinat/crystals/crystal_plots to bac38bf
Improvements to the root systems plotting which will plot crystals automatically in a few different formats, as well as LS paths as paths in the root system.
CC: @sagetrac-sage-combinat @nthiery @bsalisbury1
Component: graphics
Keywords: crystal, LS paths, plotting
Author: Travis Scrimshaw
Branch/Commit:
bac38bf
Reviewer: Ben Salisbury
Issue created by migration from https://trac.sagemath.org/ticket/15415