sagemath / sage

Main repository of SageMath. Now open for Issues and Pull Requests.
https://www.sagemath.org
Other
1.2k stars 413 forks source link

Sage 2.9: fix optional doctests in tut.tex #1549

Closed 85eec1a4-3d04-4b4d-b711-d4db03337c41 closed 16 years ago

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 16 years ago
File "tut.py", line 3390:
    : G
Expected:
    Group([ (1,2,3)(4,5), (3,4) ])
Got:
    Group( [ (1,2,3)(4,5), (3,4) ] )
**********************************************************************
File "tut.py", line 3392:
    : G.Center()
Expected:
    Group(())
Got:
    Group( () ) 

Cheers,

Michael

Component: doctest coverage

Issue created by migration from https://trac.sagemath.org/ticket/1549

aghitza commented 16 years ago

doc patch, apply second

aghitza commented 16 years ago
comment:1

Attachment: 1549-tut_optional.patch.gz

I am attaching two patches. The first changes the _repr_ of Galois groups from the current clunky

Galois group PARI group [8, 1, 3, "E(8)=2[x]2[x]2"] of degree 8 of the number field Number Field in a with defining polynomial x^2 + 1 over its base field

to

Galois group PARI group [8, 1, 3, "E(8)=2[x]2[x]2"] of degree 8 of the Number Field in a with defining polynomial x^2 + 1 over its base field

The second patch is a documentation patch and fixes the optional doctest failures in tut.tex (and removes the #optional tag from one of them, since now by default GaloisGroup uses PARI instead of optional GAP packages).

JohnCremona commented 16 years ago
comment:2

Looks good to me. There's a tiny typo in the first patch ("isreducible" needs a space), otherwise fine.

aghitza commented 16 years ago

Attachment: 1549-galois_gp.patch.gz

aghitza commented 16 years ago
comment:3

I've replaced the first patch with one that fixes the typo pointed out by John.

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 16 years ago
comment:4

Merged both patches in Sage 3.0.1.alpha1