Closed miguelmarco closed 10 years ago
Attachment: 15528_rewriting_systems.patch.gz
Branch: u/mmarco/ticket/15528
Commit: fbcb3a3
Branch pushed to git repo; I updated commit sha1. New commits:
fbcb3a3 | Added rewriting systems of finitely presented groups |
Reviewer: Travis Scrimshaw
Changed branch from u/mmarco/ticket/15528 to u/tscrim/ticket/15528
Changed author from mmarco to Miguel Angel Marco Buzunariz
I've made some review changes, so if you agree with them, then you can set this to positive review.
Best,
Travis
New commits:
6268cca | Merge branch 'u/mmarco/ticket/15528' of trac.sagemath.org:sage into u/tscrim/ticket/15528 |
504df8f | Merge branch 'develop' of trac.sagemath.org:sage into u/tscrim/ticket/15528 |
cfbb6e5 | Review changes for #15528. |
ed1095d | Made the repr sorted for the rules. |
Looks good to me. Maybe i should add some methods to return the fpgroup and the free group that it relates to. But i don't know if it would be better in another ticket or is it good to add it here.
I think it's fine (maybe even good) to do so here.
Changed branch from u/tscrim/ticket/15528 to u/mmarco/ticket/15528
Added the two methods .free_group() and .finitely_presented_group()
I don't see the changes.
Branch pushed to git repo; I updated commit sha1. New commits:
810a9bb | Added free_group and finitely_presented_group |
sorry, i forgot to commit. There they are.
No worries. Looks good.
This patch adds a class for rewriting systems for finitely presented groups. Rewriting systems can be used (when the Knuth-Bendix algorithms finishes in finite time) to get reduced forms of the elements of the group, the same way that groebner basis can be used to get normal forms of elements of polynomial rings modulo ideals.
This class is just a wrapper of corresponding GAP functions.
Examples:
CC: @vbraun @tscrim @dimpase
Component: group theory
Keywords: finitely presented groups
Author: Miguel Angel Marco Buzunariz
Branch/Commit: u/mmarco/ticket/15528 @
810a9bb
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/15528