Closed 3a5ab40a-5e15-47f8-8025-1665d51c0660 closed 10 years ago
Branch: u/wluebbe/ticket/15951
Author: Wilfried Luebbe
Commit: 462a495
Should rather be a ValueError, in my humble opinion
ok, I have made a branch with ValueError. (plus a few pep8 details around)
If you agree with my branch, you cen set this to positive review
New commits:
702e08b | trac #15951 correct one raise statement towards python3 |
Reviewer: Frédéric Chapoton
Changed branch from u/wluebbe/ticket/15951 to u/chapoton/15951
I had selected TypeError
after looking at the other raise statements in this module. But ValueError
is nearly as good :-)
So the patch is fine for me.
Changed branch from u/chapoton/15951 to 702e08b
sage/algebras/quatalg/quaternion_algebra.py
has in line 988 the (hopefully) last string exception (I found no other):
raise "base field must be rational numbers or number field"
.These have been deprecated since long. They not accepted be Python 3.
Component: algebra
Keywords: exception, raise
Author: Wilfried Luebbe
Branch/Commit:
702e08b
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/15951