Parallelogram Polyomino

c270b1b6-1da3-4e49-b2c9-ab561f083022 commented 10 years ago

Implementation of the Parallelogram Polyominoes

Component: combinatorics

Keywords: Parallelogram polyomino, days57, days79, thursdaysbdx

Author: Adrien Boussicault

Branch/Commit: 41c18d9

Reviewer: Sébastien Labbé, Martin Rubey

Issue created by migration from https://trac.sagemath.org/ticket/16110

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`0eb710d`	`trac 16204 some more doc, plus code details`
`79dc6e6`	`Add Parallelogram polyominoes`
`f52b822`	`Improve documentation`
`107a220`	`Improve parallelogram polyomino bijection + doc.`
`23751dd`	`Improve documentation`
`667fe14`	`Some documentation`
`1ff1156`	`Improve documentation`
`170a6c0`	`Small bug`
`425e97c`	`Solve Documentation problems`
`5a90eb9`	`Merge branch 'u/boussica/parallelogram_polyomino_2' of git://trac.sagemath.org/sage into t/16110/parallelogram_polyomino_2`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from f4ec302 to 5a90eb9

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

c7270a6 Add some documentation

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 5a90eb9 to c7270a6

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from c7270a6 to 99e238f

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

99e238f Add Documentation and Tests for PP.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 99e238f to 4c4fd49

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

4c4fd49 Now PP have the good size : the half-permiter

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

70cda63 Add some documentations

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 4c4fd49 to 70cda63

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 70cda63 to 0b995ab

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

0b995ab Improve documentation

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 0b995ab to ae4513e

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

ae4513e Documentation improvement

fchapoton commented 8 years ago

comment:39

Still need more doc, every function must be documented:

combinat/parallelogram_polyomino.py: 80.9% (72 of 89)

Some error in doc formatting:

+[dochtml] [combinat ] /home/worker/sage-patchbot/local/lib/python2.7/site-packages/sage/combinat/parallelogram_polyomino.py:docstring of sage.combinat.parallelogram_polyomino.default_tikz_options:10: ERROR: Unexpected indentation.
+[dochtml] [combinat ] /home/worker/sage-patchbot/local/lib/python2.7/site-packages/sage/combinat/parallelogram_polyomino.py:docstring of sage.combinat.parallelogram_polyomino.default_tikz_options:15: ERROR: Unexpected indentation.

The function "breadth_node_paths_generator" has been given another name in #16204. So doctests here do not pass.

fchapoton commented 8 years ago

comment:40

I have made a refreshed branch. There still remains

1) to have full and clean documentation

2) to adapt to the new standard of global options introduced by #18555

New commits:

`9cbd427`	`Merge branch 'u/boussica/parallelogram_polyomino_2' in 7.3.rc0`
`192d35d`	`trac 16110 refresh the code (partially)`

fchapoton commented 8 years ago

Changed commit from ae4513e to 192d35d

fchapoton commented 8 years ago

Changed branch from u/boussica/parallelogram_polyomino_2 to public/16110

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

da7931e Merge branch 'develop' into t/16110/public/16110

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 192d35d to da7931e

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

5862882 Update documentation and port for sage 7.5

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from da7931e to 5862882

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

91fb165 Implementation of LocalOption

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 5862882 to 91fb165

087a1043-4634-4ee8-ad42-b852c243fe15 commented 7 years ago

Changed keywords from Parallelogram polyomino, days57 to Parallelogram polyomino, days57, days79

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

4b27924 Solve error when compiling documentation

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 91fb165 to 4b27924

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 4b27924 to faa4de2

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

faa4de2 Doc updates

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

35edd8d Updat documentation of Parallelogram polyominoes

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from faa4de2 to 35edd8d

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`34e14b9`	`Add some documentation`
`e06550f`	`Merge branch 'public/16110' of git://trac.sagemath.org/sage into t/16110/public/16110`
`e0b331b`	`Merge + failed test`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 35edd8d to e0b331b

fchapoton commented 7 years ago

comment:49

you should not use xrange but range

you should use python3 syntax for print, namely print("stuff")

see patchbot report

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

4f0788d Added some documentation and tests

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from e0b331b to 4f0788d

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 4f0788d to b74afb7

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`8ad387e`	`Improve documentation`
`b74afb7`	`Merge branch 'public/16110' of git://trac.sagemath.org/sage into t/16110/public/16110`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from b74afb7 to 08dc790

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

08dc790 Corrected some tests.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

8c7fd34 Added some documentations

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 08dc790 to 8c7fd34

fchapoton commented 7 years ago

comment:54

once again:

you should not use xrange but range

you should use python3 syntax for print, namely print("stuff")

see patchbot report

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 8c7fd34 to 8ba9ddd

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`ae33d76`	`Merge branch 'public/16110' in 7.5.b5`
`8ba9ddd`	`trac 16110 cleanup of xrange, print, pep8`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`89b1f3d`	`Merge branch 'develop' into t/16110/public/16110`
`473cf1d`	`Improve documentation and rename some functions`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 8ba9ddd to 473cf1d

fchapoton commented 7 years ago

comment:59

see patchbot report for many problems (doc does not build, among others)

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

09a098b trac 16110 fixing the docbuild issue

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 473cf1d to 09a098b

sagemath / sage

Parallelogram Polyomino #16110