sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.37k stars 469 forks source link

FiniteStateMachine._latex_: more options, better documentation #16207

Closed cheuberg closed 10 years ago

cheuberg commented 10 years ago

Improved FiniteStateMachine._latex_:

Depends on #16132 Depends on #16145 Depends on #16146 Depends on #16200 Depends on #16205

CC: @dkrenn @sagetrac-skropf

Component: combinatorics

Author: Clemens Heuberger

Branch/Commit: e5a3191

Reviewer: Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/16207

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

fe9b380marked 3 doctests as indirect
92526f6Merge branch 'fsm/latex-initial-state-new' into fsm/latex-rotate-labels-new
0bd8c5aMerge branch 'fsm/latex-rotate-labels-new' #16205 into fsm/latex-improved
2438f93replaced range by srange
1e294f2replace \overline{-1} by \overline{1}
53a700cMoved FiniteStateMachine._latex_.accepting_where to finite_state_machine.tikz_automata_where
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from d6661e7 to 53a700c

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

2d43fddFiniteStateMachine: add failing doctests: non-hashable colors
547968aFiniteStateMachine.product_FiniteStateMachine, composition: fix unhashable colors
d51be51Automaton.determinisation(): docstring on hashable colors
c5dd860Merge branch 'fsm/state_color' into fsm/process_output_new
70294bftrac ticket number added
ed93dd3Minor changes during review.
3820c49corrected whitespaceerror
a14dd81Merge remote-tracking branch 'origin/u/dkrenn/ticket/16132' into fsm/process_output_new-on-beta8
afc15e5Replaced two raise ..., ... by raise ...(...) in the spirit of #15990
4aee511Merge ticket #16132 into #16207 in order to resolve merge conflict.
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 53a700c to 4aee511

cheuberg commented 10 years ago

Changed dependencies from #16146, #16200, #16205 to #16132, #16146, #16200, #16205

cheuberg commented 10 years ago
comment:4

Merged #16132, otherwise, this will not merge (commit 53a700c introduced a new module local variable at the same position where #16132 did the same).

cheuberg commented 10 years ago
comment:5

trac's automerge fails. Patch is based on 6.2.beta8, it merges cleanly with 6.2.rc0.

dkrenn commented 10 years ago

Reviewer: Daniel Krenn

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

a6a417dFiniteStateMachine._latex_: write final_word_out as "$ | output"
1f14955FiniteStateMachine._latex_: use tikz arrow style "latex"
56b1d48default accepting_distance=7ex because of $ in final output
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 4aee511 to 56b1d48

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

f13725dasymptotic_moments: add explanation on PolynomialRing vs SymbolicRing
878acffasymptotic_moments: replaced parameter verbose by sage.misc.misc.verbose
40da528Explanations for >1 final components, periodic final components
00e063easymptotic_moments: upgraded two tests to examples
1908a5dasymptotic_moments: unique initial states, all states are final
78997f5Corrected and improved version of commit 40da528
d56a769Rewrote asymptotic_moments to output en+Order(1) etc.
24b6d69explained the shifting in the Gray code-construction differently
0b1200dMerge branch 't/16143/fsm/example_gray_code' into fsm/asymptotic-moments
a0d894eMerge remote-tracking branch 'aau/fsm/asymptotic-moments' into fsm/latex-options-digits
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 56b1d48 to a0d894e

cheuberg commented 10 years ago

Changed dependencies from #16132, #16146, #16200, #16205 to #16132, #16145, #16146, #16200, #16205

cheuberg commented 10 years ago
comment:10

merged #16145 in order to avoid a merge conflict and listed #16145 as a dependency.

dkrenn commented 10 years ago

Changed branch from u/cheuberg/fsm/latex-improved to u/dkrenn/fsm/latex-improved

dkrenn commented 10 years ago
comment:12

finished my review; everything is fine; corrected one PEP8-spacing.


New commits:

e5a3191corrected one spacing (PEP8)
dkrenn commented 10 years ago

Changed commit from a0d894e to e5a3191

vbraun commented 10 years ago

Changed branch from u/dkrenn/fsm/latex-improved to e5a3191