search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.45k stars 482 forks source link

New MOLS shared by Ian Wanless #16241

Closed 6bdad4c1-1e26-4f2f-a442-a01a2292c181 closed 10 years ago

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 10 years ago

New MOLS shared by Ian Wanless !

We now have :

Still an infinite number ahead, but it's looking good :-P

follow up: #16236

Depends on #16235

CC: @videlec @brettpim @KPanComputes

Component: combinatorics

Keywords: design, mols

Author: Nathann Cohen

Branch/Commit: 67ab2d2

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/16241

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 10 years ago

Description changed:

--- 
+++ 
@@ -4,3 +4,5 @@
 - four MOLS of order 14
 - four MOLS of order 15
 - three MOLS of order 18
+
+Still an infinite number ahead, but it's looking good `:-P`
6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 10 years ago

Branch: u/ncohen/16241

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Commit: 4856ac2

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

4856ac2trac #16241: New MOLS shared by Ian Wanless
jdemeyer commented 10 years ago
comment:3

Just a small comment: perhaps it would be easier to use

"""
text text text
text text text
"""

instead of

"text text text " +
"text text text "
6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 10 years ago
comment:4

I will remember it for the next ones ! :-D

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 4856ac2 to e59d6cb

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

2d84806trac #16277: Merge with #16248
8b8aea8trac #16058: Organize the index of combinatorial modules
e0d2b66trac #16058: Two new categories
0293c49trac #16058: Another group
a14057bSome more groupings and separated root system types into separate list.
4b5cb2btrac #16058: Rebase on 6.2.rc0
5dbc42ftrac #16277: Merged with #16058
d4f445btrac #16277: MOLS constructions rom the Handbook of Combinatorial Designs
0f3a755trac #16235: A pair of orthogonal latin squares of order 10
e59d6cbtrac #16241: New MOLS shared by Ian Wanless
6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 10 years ago

Changed dependencies from #16231 to #16235

videlec commented 10 years ago
comment:7

Hi Nathann,

1) You forgot to add your functions in the head docstring.

2) Could you do appropriate doctests as in #16227? Especially check that the constructor work for these values.

3) There is a typo or an error in _MOLS_from_string. The characters belong to a-z and not 0-z... but, in prevision of bigger constructions it would be better to really start from 0 (which is chr(48)) and go up to z (which is chr(122)).

Vincent

videlec commented 10 years ago
comment:8

Ok, but they are less beautiful then

19876:420;=5<3  15<24=836970;:  123456789:;<=0  123456789:;<=0
52:917;438<06=  926=350;47:18<  6=:93<82;17045  95;7=:042<6381
<63;:210549=87  8:37046=<51;29  ;857194<:0=623  4<:39165=;8072
2=74<;31865:09  79;4185:0=62<3  30;<6=1947258:  0=867<5;:13249
43015=<:2976;8  61:<5294;8073=  =9204857136:<;  :412098<3657;=
=5482609;3:17<  :72;=6305<9814  <51:23;06=9874  26=5;4<1870:93
8065937=:<4;21  4;13<07586=:92  04<=7:932851;6  8;01:3=752946<
3;=:4058<72916  2401:9=873<65;  73=8:106<24;59  ;96=874210<53:
64<0;5879=13:2  03582;:<914=76  2695;7=184:30<  =3<01296;548:7
975=8<631:024;  ;84693<7=:2501  5:81<064=;3792  <17845;903:=26
7:1609=<42;835  =<957:4210;368  8<7;=42:350961  38592=:0<4761;
01;278:6=53<94  50=:61;9328<47  :;46053=79<218  672:<;1348=905
;82<31957064=:  <680;721:439=5  970382<;5614:=  509;683:7=21<4
:<93=42;618750  3=798<162;54:0  41629;:50<8=37  7:4<302=691;58

123456789:;<=>0  1368:=520<479;>  1740;8>5<3962=:  1;72<38=49>50:6
0123456789:;<=>  02479;>631=58:<  ;2851<906=4:73>  72<83=49>5:061;
>0123456789:;<=  =1358:<0742>69;  0<3962=:17>5;84  <83=94>5:06;172
=>0123456789:;<  <>2469;=185307:  51=4:73>;2806<9  3=94>:506;17<28
<=>0123456789:;  ;=0357:<>296418  :62>5;840<3917=  94>:50;617<28=3
;<=>0123456789:  9<>1468;=03:752  >;7306<951=4:28  4:50;61<728=39>
:;<=>0123456789  3:=02579<>14;86  90<8417=:62>5;3  05;61<72=839>4:
9:;<=>012345678  74;>1368:=025<9  4:1=9528>;7306<  ;16<72=83>94:05
89:;<=>01234567  :85<02479;>136=  =5;2>:6390<8417  6<27=83>940:5;1
789:;<=>0123456  >;96=1358:<0247  8>6<30;74:1=952  27=38>940:51;6<
6789:;<=>012345  80<:7>2469;=135  3907=41<85;2>:6  =38>490:51;62<7
56789:;<=>01234  691=;80357:<>24  74:18>52=96<30;  8>4905:1;62<73=
456789:;<=>0123  57:2><91468;=03  <85;29063>:7=41  >905:16;2<73=84
3456789:;<=>012  468;30=:2579<>1  2=96<3:1740;8>5  50:16;27<3=84>9
23456789:;<=>01  2579<41>;368:=0  63>:7=4;2851<90  :61;27<38=4>950

16497:<>32=0A8;?5@  14@?>3625;:A907=8<  123456789:;<=>?@A0
427518;=?A3>:09<@6  625A@?473=<;01:8>9  A1:0<56347@98=>?2;
@538629<>704?;:1=A  47360A@581>=<:2;9?  <;1@78560932A4=>?:
?A649731=08:5@<;2>  95847:0A6@2?>=;3<1  789123456@A0:;<=>?
>@0751842?:9;6A=<3  716958;:02A3@?><4=  634A1:0<5?2;7@98=>
3?A:862954@;1<70>=  :827169<;>304A@?=5  560<;1@78>?:932A4=
64@0;9731>5A<2=8:?  <;938271=6?4:50A@>  456789123=>?@A0:;<
275A:<184@?60=3>9;  >=<149382?7@5;6:0A  0<5634A1:8=>?2;7@9
53860;=29<A@7:>4?1  3?>=251490@8A6<7;:  @78560<;1A4=>?:932
;=1@2>6?0:<73A8549  2A70?4>@<:1683=95;  ;4@9?>=021:8356<7A
:<>2A3?7@1;=840965  =308:@5?A<;2794>16  :9<2A?>=7;1@405683
A;=?304@862<>95:17  0>4:9;A6@7=<3815?2  3@A8:;?>=0912<7564
90<>@4:5A873=?16;2  A:?5;1<0738>=4926@  =02;4@9?><7A1:8356
01:=?A5;63984>@27<  80;@6<2=:A49?>5137  >=7:9<2A?683;1@405
7:2;>@06<=4195?A38  ;9:<A7=3>8051@?624  ?>=3@A8:;5640912<7
=8;3<?A:79>5216@04  ?<1;=08>459:62A@73  9?>=02;4@356<7A1:8
8>9<4=@0;51?6327A:  5@=2<>:9?461;730A8  2A?>=7:9<405683;1@
<9?1=5>A:;62@74380  @6A>3=?;19572<84:0  8:;?>=3@A2<7564091
6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 10 years ago
comment:9

Yo !

1) You forgot to add your functions in the head docstring.

Right ! Fixed it.

2) Could you do appropriate doctests as in #16227? Especially check that the constructor work for these values.

I just did. I also did the same for the constructor included in #16235, but as I guess the two tickets will be merged at the same time...

3) There is a typo or an error in _MOLS_from_string. The characters belong to a-z and not 0-z... but, in prevision of bigger constructions it would be better to really start from 0 (which is chr(48)) and go up to z (which is chr(122)).

If someday it becomes useful, we will do that. This function is hidden, we can change it whenever we want.

Nathann

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from e59d6cb to e08b0be

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

e08b0betrac #16241: missing links and tests
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

d81f265trac #16272: ultimate doctest
47798d2trac #16272: simplifying the structure of orthogonal_array
490aa7etrac #16277: Reviewer's remarks
14420b6trac #16277: Yet another construction
ddda559trac #16277: Merged with updated #16272
7570b39trac #16277: From availability to existence and broken doctests
5e8b2aftrac #16277: removes a doctests that appears several times already
acf8988trac #16277: Merged with updated #16231
316b379trac #16235: Merged with updated #16277
fb26a1etrac #16241: Merged with updated #16235
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from e08b0be to fb26a1e

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 10 years ago
comment:12

Updated ...

videlec commented 10 years ago
comment:13

adding keywords...

videlec commented 10 years ago

Changed keywords from none to design, mols

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from fb26a1e to 7e77f90

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d34b012trac #16272: Merged with updated #16227
5cab81ctrac #16286: Allow k=None in MOLS/TD/OA
4970da4trac #16286: Merged with updated #16272
cb2e272trac #16235: Merged with updated #16286
1a13ff8trac #16241: New MOLS shared by Ian Wanless
2af2acftrac #16241: missing links and tests
7e77f90trac #16241: Broken doctests
videlec commented 10 years ago
comment:15

Needs to be updated above the positively reviewed #16235...

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

a97434ftrac #16286: more doc, more tests
aeab437trac #16235: merge the updated #16286
daa3835trac #16235: case n=1 + doc
31a53f2trac #16235: update the MOLS table
83b0d2ctrac #16241: Merged with updated #16235
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 7e77f90 to 83b0d2c

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

c212bf9trac #16241: Broken doctests
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 83b0d2c to c212bf9

videlec commented 10 years ago
comment:19

Hi Nathann,

In latin_squares.py, there was a useless

    elif n == 10 and k == 2:
        if existence:
            return True

        from database import MOLS_10_2
        matrices = MOLS_10_2()

that I removed (it is superseeded by the introduction of the 3 MOLS in this ticket). If you are happy with that, set it to positive review.

Vincent

New commits:

9fb0f62trac #16241: useless if condition in MOLS constructor
videlec commented 10 years ago

Changed branch from u/ncohen/16241 to public/16241

videlec commented 10 years ago

Changed commit from c212bf9 to 9fb0f62

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 10 years ago

Reviewer: Vincent Delecroix

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 10 years ago
comment:20

that I removed (it is superseeded by the introduction of the 3 MOLS in this ticket).

Oh right, the dictionary does the job now. Thanks ! ;-)

Nathann

videlec commented 10 years ago

Description changed:

--- 
+++ 
@@ -6,3 +6,5 @@
 - three MOLS of order 18

 Still an infinite number ahead, but it's looking good `:-P`
+
+follow up: #16236
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 9fb0f62 to 67ab2d2

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:

ddda559trac #16277: Merged with updated #16272
7570b39trac #16277: From availability to existence and broken doctests
5e8b2aftrac #16277: removes a doctests that appears several times already
acf8988trac #16277: Merged with updated #16231
485e880trac #16277: Merged with updated #16248
411a759trac #16286: Merged with updated #16277
11eff2ctrac #16235: Merged with 6.2
5a0e3fetrac #16235: Merged with #16231
c0b13c4trac #16235: Merged with updated #16286
67ab2d2trac #16241: Merged with updated #16235
vbraun commented 10 years ago

Changed branch from public/16241 to 67ab2d2