Closed malb closed 10 years ago
All doctest failures fixed except for
sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/rings/number_field/number_field.py
where I'm not immediately sure what to do.
New commits:
548d2e6 | fix magma(P) for P a multivariate polynomial ring |
566082b | fix various Magma doctest failures |
1938841 | Merge branch 'develop' of trac.sagemath.org:sage into magma |
46246fa | fix magma doctest failures |
Branch: u/malb/16322-magma-doctests
Dependencies: 16282
Changed dependencies from 16282 to #16282
These were the ones failing for me on bsd.math with vanilla Sage 6.2 (and --long --optional=magma,sage --all
, Magma V2.18-6):
----------------------------------------------------------------------
sage -t --long src/sage/interfaces/magma.py # 21 doctests failed
sage -t --long src/sage/matrix/benchmark.py # 26 doctests failed
sage -t --long src/sage/matrix/matrix1.pyx # 2 doctests failed
sage -t --long src/sage/rings/integer_ring.pyx # 1 doctest failed
sage -t --long src/sage/rings/quotient_ring.py # 1 doctest failed
sage -t --long src/sage/rings/quotient_ring_element.py # 2 doctests failed
sage -t --long src/sage/rings/number_field/number_field.py # 1 doctest failed
sage -t --long src/sage/rings/polynomial/multi_polynomial.pyx # 4 doctests failed
sage -t --long src/sage/rings/polynomial/multi_polynomial_ideal.py # 4 doctests failed
sage -t --long src/sage/rings/polynomial/multi_polynomial_ring_generic.pyx # 5 doctests failed
sage -t --long src/sage/rings/polynomial/multi_polynomial_sequence.py # 1 doctest failed
sage -t --long src/sage/rings/polynomial/pbori.pyx # 3 doctests failed
sage -t --long src/sage/rings/polynomial/polynomial_element.pyx # 1 doctest failed
sage -t --long src/sage/rings/polynomial/polynomial_rational_flint.pyx # 1 doctest failed
sage -t --long src/sage/rings/polynomial/term_order.py # 1 doctest failed
sage -t --long src/sage/symbolic/expression.pyx # 1 doctest failed
sage -t --long src/doc/en/bordeaux_2008/birds_other.rst # 3 doctests failed
----------------------------------------------------------------------
P.S.: Sorry, I only later noticed the purpose of #16282 was not to fix all Magma doctests; I somehow completely misread the ticket and/or your post to sage-devel (presumably due to the Gmane outage ;-) )...
Branch pushed to git repo; I updated commit sha1. New commits:
1b5d36d | magma error reporting changed |
these are all resolved except for the Galois group thing mentioned above (I fixed one more issue where newer versions of Magma report errors slightly different from older versions)
anyone up for reviewing tis?
Reviewer: Volker Braun
Maybe you want to set the ticket to "needs review" first? Is it?
Changed branch from u/malb/16322-magma-doctests to 1b5d36d
These doctests currently fail:
Depends on #16282
Upstream: None of the above - read trac for reasoning.
CC: @nexttime
Component: PLEASE CHANGE
Keywords: magma
Author: Martin Albrecht
Branch/Commit:
1b5d36d
Reviewer: Volker Braun
Issue created by migration from https://trac.sagemath.org/ticket/16322