FSMState.__copy__: copy color

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.44k stars 479 forks source link

FSMState.copy: copy color #16589

Closed cheuberg closed 10 years ago

cheuberg commented 10 years ago

In contrast to FSMState.__deepcopy__, FSMState.__copy__ omitted copying the attribute color. This is now fixed.

Depends on #16191

CC: @sagetrac-skropf @dkrenn

Component: finite state machines

Author: Clemens Heuberger

Branch/Commit: 53b732e

Reviewer: Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/16589

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 81d8722 to 53b732e

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`bcf3308`	`Transducer.asymptotic_moments only accepts transducers with all states final and transducers.GrayCode is now such a transducer.`
`8d29348`	`Correct TeX errors (raw string vs. string) in docstring (Gray Code)`
`ae8ec6b`	`Modified a few docstrings to reflect use of final output word`
`4927542`	`removed determine_alphabets=True from docstrings because it is the default anyway`
`ba07d56`	`Use iterators instead of lists`
`0be171e`	`Added examples for FiniteStateMachine.equivalence_classes`
`95414f5`	NotImplementedError in `_composition_explorative_` if there are final word outs
`c3f2b33`	`corrected spacing`
`d1f3e21`	`trac #16191: Reviewer Patch: Move one example; spacing; typo; punctuation`
`53b732e`	`Merge remote-tracking branch 'aau/fsm/final-word-out-problems' into fsm/copy-state-color-final-word-out`

cheuberg commented 10 years ago

Last 10 new commits:

`bcf3308`	`Transducer.asymptotic_moments only accepts transducers with all states final and transducers.GrayCode is now such a transducer.`
`8d29348`	`Correct TeX errors (raw string vs. string) in docstring (Gray Code)`
`ae8ec6b`	`Modified a few docstrings to reflect use of final output word`
`4927542`	`removed determine_alphabets=True from docstrings because it is the default anyway`
`ba07d56`	`Use iterators instead of lists`
`0be171e`	`Added examples for FiniteStateMachine.equivalence_classes`
`95414f5`	NotImplementedError in `_composition_explorative_` if there are final word outs
`c3f2b33`	`corrected spacing`
`d1f3e21`	`trac #16191: Reviewer Patch: Move one example; spacing; typo; punctuation`
`53b732e`	`Merge remote-tracking branch 'aau/fsm/final-word-out-problems' into fsm/copy-state-color-final-word-out`

cheuberg commented 10 years ago

Dependencies: #16191

cheuberg commented 10 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-In contrast to `FSMState.__deepcopy__`, `FSMState.__copy__` omitted copying the attributes `final_word_out` and `color`. This is now fixed.
+In contrast to `FSMState.__deepcopy__`, `FSMState.__copy__` omitted copying the attribute `color`. This is now fixed.

dkrenn commented 10 years ago

comment:4

Patch is fine; tests passed.

dkrenn commented 10 years ago

Reviewer: Daniel Krenn

vbraun commented 10 years ago

Changed branch from u/cheuberg/fsm/copy-state-color-final-word-out to 53b732e

sagemath / sage

FSMState.__copy__: copy color #16589

FSMState.copy: copy color #16589