Add optional Arb package (arbitrary-precision floating-point ball arithmetic)

f4820faf-0a31-4be3-90f9-397707d64fc5 commented 10 years ago

Add Arb http://fredrikj.net/arb/ as an optional/experimental package. Source code here: https://www.math.aau.at/user/cheuberg/sage/arb-2.3.0.tar.gz (This is a renamed version of the original tarball at https://github.com/fredrik-johansson/arb/archive/2.3.0.tar.gz, see the comment by jdemeyer)

CC: @sagetrac-alina @fredrik-johansson @mezzarobba

Component: packages: optional

Keywords: arb, optional package. interval field

Author: Karen Kohl, Laura Peskin, Clemens Heuberger

Branch/Commit: ec0aae9

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/16747

f4820faf-0a31-4be3-90f9-397707d64fc5 commented 10 years ago

Changed author from ktkohl to ktkohl, lpeskin

f4820faf-0a31-4be3-90f9-397707d64fc5 commented 10 years ago

Branch: u/ktkohl/ticket/16747

f4820faf-0a31-4be3-90f9-397707d64fc5 commented 10 years ago

Commit: a2c8861

f4820faf-0a31-4be3-90f9-397707d64fc5 commented 10 years ago

comment:4

How do I get the arb-2.2.tar.bz2 to be part of the commit?

New commits:

a2c8861 Sage install files for Arb 2.2

cheuberg commented 10 years ago

Changed branch from u/ktkohl/ticket/16747 to u/cheuberg/ticket/16747

cheuberg commented 10 years ago

comment:6

I modified the patch:

use the .tar.gz file from github with version number instead of unversioned .zip file
use Sage's versions of flint, mpfr, gmp in building the package (if there is no version of one of those in the system paths, then the optional package won't compile).
Set package version to 2.2.0 to match the name of the top level directory of the .tar.gz file so that no renaming to src is necessary.

In that version, it compiles for me.

Are you planning to provide and include python bindings for the library?

New commits:

`a2c8861`	`Sage install files for Arb 2.2`
`40eccd8`	`Use Sage's flint, mpfr, gmp instead of possibly locally installed versions`
`c66113f`	`Use .tar.gz file from github, Version is 2.2.0, then no rename to src is necessary.`

cheuberg commented 10 years ago

Changed commit from a2c8861 to c66113f

cheuberg commented 10 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 Add Arb [http://fredrikj.net/arb/](http://fredrikj.net/arb/) as an optional/experimental package.
-Source code here:  [https://github.com/fredrik-johansson/arb/archive/master.zip](https://github.com/fredrik-johansson/arb/archive/master.zip)
+Source code here:  [https://github.com/fredrik-johansson/arb/archive/2.2.0.tar.gz](https://github.com/fredrik-johansson/arb/archive/2.2.0.tar.gz)

cheuberg commented 10 years ago

comment:8

Replying to @sagetrac-ktkohl:

How do I get the arb-2.2.tar.bz2 to be part of the commit?

In the developer guide, it says "If all went fine, open a ticket, put a link to the original tarball in the ticket and upload a branch with the code under SAGE_ROOT/build/pkgs." So IMHO, there is nothing else to do.

fredrik-johansson commented 10 years ago

comment:9

I recently updated the makefile in Arb (requires a git checkout). This might solve some potential build issues with the 2.2 release.

cheuberg commented 10 years ago

comment:10

Replying to @fredrik-johansson:

I recently updated the makefile in Arb (requires a git checkout). This might solve some potential build issues with the 2.2 release.

For the sage spkg, it would probably be easier to have a release on github with that change.

@original authors: is there a reason why the status of this patch is not "needs_review"? I'd also like to renew my question on whether you plan to provide python bindings.

fredrik-johansson commented 10 years ago

comment:11

I will make a new release soon.

I've also just added methods arb_get_interval_mpfr/arb_set_interval_mpfr which should simplify conversion to/from Sage's RIF and CIF.

fredrik-johansson commented 10 years ago

comment:12

https://github.com/fredrik-johansson/arb/archive/2.3.0.tar.gz is available

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from c66113f to f2c5b0b

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

f2c5b0b Trac #16747: Update arb to version 2.3.0

cheuberg commented 10 years ago

comment:14

Updated to version 2.3.0; replaced usernames of original ticket authors by their full names as given by SPKG.txt.

cheuberg commented 10 years ago

Changed author from ktkohl, lpeskin to Karen Kohl, Laura Peskin, Clemens Heuberger

cheuberg commented 10 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 Add Arb [http://fredrikj.net/arb/](http://fredrikj.net/arb/) as an optional/experimental package.
-Source code here:  [https://github.com/fredrik-johansson/arb/archive/2.2.0.tar.gz](https://github.com/fredrik-johansson/arb/archive/2.2.0.tar.gz)
+Source code here:  [https://github.com/fredrik-johansson/arb/archive/2.3.0.tar.gz](https://github.com/fredrik-johansson/arb/archive/2.3.0.tar.gz)

cheuberg commented 10 years ago

Changed keywords from none to arb, optional package. interval field

jdemeyer commented 10 years ago

comment:15

The tarball name is too strange: it should contain the package name (arb-2.3.0.tar.gz)

jdemeyer commented 10 years ago

comment:16

Is the -j1 needed for $MAKE install?

jdemeyer commented 10 years ago

comment:17

Try to avoid long lines like

Arb is a C library for arbitrary-precision floating-point ball arithmetic, developed by Fredrik Johansson (fredrik.johansson@gmail.com). It supports efficient high-precision computation with polynomials, power series, matrices and special functions over the real and complex numbers, with automatic, rigorous error control.

vbraun commented 10 years ago

comment:18

We most likely really need the --libdir="$SAGE_LOCAL/lib". Some systems have hacked lt to install libraries in strange locations by default.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from f2c5b0b to 7487164

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`f3f169d`	`Trac #16747: Wrap long lines`
`f3ffd68`	`Trac #16747: remove "-j1" from make install`
`7487164`	`Trac #16747: remove --libdir`

cheuberg commented 10 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,4 @@
 Add Arb [http://fredrikj.net/arb/](http://fredrikj.net/arb/) as an optional/experimental package.
-Source code here:  [https://github.com/fredrik-johansson/arb/archive/2.3.0.tar.gz](https://github.com/fredrik-johansson/arb/archive/2.3.0.tar.gz)
+Source code here:  [https://www.math.aau.at/user/cheuberg/sage/arb-2.3.0.tar.gz](https://www.math.aau.at/user/cheuberg/sage/arb-2.3.0.tar.gz)
+(This is a renamed version of the original tarball at [https://github.com/fredrik-johansson/arb/archive/2.3.0.tar.gz](https://github.com/fredrik-johansson/arb/archive/2.3.0.tar.gz), see the comment by [jdemeyer](#comment%3A15))

cheuberg commented 10 years ago

comment:20

Replying to @jdemeyer:

The tarball name is too strange: it should contain the package name (arb-2.3.0.tar.gz)

I cannot change the original name on github, therefore I downloaded a copy, renamed the tarball and placed it in my own webspace, see the modified description of the ticket.

cheuberg commented 10 years ago

comment:21

Replying to @jdemeyer:

Is the -j1 needed for $MAKE install?

IMHO it is not needed and removing it should not have any effects (the only dependency of make install is the library which should have been compiled in parallel before; then make install creates two directories and copies a few files into these directories, but these steps would not be run in parallel, anyway). So -j1 is removed in commit f3ffd68.

cheuberg commented 10 years ago

comment:22

Replying to @jdemeyer:

Try to avoid long lines

done in commit f3f169d.

cheuberg commented 10 years ago

comment:23

Replying to @vbraun:

We most likely really need the --libdir="$SAGE_LOCAL/lib". Some systems have hacked lt to install libraries in strange locations by default.

The .configure script of arb does not support the option --libdir. Its Makefile.in uses $(DESTDIR)$(PREFIX)/lib (and $(DESTDIR)$(PREFIX)/include) as targets when installing the library. Therefore, commit 7487164 removes --libdir (previously commented out).

vbraun commented 10 years ago

comment:24

Argh, no autotools/libtool :-(

cheuberg commented 10 years ago

comment:25

Rather minimal python bindings are now in #17194

cheuberg commented 10 years ago

comment:27

See discussion on sage-devel concerning the section SPKG Maintainers.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

ec0aae9 Trac #16747: Remove SPKG Maintainers section

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 7487164 to ec0aae9

jdemeyer commented 10 years ago

Reviewer: Jeroen Demeyer

vbraun commented 9 years ago

Changed branch from u/cheuberg/ticket/16747 to ec0aae9

sagemath / sage

Add optional Arb package (arbitrary-precision floating-point ball arithmetic) #16747