twin prime difference sets

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.35k stars 462 forks source link

twin prime difference sets #16863

Closed videlec closed 10 years ago

videlec commented 10 years ago

Some new difference set (not very visible... but still new BIBD in perspective).

Depends on #16802

CC: @nathanncohen

Component: combinatorial designs

Author: Vincent Delecroix

Branch/Commit: 5903ac6

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/16863

videlec commented 10 years ago

Commit: 33b4171

videlec commented 10 years ago

Last 10 new commits:

`b9aa228`	`trac #16722: OA(17,560)`
`9a57f13`	`trac #16757: Organize the V(m,t) vectors into a dictionary`
`57c00f0`	`trac #16757: doctest simplication`
`424e229`	`trac #16763: New OA for n=189, plus some others through Vmt vectors`
`5ba165e`	`trac #16763: Complete bibliographical references`
`f3f644d`	`trac #16763: code simplification`
`04936aa`	`trac #16802: database of difference family`
`4bd8d69`	`trac #16802: Review`
`4434d61`	`trac #16802: review the review`
`33b4171`	`trac #16863: twin prime difference set`

videlec commented 10 years ago

Branch: u/vdelecroix/16863

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 10 years ago

comment:2

Hellloooooooooo !!

Here is a commit (at public/16863) that also handles prime powers (not just primes) as the wikipedia source claims.

What it does:

Change the doctests to test all new cases (also a bit faster than the previous doctest)
rename fact to factorization
Add a reference toward wikipedia
Use [x**2 for x in SET] to compute the list of squares.

Your turn !

Nathann

videlec commented 10 years ago

comment:3

Thanks for the modif!

I changed one sentence in the comments and used a "set version" of the fields in the code (see the last commit).

Needs review again...

Vincent

New commits:

`acd60a2`	`trac #16863: Handle all prime powers (not just primes)`
`5903ac6`	`trac #16863: doc and simplification`

videlec commented 10 years ago

Changed branch from u/vdelecroix/16863 to public/16863

videlec commented 10 years ago

Changed commit from 33b4171 to 5903ac6

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 10 years ago

comment:4

That's all good !

Nathann

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 10 years ago

Reviewer: Nathann Cohen

videlec commented 10 years ago

comment:5

Cool! Thanks!

Vincent

vbraun commented 10 years ago

Changed branch from public/16863 to 5903ac6