search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.23k stars 430 forks source link

Make buckygen a standard package #16952

Closed nvcleemp closed 9 years ago

nvcleemp commented 9 years ago

Buckygen has been an optional package since May 2013. It has a minimal footprint: just installs one executable that is quite small and compiles quickly. It is the fastest generator for fullerenes and it is GPLv3.

Depends on #16945

Component: packages: standard

Author: Nico Van Cleemput

Branch/Commit: u/nvcleemp/buckygen-standard @ 20a1dd7

Issue created by migration from https://trac.sagemath.org/ticket/16952

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

1161342Made buckygen a standard package
20a1dd7Buckygen is no longer an optional package
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Commit: 20a1dd7

nvcleemp commented 9 years ago
comment:2

I'm not entirely sure these commits are sufficient to make it a standard package, but please enlighten me if there are additional changes needed.

jdemeyer commented 9 years ago
comment:4

Nico, making a package standard should be discussed on sage-devel. And to be honest, I think your package is much too specialized to be standard.

vbraun commented 9 years ago
comment:5

I somewhat agree with Jeroen, the reason for having a set of standard packages is also that other parts of Sage can build on it. Its certainly interesting in its own way, but its not really interconnected with the rest to always compile it. Though we do have a few standard packages that fit that description, too... (e.g. rubiks).

On a legal note, standard packages must be at GPLv3+ compatible (including the or later). Just GPLv3 is not OK. Its fine for optional packages, though.

jdemeyer commented 9 years ago
comment:6

Replying to @vbraun:

Though we do have a few standard packages that fit that description, too... (e.g. rubiks).

Yes, William once said that package was included for historical reasons. Today it probably wouldn't be added as standard package.

On a legal note, standard packages must be at GPLv3+ compatible (including the or later). Just GPLv3 is not OK. Its fine for optional packages, though.

Really? zn_poly has:

zn_poly: a library for polynomial arithmetic (version 0.9)

Copyright (C) 2007, 2008, David Harvey

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) version 3 of the License.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License,
along with this program (see gpl-2.0.txt and gpl-3.0.txt). If not,
see <http://www.gnu.org/licenses/>.
vbraun commented 9 years ago
comment:7

For the zn_poly license see https://groups.google.com/forum/#!msg/sage-devel/-4lMV0n8B3c/3eEWqi4100wJ

nvcleemp commented 9 years ago
comment:8

OK, no problem. The package works fine as an optional package. I just thought that this was the 'natural' evulotion. If specialised packages stay optional, then I'm not going to argue with that.

I wanted to close the ticket, but apparently I can't. I have removed the needs_review status in any case.

nvcleemp commented 9 years ago
comment:9

Replying to @vbraun:

On a legal note, standard packages must be at GPLv3+ compatible (including the or later). Just GPLv3 is not OK. Its fine for optional packages, though.

btw, Buckygen is actually GPLv3+.