search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 480 forks source link

Upgrade PARI to git master #16997

Closed jdemeyer closed 9 years ago

jdemeyer commented 10 years ago

Alternative: #16939

Upstream: http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1315-g031c9d6.tar.gz

Depends on #16976

CC: @pjbruin @kiwifb

Component: packages: standard

Author: Jeroen Demeyer

Branch: 451fb95

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/16997

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from db7dbd6 to ff7c17f

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ff7c17fUpgrade to PARI git master
jdemeyer commented 9 years ago

Changed dependencies from #15808 to #17028

jdemeyer commented 9 years ago

Changed dependencies from #17028 to none

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5e8d984Upgrade to PARI git master
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from ff7c17f to 5e8d984

jdemeyer commented 9 years ago

Dependencies: #15808

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b2597a7Upgrade to PARI git master
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 5e8d984 to b2597a7

jdemeyer commented 9 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 Alternative: #16939

-**Upstream**: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-901-gabdbd16.tar.gz](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-901-gabdbd16.tar.gz)
+**Upstream**: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1081-g2ee507e.tar.gz](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1081-g2ee507e.tar.gz)
jdemeyer commented 9 years ago

Changed dependencies from #15808 to #17623

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from b2597a7 to bb12f77

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a13b116Fix PI declaration in complex_plot.pyx
bb12f77Upgrade to PARI git master
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7528799Upgrade to PARI git master
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from bb12f77 to 7528799

jdemeyer commented 9 years ago

Changed dependencies from #17623 to #17623, #14894

jdemeyer commented 9 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 Alternative: #16939

-**Upstream**: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1081-g2ee507e.tar.gz](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1081-g2ee507e.tar.gz)
+**Upstream**: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1107-gc232fca.tar.gz](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1107-gc232fca.tar.gz)
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 7528799 to 5cd1f00

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0602271Use cb_pari_err_handle() to handle PARI errors
fbd37a0Merge commit 'a13b11636e7cb6b0f5c066b6d7784361fa68091d' into HEAD
5cd1f00Upgrade PARI to git master
jdemeyer commented 9 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 Alternative: #16939

-**Upstream**: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1107-gc232fca.tar.gz](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1107-gc232fca.tar.gz)
+**Upstream**: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1232-g0144d74.tar.gz](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1232-g0144d74.tar.gz)
jdemeyer commented 9 years ago

Changed dependencies from #17623, #14894 to none

jdemeyer commented 9 years ago

Dependencies: #17588

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0fa866cTrac #17588: Remove darwin specific install instruction that are counterproductive.
b8004f7Upgrade PARI to git master
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 5cd1f00 to b8004f7

videlec commented 9 years ago
comment:51

Do we change the package name to sage-pari as it was discussed on sage-devel?

kiwifb commented 9 years ago
comment:52

After my long rant (and mostly getting stuff out of my chest) I no longer think it is necessary. Let me explain:

I did some homework on the last point in Gentoo I am not sure what it would hold for debian but I am willing to bet it will be about the same.

jdemeyer commented 9 years ago
comment:53

By the way: if somebody actually feels like reviewing this, let me know. Then I will update the branch.

kiwifb commented 9 years ago
comment:54

I'll need a little bit of time to get over all the dependency but once I get there I may review this. One question however: is the new patch public_memory_functions.patch something waiting for inclusion upstream? As of this morning it would probably still apply (I now have a live ebuild for pari and this morning master is not broken, not like 2 days ago).

jdemeyer commented 9 years ago
comment:55

Replying to @kiwifb:

One question however: is the new patch public_memory_functions.patch something waiting for inclusion upstream?

Consider this a "transient" patch. PARI upstream has changed their stack-handling in a non-backwards-compatible way. This patch public_memory_functions.patch is what's needed to use the current Sage hooks for dealing with the PARI stack. A follow-up ticket could use the new PARI stack mechanism.

jdemeyer commented 9 years ago
comment:56

Replying to @kiwifb:

I'll need a little bit of time to get over all the dependency

What does "get over all the dependency" mean???

jdemeyer commented 9 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 Alternative: #16939

-**Upstream**: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1232-g0144d74.tar.gz](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1232-g0144d74.tar.gz)
+**Upstream**: [http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1315-g031c9d6.tar.gz](http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.8-1315-g031c9d6.tar.gz)
kiwifb commented 9 years ago
comment:58

To be honest I thought there would be more package depending on pari and that more would be impacted. But apart from sage itself that's just lcalc. If we are looking at optional package there may be MaCaulay2.

jdemeyer commented 9 years ago
comment:59

eclib also depends on pari.

kiwifb commented 9 years ago
comment:60

Replying to @jdemeyer:

eclib also depends on pari.

And I noticed that the extent of your fix is adding the standard patching code in spkg-install. I can do some more checking with it but I can believe eclib will be unaffected since John already did a fix for pari 2.8 https://github.com/JohnCremona/eclib/commit/652337883464b277f52901c7bcaf9c71001e0c3c

kiwifb commented 9 years ago
comment:61

And if we want to be complete sympow depends on pari but only through gp.

jdemeyer commented 9 years ago
comment:62

Replying to @kiwifb:

Replying to @jdemeyer:

eclib also depends on pari.

And I noticed that the extent of your fix is adding the standard patching code in spkg-install. I can do some more checking with it but I can believe eclib will be unaffected since John already did a fix for pari 2.8

Yes, I know. In an earlier version of this branch, I had to explicitly add a patch and the "patching loop" in spkg-install. I left the patching loop since it makes sense anyway to have it.

I am currently in the process of upgrading this branch to the latest PARI.

kiwifb commented 9 years ago
comment:63

Can you put an spkg-src this time? "make snapshot" is not enough to reproduce a given tarball, we should know the precise commit at which you snapshot.

jdemeyer commented 9 years ago
comment:64

Replying to @kiwifb:

"make snapshot" is not enough to reproduce a given tarball, we should know the precise commit at which you snapshot.

The commit is in build/pkgs/pari/package-version.txt, is that not sufficient?

kiwifb commented 9 years ago
comment:65

Replying to @jdemeyer:

Replying to @kiwifb:

"make snapshot" is not enough to reproduce a given tarball, we should know the precise commit at which you snapshot.

The commit is in build/pkgs/pari/package-version.txt, is that not sufficient?

I guess it is. I am too lazy ;)

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from b8004f7 to ade4f75

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ade4f75Upgrade PARI to git master
jdemeyer commented 9 years ago
comment:68

Replying to @kiwifb:

And if we want to be complete sympow depends on pari but only through gp.

I didn't know that, but you're right.

kiwifb commented 9 years ago
comment:69

OK now I am starting tests. A technical question about upstream's intention. The current soname for pari 2.7 is libpari-gmp.so.4 the one from git master is libpari-gmp-2.8.so.0 do you know if it is temporary until 2.8 is released (and switch to something like libpari-gmp.so.5) or it is their plan to stick with that soname?

kiwifb commented 9 years ago
comment:70

I think I found the answer to my own question in config directory. They have a different scheme for even numbered release on purpose. Which makes life hard for automated rebuilding in gentoo. I'll have to force things there.

kiwifb commented 9 years ago

Reviewer: François Bissey

kiwifb commented 9 years ago
comment:71

OK passes a few sanity checks so this is ready for bot testing.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from ade4f75 to b41dd91

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

b41dd91Fix 32-bit doctest
vbraun commented 9 years ago
comment:74

I also get on some buildbots:

sage -t --long src/sage/modular/modform_hecketriangle/hecke_triangle_group_element.py
**********************************************************************
File "src/sage/modular/modform_hecketriangle/hecke_triangle_group_element.py", line 38, in sage.modular.modform_hecketriangle.hecke_triangle_group_element.coerce_AA
Failed example:
    AA(p)._exact_field()
Expected:
    Number Field in a with defining polynomial y^16 + ... with a in ...
Got:
    Number Field in a with defining polynomial y^16 - 1312*y^14 + 864612*y^12 - 2512720*y^11 - 50780668*y^10 + 360028808*y^9 - 48779642409*y^8 + 290398268512*y^7 + 15186503722504*y^6 - 566858046818416*y^5 + 27431234189939174*y^4 - 226711842252026288*y^3 + 7395502353944441460*y^2 - 39603059247494358200*y + 911555406262192128578 with a in -25.34269035681775? - 10.68732885060488?*I
**********************************************************************
1 item had failures:
   1 of   5 in sage.modular.modform_hecketriangle.hecke_triangle_group_element.coerce_AA
    [709 tests, 1 failure, 115.89 s]

and

sage -t --long src/sage/lfunctions/dokchitser.py
**********************************************************************
File "src/sage/lfunctions/dokchitser.py", line 127, in sage.lfunctions.dokchitser.Dokchitser
Failed example:
    L.taylor_series(1,4)
Expected:
    2.90614059330736e-20 + (-1.64690098288532e-20)*z + 0.759316500288427*z^2 - 0.430302337583362*z^3 + O(z^4)  
Got:
    -1.15498883731660e-19 + (6.54528640417060e-20)*z + 0.759316500288427*z^2 - 0.430302337583362*z^3 + O(z^4)
**********************************************************************
jdemeyer commented 9 years ago
comment:75

The first one is because of interaction with #16976.