search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.45k stars 481 forks source link

Half-integral dimensions #17093

Open nsirolli opened 10 years ago

nsirolli commented 10 years ago

Added functionality for computing the dimensions of the spaces of modular (cusp) forms of half-integral weights, using the formulas given by Cohen-Oesterle and Serre-Stark.

Component: modular forms

Author: Nicolás Sirolli

Branch/Commit: public/ticket/17093 @ c63281f

Reviewer: Michael Neururer

Issue created by migration from https://trac.sagemath.org/ticket/17093

nsirolli commented 10 years ago

Branch: u/nmsirolli/half_integral_dimensions

nsirolli commented 10 years ago

Last 10 new commits:

c6d8d3bEstá todo mal?
0656c17Missing documentation, testing...
e13a7d9Added examples... but still not working.
0c5688bNeeds work...
2ecd8b5Doctest fails...
2be80fdFixed the integral case... still has bugs in the half-integral
ed4dd0dAdded documentation for is_totally_even
6930c58Done!
7827d2cAdded doctest for CohenOesterle
e3950edFinal version!
nsirolli commented 10 years ago

Author: Nicolás Sirolli

nsirolli commented 10 years ago

Changed branch from u/nmsirolli/half_integral_dimensions to u/nmsirolli/half_dims

nsirolli commented 10 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-
+Added functionality for computing the dimensions of modular forms of half-integral weights, using the formulas given by Cohen-Oesterle and Serre-Stark.
nsirolli commented 10 years ago

Commit: e3950ed

nsirolli commented 10 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-Added functionality for computing the dimensions of modular forms of half-integral weights, using the formulas given by Cohen-Oesterle and Serre-Stark.
+Added functionality for computing the dimensions of the spaces of modular (cusp) forms of half-integral weights, using the formulas given by Cohen-Oesterle and Serre-Stark.
772eb0ba-56d7-4c8f-804e-4425c61209f3 commented 10 years ago

Reviewer: Michael Neururer

vbraun commented 10 years ago
comment:6

docbuild fails with

[arithgrou] 'ascii' codec can't decode byte 0xc3 in position 18458: ordinal not in range(128)
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

00519bfFixed problem with non-ascii character in congroup_gamma1.py.
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from e3950ed to 00519bf

vbraun commented 10 years ago
comment:9

You should add # -*- coding: utf-8 -*- as the first line of the Python file, then you can use any utf-8 in docstrings.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 00519bf to d72d3b7

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

d72d3b7Switched back to utf-8, following vbraun's advice.
vbraun commented 10 years ago
comment:12

Completely breaks src/sage/modular/ssmod/ssmod.py, possibly other stuff. Run the testsuite...

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

8cf8808Fixed error about dimensions for Gamma0; added doctesting for that.
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from d72d3b7 to 8cf8808

nsirolli commented 10 years ago
comment:14

Sorry about that.

There was an error in arithgroup_generic.py, where the weight needed to be coerced into ZZ to make expressions like 'k // ZZ(4)' work properly. Now this is fixed.

I added doctesting for computing dimensions for Gamma0 in arithgroup_generic.py.

Now running sage -testall yields no errors.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

4f6bf15Merging with the recently released Sage 6.4
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 8cf8808 to 4f6bf15

fchapoton commented 9 years ago
comment:17

needs rebase, branch does not apply

fchapoton commented 9 years ago

Changed commit from 4f6bf15 to da60ad2

fchapoton commented 9 years ago
comment:18

I have done the rebase, hopfully in a correct way.

New commits:

da60ad2Merge branch 'u/nmsirolli/half_dims' into 6.9.b6
fchapoton commented 9 years ago

Changed branch from u/nmsirolli/half_dims to public/ticket/17093

fchapoton commented 9 years ago
comment:21

ping !

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from da60ad2 to 56827c3

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

56827c3Merge branch 'public/ticket/17093' into 7.1.b0
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 56827c3 to 7b01ff9

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

7b01ff9Merge branch 'public/ticket/17093' into 7.1.b3
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 7b01ff9 to 3896fac

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

3896factrac #17093 undo wrong move
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

9c0f9daMerge branch 'public/ticket/17093' in 7.3.b9
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 3896fac to 9c0f9da

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

730ac48Merge branch 'public/ticket/17093' in 7.5.b1
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 9c0f9da to 730ac48

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

c52cddctrac #17094 details about : ::
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 730ac48 to c52cddc

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

bdb20a2Merge branch 'public/ticket/17093' in 7.6.rc1
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from c52cddc to bdb20a2

fchapoton commented 7 years ago
comment:30

ping ?

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

3de6331Merge branch 'public/ticket/17093' in 8.0.b5
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from bdb20a2 to 3de6331

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

7f83f79Merge branch 'public/ticket/17093' in 8.1.rc0
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 3de6331 to 7f83f79

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 7f83f79 to 411af56

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

411af56Merge branch 'public/ticket/17093' in 8.3.b2
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 411af56 to 7ff8e7f

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

7ff8e7fMerge branch 'public/ticket/17093' in 8.4.b0
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 7ff8e7f to 370a2b4

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

872916eMerge branch 'public/ticket/17093' in 8.7.b7
370a2b4fix pyflakes warnings