Closed videlec closed 9 years ago
Branch: u/vdelecroix/17099
I looked at Vincent's patch and tested it on my own machine. It definitely fixes the issue and the new doctest passes. However, buildbot reports doctest failures in other modules (including ones almost certainly unconnected with the quaternion algebra code, like "src/sage/rings/real_double.pyx"). Am I allowed to move the status to "positive review" in this situation?
Ok, of the five doctests that failed on buildbot, on my machine two fail in what Vincent branched from (sr.py and pbori.py) and the other three (polynomial_element.pyx, modform/numerical.py, and real_double.pyx) pass both before and after. I think this looks good, so moving to positive review.
Thanks Nathan! The buildbot has some trouble... (there is a thread about that on sage devel)
Vincent
Reviewer: Nathan Dunfield
Yeah, I saw that thread, which is another reason I when ahead to "positive review"...
Changed branch from u/vdelecroix/17099 to 5497084
In this sage devel thread was mentioned the following bug
CC: @NathanDunfield @williamstein
Component: algebra
Author: Vincent Delecroix
Branch/Commit:
5497084
Reviewer: Nathan Dunfield
Issue created by migration from https://trac.sagemath.org/ticket/17099