vbraun commented 9 years ago

Upstream tarball: https://pypi.python.org/packages/source/i/ipython/ipython-3.0.0.tar.gz

Depends on #17234 Depends on #17833 Depends on #17288 Depends on #17897

CC: @kiwifb @jasongrout

Component: packages: standard

Author: Volker Braun

Branch/Commit: e070dd1

Reviewer: R. Andrew Ohana

Issue created by migration from https://trac.sagemath.org/ticket/17826

vbraun commented 9 years ago

Dependencies: #17833

vbraun commented 9 years ago

Branch: u/vbraun/update_to_ipython_3_0

vbraun commented 9 years ago

Commit: a95ad5f

vbraun commented 9 years ago

comment:4

All doctests pass with IPython 3.0.0rc1 but the IPython notebook now depends on the newer tornado

New commits:

`7747261`	`Rich output framework`
`7dc42d9`	`More documentation`
`2d915f0`	`Fix Andrews comments`
`be577ff`	`Rename Lightwave -> Wavefront obj`
`af73513`	`Fix saving 3d preview image without java`
`f5b31e4`	`Rename mathjax -> latex in rich output types`
`82b4bc1`	`use the plot3d viewer keyword`
`b1ee9ec`	`Merge #17234: Rich output and the IPython Notebook`
`c09d7b0`	`Update ipython to 3.0.0rc1`
`a95ad5f`	`Restore old behavior of get_test_shell().run_cell`

vbraun commented 9 years ago

Author: Volker Braun

vbraun commented 9 years ago

Changed dependencies from #17833 to #17234, #17833

vbraun commented 9 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-
+Everything works with the 3.0.0rc1, to be continued when IPython 3 is finally out...

vbraun commented 9 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-Everything works with the 3.0.0rc1, to be continued when IPython 3 is finally out...
+Upstream tarball: https://pypi.python.org/packages/source/i/ipython/ipython-3.0.0.tar.gz

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from a95ad5f to f11c447

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

f11c447 Update to IPython 3.0.0

vbraun commented 9 years ago

comment:10

the sage ipython notebook needs some work...

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from f11c447 to 706573c

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`cc9a5af`	`Normalize plot data (like texture opacity) to float`
`37ae94a`	`Mark all animations that require ImageMagick as #optional`
`29853da`	`fix remaining doctest failures`
`57469c6`	`correct file permissions`
`6c6becd`	`mark more animation doctess as optional ImageMagick`
`38c6db0`	`Fix ascii art in the IPython notebook`
`7c17bce`	`Fix documentation build`
`fcbc588`	`fix the last missing optional ImageMagick`
`5eb9bc7`	`Merge #17234: Rich output and the IPython Notebook`
`706573c`	`Merge in Sage 6.6.beta2`

vbraun commented 9 years ago

Changed dependencies from #17234, #17833 to #17234, #17833, #17288

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`e8ef55d`	`#17288 : mathjax spkg`
`8f18d36`	`#17288 strip mathjax down from 175M to <10M.`
`0443d99`	`#17288 make mathjax standard and a dependency of ipython`
`3e64ff8`	`#17288 remove the maintainer info from SPKG.txt`
`2da5a74`	`#17288 add mathjax to COPYING.txt`
`18345c7`	`#17288 do not test when removing $SAGE_SHARE/mathjax directory`
`ca645c7`	`smaller tarball, update to v2.5`
`8f46bc7`	`Merge #17288: MathJax spkg for ipython notebook`
`10c8d5d`	`Use the new IPython kernel stuff for Sage`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 706573c to 10c8d5d

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 10c8d5d to 0dfff38

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

0dfff38 delete the old ipython notebook templates

kiwifb commented 9 years ago

comment:15

Ok. Reviewing mathjax first is the low hanging fruit. Are #17234 and this ticket mutually dependent or could #17234 go in without this one?

6.6.beta2 has a lot of ticket that will require a revision of sage-on-gentoo patches, that will go first before I review stuff that is non-trivial.

vbraun commented 9 years ago

comment:16

17234 also works with IPython 2.x, but this ticket depends on it.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

e14c533 Use local docs, icon

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 0dfff38 to e14c533

vbraun commented 9 years ago

comment:18

This works now, IMHO it is at least as good as the old one ;-)

vbraun commented 9 years ago

Changed dependencies from #17234, #17833, #17288 to #17234, #17833, #17288, #17897

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from e14c533 to 284fd72

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`4748c26`	`Merge #17234: Rich output and the IPython Notebook`
`284fd72`	`Merge Trac #17897: Jsonschema package`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 284fd72 to af760e2

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

af760e2 Merge in Sage 6.6.beta3

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

b1f248d Complete documentation

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from af760e2 to b1f248d

ohanar commented 9 years ago

comment:23

After clearing out DOT_SAGE, I get this if I try to start up the notebook:

Traceback (most recent call last):
  File "/Users/ohanar/code/sage/src/bin/sage-notebook", line 192, in <module>
    launcher(unknown)
  File "/Users/ohanar/code/sage/src/bin/sage-notebook", line 79, in __init__
    SageKernelSpec.update()
  File "/Users/ohanar/code/sage/local/lib/python2.7/site-packages/sage/repl/ipython_kernel/install.py", line 218, in update
    instance.use_local_mathjax()
  File "/Users/ohanar/code/sage/local/lib/python2.7/site-packages/sage/repl/ipython_kernel/install.py", line 100, in use_local_mathjax
    self.symlink(src, dst)
  File "/Users/ohanar/code/sage/local/lib/python2.7/site-packages/sage/repl/ipython_kernel/install.py", line 81, in symlink
    os.symlink(src, dst)
OSError: [Errno 2] No such file or directory

It looks like you are trying to symlink into a directory that hasn't yet been created. Probably just need to add a mkdir -p type thing in there.

ohanar commented 9 years ago

Reviewer: R. Andrew Ohana

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from b1f248d to e070dd1

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

e070dd1 create parent directories first

vbraun commented 9 years ago

comment:25

Good point, fixed.

ohanar commented 9 years ago

comment:26

Is there any reason why you didn't set this back to needs review? Everything looks good to me.

vbraun commented 9 years ago

comment:27

sorry, forgot!

vbraun commented 9 years ago

Changed branch from u/vbraun/update_to_ipython_3_0 to e070dd1

sagemath / sage

Update to IPython 3.0 #17826

17234 also works with IPython 2.x, but this ticket depends on it.