tableau methods `bump` and `schensted_insert` perform same function

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.34k stars 460 forks source link

tableau methods `bump` and `schensted_insert` perform same function #18017

Closed 17b1eba5-ac2a-4aa9-b51b-fa077a4f050d closed 9 years ago

17b1eba5-ac2a-4aa9-b51b-fa077a4f050d commented 9 years ago

Actually schensted_insert has options form inserting on either the right or the left. Bump is equivalent to inserting on the right. Since the implementation of bump is slightly faster, we delete the _right_schensted_insert method and have schensted_insert call bump instead.

CC: @MariaMonks @darijgr

Component: combinatorics

Keywords: days64, tableau

Author: Oliver Pechenik

Branch/Commit: 9363af6

Reviewer: Darij Grinberg

Issue created by migration from https://trac.sagemath.org/ticket/18017

17b1eba5-ac2a-4aa9-b51b-fa077a4f050d commented 9 years ago

Attachment: tableau.py.gz

new version

17b1eba5-ac2a-4aa9-b51b-fa077a4f050d commented 9 years ago

comment:1

Since I cannot currently build Sage, I have attached the patch to this ticket.

b1da87f3-e506-4c3b-95bc-e2360e109e07 commented 9 years ago

Branch: u/MariaMonks/bump_schensted

b1da87f3-e506-4c3b-95bc-e2360e109e07 commented 9 years ago

New commits:

`2e8d5c4`	`fixed schensted_insert to make it more efficient`
`2cba0a1`	`fixed schensted_insert to make it more efficient`

b1da87f3-e506-4c3b-95bc-e2360e109e07 commented 9 years ago

Commit: 2cba0a1

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

b7f92a3 fixed tab character

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 2cba0a1 to b7f92a3

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from b7f92a3 to 5ba0fa3

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`65d0ebf`	`improved documentation of schensted_insert`
`5ba0fa3`	`cleaned up implementation of bump algorithm`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`2fae243`	`check for semistandardness and keep the type if so`
`243b6b4`	`fixed bump algorithm`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 5ba0fa3 to 243b6b4

darijgr commented 9 years ago

New commits:

f4633d6 review patch

darijgr commented 9 years ago

Changed commit from 243b6b4 to f4633d6

darijgr commented 9 years ago

Changed branch from u/MariaMonks/bump_schensted to public/18017

darijgr commented 9 years ago

comment:8

Good job! If you're fine with my changes, please set to positive review!

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from f4633d6 to 9363af6

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

9363af6 revert accidental removal of a doc line

17b1eba5-ac2a-4aa9-b51b-fa077a4f050d commented 9 years ago

Reviewer: Darij Grinberg

tscrim commented 9 years ago

comment:11

I was just going to put a comment about that. Also Darij, reviewer name. ;)

darijgr commented 9 years ago

comment:12

My name. I have to remember my name. :/

vbraun commented 9 years ago

Changed branch from public/18017 to 9363af6