search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.45k stars 481 forks source link

Refactor graphics / graphics array #18033

Open vbraun opened 9 years ago

vbraun commented 9 years ago

In graphics.py, a bit of refactoring could be done by creating a common parent for Graphics and GraphicsArray (maybe something like GraphicsBase).

Various show methods should maybe get moved to the SageObject class, or perhaps in some category.

Depends on #17821

CC: @novoselt @slel

Component: graphics

Issue created by migration from https://trac.sagemath.org/ticket/18033

vbraun commented 9 years ago

Dependencies: #17821

vbraun commented 9 years ago

Description changed:

--- 
+++ 
@@ -1,2 +1,4 @@
 In graphics.py, a bit of refactoring could be done by creating a common parent for Graphics and GraphicsArray (maybe something like GraphicsBase)

+Various show methods should maybe get moved to the SageObject class, or perhaps in some category.
+
slel commented 3 years ago
comment:4

If #27865 solved this, set the ticket's milestone to sage-duplicate/invalid/wontfix, so we can close.

Otherwise, it would be good to assess more precisely what is left to do here.

slel commented 3 years ago

Description changed:

--- 
+++ 
@@ -1,4 +1,7 @@
-In graphics.py, a bit of refactoring could be done by creating a common parent for Graphics and GraphicsArray (maybe something like GraphicsBase)
+In graphics.py, a bit of refactoring could be done
+by creating a common parent for `Graphics`
+and `GraphicsArray` (maybe something like `GraphicsBase`).

-Various show methods should maybe get moved to the SageObject class, or perhaps in some category.
+Various show methods should maybe get moved to the
+`SageObject` class, or perhaps in some category.