search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.41k stars 475 forks source link

cleanup of hyperbolic geodesic #18307

Closed fchapoton closed 9 years ago

fchapoton commented 9 years ago

Hyperbolic geodesics were buggy and using parametric curves.

Let us correct that and use the arc function.

CC: @tscrim @videlec

Component: graphics

Keywords: hyperbolic

Author: Frédéric Chapoton

Branch/Commit: cc64f71

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/18307

fchapoton commented 9 years ago

Branch: u/chapoton/18307

fchapoton commented 9 years ago

Commit: a95d226

fchapoton commented 9 years ago

New commits:

a95d226trac #18XXX clean-up of hyperbolic plane geodesics
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

cc64f71trac #18307 a doc typo in arc.py
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from a95d226 to cc64f71

tscrim commented 9 years ago
comment:4

LGTM.

tscrim commented 9 years ago

Reviewer: Travis Scrimshaw

vbraun commented 9 years ago

Changed branch from u/chapoton/18307 to cc64f71