sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 481 forks source link

Update Sphinx to 1.4.1 #18497

Closed a-andre closed 8 years ago

a-andre commented 9 years ago

Changes: http://sphinx-doc.org/changes.html

Tarballs:

Depends on #20496 Depends on #20498

CC: @kiwifb

Component: packages: standard

Keywords: days77

Author: André Apitzsch, Jeroen Demeyer

Branch/Commit: bdc3f0b

Reviewer: Steven Trogdon, John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/18497

jhpalmieri commented 8 years ago
comment:79

Is this ready for review?

strogdon commented 8 years ago
comment:80

So I've finally been able to build the pdf-docs without error.

jdemeyer commented 8 years ago
comment:81

Let's say it's ready for review then.

strogdon commented 8 years ago
comment:82

This looks good. Everything builds here. I do see

Makefile:27: recipe for target 'all-pdf-ja' failed
make[2]: [all-pdf-ja] Error 255 (ignored)
for f in *.tex; do platex -kanji=utf8  $f; done

when building the Japanese pdfs (the two Japanese pdfs are generated and, as far as I can determine, look OK). Perhaps a consequence of my system Japanese lang installation which took some effort to get it to work.

@jhpalmieri (John) add your name if you concur.

strogdon commented 8 years ago

Reviewer: Steven Trogdon

jhpalmieri commented 8 years ago

Changed reviewer from Steven Trogdon to Steven Trogdon, John Palmieri

jdemeyer commented 8 years ago
comment:84

I never managed to get the Japanese docs working, so I cannot fully test that either.

vbraun commented 8 years ago

Changed branch from u/jdemeyer/ticket/18497 to bdc3f0b