search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.42k stars 478 forks source link

ascii and unicode arts for continued fractions #18747

Closed videlec closed 9 years ago

videlec commented 9 years ago 
sage: unicode_art(continued_fraction(pi))
                             1                          
3 + ────────────────────────────────────────────────────
                                1                       
     7 + ───────────────────────────────────────────────
                                   1                    
          15 + ─────────────────────────────────────────
                                     1                  
                1 + ────────────────────────────────────
                                         1              
                     292 + ─────────────────────────────
                                           1            
                            1 + ────────────────────────
                                              1         
                                 1 + ───────────────────
                                                1       
                                      1 + ──────────────
                                                   1    
                                           2 + ─────────
                                                1 + ...

CC: @sagetrac-tmonteil @vbraun

Component: basic arithmetic

Author: Vincent Delecroix

Branch/Commit: 6e4744a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/18747

videlec commented 9 years ago

Branch: u/vdelecroix/18747

videlec commented 9 years ago

New commits:

c327971Trac #18747: ascii art for continued fractions
videlec commented 9 years ago

Commit: c327971

tscrim commented 9 years ago

Reviewer: Travis Scrimshaw

tscrim commented 9 years ago
comment:2

LGTM modulo making the input - ``x`` -- with two dashes as that is the Sage convention. Once you make this tweak, positive review. Thanks.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from c327971 to 6e4744a

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

6e4744aTrac #18747: two dashes
vbraun commented 9 years ago

Changed branch from u/vdelecroix/18747 to 6e4744a