Bug in continued fractions of real literal

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.42k stars 478 forks source link

Bug in continued fractions of real literal #18901

Closed videlec closed 9 years ago

videlec commented 9 years ago

As reported in #14567, continued_fraction fails for real literals

sage: continued_fraction_list(1.575709393346379)
Error in lines 1-1
Traceback (most recent call last):
...
ValueError: does not know how to compute the continued fraction of 1.57570939334638

CC: @williamstein

Component: number theory

Author: Vincent Delecroix

Branch/Commit: 8d86cb3

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/18901

videlec commented 9 years ago

Commit: 81d11d0

videlec commented 9 years ago

Branch: u/vdelecroix/18901

videlec commented 9 years ago

New commits:

81d11d0 Trac #18901: continued fraction of real literals

seblabbe commented 9 years ago

Changed branch from u/vdelecroix/18901 to public/18901

seblabbe commented 9 years ago

comment:2

I tested this ticket. The problem is fixed. The handling of real litteral is really done in the continued_fraction_list function, so I moved the new doctest there. I posted this changes in the branch public/18901. Tell me if you do not agree or set this to positive review.

Sébastien

New commits:

e55a0d4 Trac #18901: moved new test to continued_fraction_list

seblabbe commented 9 years ago

Changed commit from 81d11d0 to e55a0d4

seblabbe commented 9 years ago

Reviewer: Sébastien Labbé

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

b8eedc4 Trac #18901: readd part of test to continued_fraction

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from e55a0d4 to b8eedc4

videlec commented 9 years ago

comment:5

Hello,

This is wrong

TESTS::

Fixed ...

It should be

TESTS:

Fixed ...

Vincent

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

8d86cb3 Trac #18901: Fix ReST syntax

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from b8eedc4 to 8d86cb3

vbraun commented 9 years ago

Changed branch from public/18901 to 8d86cb3