Check CPLEXBackend.solver_parameter

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.48k stars 488 forks source link

Check CPLEXBackend.solver_parameter #19117

Closed 6bdad4c1-1e26-4f2f-a442-a01a2292c181 closed 9 years ago

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

Turns out that CPLEX does not check it getter/setters in solver_parameter. But that was before.

I also change the entry of the "numerical/" folder from "Optimization" to "Numerical Optimization" in the reference manual.

Nathann

Depends on #19090

CC: @dcoudert

Component: numerical

Author: Nathann Cohen

Branch/Commit: 3f2b208

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/19117

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

Author: Nathann Cohen

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

Dependencies: #19090

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

Branch: u/ncohen/19117

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Commit: 3f2b208

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`964bbbb`	`trac #19090: enable access to bestobjval and mipgap with cplex`
`808e793`	`trac #19090: Merged with 6.9.beta4`
`6d2bb32`	`trac #19090: Callback function in GLPK`
`5fd0166`	`trac #19090: enable access to bestobjval and mipgap with GLPK`
`c35433d`	`trac #19090: add methods to mip.pyx`
`3f2b208`	`trac #19117: Check CPLEXBackend.solver_parameter`

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

Description changed:

--- 
+++ 
@@ -1,6 +1,4 @@
-Turns out that the following works
-
-But that was before.
+Turns out that CPLEX does not check it getter/setters in solver_parameter. But that was before.

 I also change the entry of the "numerical/" folder from "Optimization" to "Numerical Optimization" in the reference manual.

dcoudert commented 9 years ago

comment:4

For me the patch is good to go. However, shouldn't you rebase it on last version of 19090? git remains a mistery for me... David.

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

comment:5

It does not seem to be necessary, there is no conflict when I merge the two.

Nathann

dcoudert commented 9 years ago

comment:6

Then...

dcoudert commented 9 years ago

Reviewer: David Coudert

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

comment:7

Thaaaaaaaanks !

vbraun commented 9 years ago

Changed branch from u/ncohen/19117 to 3f2b208