Cremona-Richmond configuration

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.47k stars 487 forks source link

Cremona-Richmond configuration #19277

Closed 6bdad4c1-1e26-4f2f-a442-a01a2292c181 closed 9 years ago

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

I saw this on wikipedia and thought that it would give some company to the single member of hypergraphs., but then I noticed that a GQ was probably a design too.

So here it is, a new element for designs.<tab>.

Nathann

Component: combinatorial designs

Author: Nathann Cohen

Branch/Commit: 575eeb5

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/19277

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

Branch: u/ncohen/19277

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

New commits:

5fbd6a3 trac #19227: Cremona-Richmond configuration

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

Commit: 5fbd6a3

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 5fbd6a3 to 28d6c6e

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

28d6c6e trac #19227: Cremona-Richmond configuration

fchapoton commented 9 years ago

comment:3

One remark, and one worry:

I had to look at the doc of bipartite_sets, and it is not very clear what is a bipartite set, even if I can guess.
The utf8 dash symbol in the wikipedia link may prevent the doc to build (did you check ?). It could be replaced by just a minus sign and wikipedia will do the redirection.

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

comment:4

Hello,

I had to look at the doc of bipartite_sets, and it is not very clear what is a bipartite set, even if I can guess.

Yeah, right. It has been around for a while like that, it must be the first time I use it. If you want to rename it under a more meaningful name, I have no objection at all. If it were only me I'd turn it into is_bipartite(certificate=True) or something.

The utf8 dash symbol in the wikipedia link may prevent the doc to build (did you check ?). It could be replaced by just a minus sign and wikipedia will do the redirection.

Both html and pdf doc compile, though the link is wrong in the pdf doc. I'll add a commit.

Nathann

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

575eeb5 trac #19277: Fixed doc

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 28d6c6e to 575eeb5

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

comment:6

Now the pdf link is correct. I had also forgotten to add the constructor to the index.

Nathann

fchapoton commented 9 years ago

comment:7

ok, good to go

fchapoton commented 9 years ago

Reviewer: Frédéric Chapoton

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 9 years ago

comment:8

Thanks !

vbraun commented 9 years ago

Changed branch from u/ncohen/19277 to 575eeb5