QQbar.polynomial_root(): allow approximate root - Githubissues

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.45k stars 481 forks source link

QQbar.polynomial_root(): allow approximate root #19356

Open jdemeyer opened 9 years ago

jdemeyer commented 9 years ago

Instead of only allowing an interval containing a root, an approximate root should also be accepted.

Depends on #19362

Component: algebra

Keywords: qqbar

Author: Jeroen Demeyer

Branch/Commit: u/cremona/19356 @ afa1798

Issue created by migration from https://trac.sagemath.org/ticket/19356

jdemeyer commented 9 years ago

Changed dependencies from #19330 to #19362

jdemeyer commented 9 years ago

Branch: u/jdemeyer/qqbar_polynomial_root____allow_approximate_root

jdemeyer commented 9 years ago

Commit: 41aaf04

jdemeyer commented 9 years ago

New commits:

`2049f5a`	`Move refine_root() to refine_root.pyx`
`3b34e49`	`Improve refine_root()`
`41aaf04`	`Allow approximate root in polynomial_root()`

JohnCremona commented 8 years ago

comment:4

I'm not sure why this never got reviewed, so I am reviewing it after rebasing it on 7.1.beta3 (actually merging not rebasing). The code looks good, but I suppose that #19362 needs finishing first. I am not sure what the needs_work issue is with that one?

JohnCremona commented 8 years ago

Changed commit from 41aaf04 to afa1798

JohnCremona commented 8 years ago

Changed branch from u/jdemeyer/qqbar_polynomial_root____allow_approximate_root to u/cremona/19356

JohnCremona commented 8 years ago

New commits:

afa1798 Merge branch 'develop (7.1.beta3)' into 19356

JohnCremona commented 8 years ago

comment:6

I merged with current develop (7.1.beta3). One minor doctest change was needed in QQbar. I hope I did not break etiquette ('ticket-etiquette'!) by doing so and pushing the branch with my name on...

cheuberg commented 7 years ago

comment:7

merge conflict

jplab commented 5 years ago

Changed keywords from none to qqbar