Deprecate the "continued fraction field"

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.4k stars 473 forks source link

Deprecate the "continued fraction field" #19476

Closed videlec closed 8 years ago

videlec commented 9 years ago

The continuous fraction field serves no purpose (except being a wrong clone of the rational numbers).

CC: @sagetrac-tmonteil @nathanncohen

Component: algebra

Branch/Commit: u/vdelecroix/19476 @ 3d3e3c0

Reviewer: Vincent Delecroix, Thierry Monteil

Issue created by migration from https://trac.sagemath.org/ticket/19476

videlec commented 9 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-The continuous fraction field serves no purpose (instead of being a wrong clone of the rational numbers).
+The continuous fraction field serves no purpose (except being a wrong clone of the rational numbers).

videlec commented 9 years ago

Branch: u/vdelecroix/19476

videlec commented 9 years ago

Commit: 4aa7194

videlec commented 9 years ago

New commits:

4aa7194 Trac 19476: deprecate the continued fraction field

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

3d3e3c0 Trac 19476: remove CFF from the latex preambles

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 9 years ago

Changed commit from 4aa7194 to 3d3e3c0

jdemeyer commented 8 years ago

comment:5

Continued fractions are still used in src/sage/databases/oeis.py.

mo271 commented 8 years ago

comment:6

Is there still a problem with src/sage/databases/oeis.py ?

jdemeyer commented 8 years ago

comment:7

I think this is actually a duplicate of #20012.

jdemeyer commented 8 years ago

Reviewer: Vincent Delecroix

jdemeyer commented 8 years ago

Changed author from Vincent Delecroix to none

edd8e884-f507-429a-b577-5d554626c0fe commented 8 years ago

Changed reviewer from Vincent Delecroix to Vincent Delecroix, Thierry Monteil

edd8e884-f507-429a-b577-5d554626c0fe commented 8 years ago

comment:9

Replying to @mo271:

Is there still a problem with src/sage/databases/oeis.py ?

The use of CFF in oeis.py has been fixed already (see the header of the file), so no problem here.

It is indeed a duplicate of #20012. However this latter has been closed and does not take into account the commit about latex of this ticket, i guess this macro should be removed once we remove the deprecation warning, so let us not forget about that in one year.